Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DROOLS-4184 Fix first set of issues reported by SonarCloud (#2398)

* DROOLS-4181 Fix blocker issues reported by SonarCloud

* DROOLS-4181 Fix critical issues reported by SonarCloud

* DROOLS-4181 Fix first set of major issues reported by SonarCloud

* DROOLS-4181 Fix second set of major issues reported by SonarCloud

* DROOLS-4181 Fix third set of major issues reported by SonarCloud

* DROOLS-4181 Fix test related to SonarCloud fixes.

* DROOLS-4181 Fix downstream problems.

    • -0
    • +2
    ./descr/AbstractClassTypeDeclarationDescr.java
  1. … 142 more files in changeset.
[DROOLS-4095] fix parsing of null-safe dereferencing operator after a method invocation

  1. … 2 more files in changeset.
[DROOLS-3499] allow both prefixed and infixed AND in nested accumulates

  1. … 1 more file in changeset.
[DROOLS-3499] allow both prefixed and infixed AND in nested accumulates (#2210)

  1. … 1 more file in changeset.
DROOLS-3355: Improve Assembler/Weaver API (#2181)

* cleanup

* fix compile

* rename AssemblerContext to DroolsAssemblerContext

* whitespace

* docs

* simpler ProcessPackage API

* use less specific result type in processbuilder interface

* revert process changes

* fix package serialization

* require non-null namespace on BaseDescr

as a side-effect: raises an expected exception in a jbpm test

  1. … 32 more files in changeset.
[DROOLS-2831] avoid holding references to working memory and fact handles in EvaluatorWrapper

  1. … 13 more files in changeset.
[FINDBUGS] First bunch of fixes for problems reported by FindBugs in drools-core (#1971)

* [findbugs] Create classloaders only inside doPrivileged block

* [findbugs] Use correct map for accumulate imports initialization

* [findbugs] Uncallable method defined in anonymous class

* [findbugs] Impossible cast

* [findbugs] Code checks for specific values returned by compareTo

* [findbugs] Bad attempt to compute abs. value of signed 32-bit hashcode

* [findbugs] Nullcheck of value previously dereferenced

* [findbugs] Uninit. read of field method called from constr. of superclass

* [findbugs] equals overrides equals in superclass and may not be symmetric

* [findbugs] Possible null pointer dereference

* [findbugs] Fix failing tests

* [findbugs] Should be a static inner class

* [findbugs] Private method is never called

* [findbugs] Inefficient use of keySet iterator instead of entrySet iterator

* [findbugs] Private method is never called

* [findbugs] Method concatenates strings using + in a loop

* [findbugs] Method invokes inefficient Number constructor

* [findbugs] Boxing/unboxing to parse a primitive

* [findbugs] Boxed value is unboxed and then immediately reboxed

* [findbugs] Other boxing/unboxing issues

* [findbugs] Method allocates a boxed primitive just to call toString

* [findbugs] Fix test

* [findbugs] Sequence of calls to concurrent abstraction may not be atomic

* [findbugs] Possible double check of field (double-checked locking)

* [findbugs] Method does not release lock on all exception paths

* [findbugs] Class is Serializable, but doesn't define serialVersionUID

* [findbugs] Method ignores exceptional return value

* [findbugs] Method uses the same code for two branches

* [findbugs] Write to static field from instance method

* Revert to instanceOf comparison

  1. … 65 more files in changeset.
[DROOLS-2471] fix dsl generation of constraints invoking method on a variable bound from a different patter in executable model

  1. … 2 more files in changeset.
[DROOLS-2471] fix dsl generation of constraints invoking method on a variable bound from a different patter in executable model

(cherry picked from commit 47f0fa4fb05f030b741450f95e4e28344515c029)

  1. … 2 more files in changeset.
[DROOLS-2284] coerce right part of binary expressions when necessary + support predicates and consequences throwing checked exceptions in executable model

  1. … 31 more files in changeset.
add support for expressions with 4 and 5 variables + fix forall in executable model

  1. … 12 more files in changeset.
Use visitor pattern instead of instanceof in ModelGenerator (#1666)

* Use visitor pattern

Moved visitors in package

OOPathVisitor => OOPathGenerator

GenerateModel Visitor

Specific visitors in classes

* Move DrlxParseResult.java to a separate class and encapsulate fields

* Replace package private fields with accessors

* Replace package private fields with accessors in RuleContext

    • -0
    • +29
    ./descr/DescrVisitor.java
  1. … 21 more files in changeset.
[DROOLS-1707] retrieve unchanged type declarations from existing kiebase during incremental compilation (#1425)

(cherry picked from commit 0305f96bef96cc06f2ac7c5188c857fdbfae94d1)

  1. … 2 more files in changeset.
[DROOLS-1707] retrieve unchanged type declarations from existing kiebase during incremental compilation (#1425)

(cherry picked from commit 0305f96bef96cc06f2ac7c5188c857fdbfae94d1)

  1. … 2 more files in changeset.
[DROOLS-1707] retrieve unchanged type declarations from existing kiebase during incremental compilation (#1425)

  1. … 2 more files in changeset.
DROOLS-1677 - not /someOoPath not supported (#1384)

Adjust parser for appropriate look-ahead around DIV and un-labeled

OOPath constraints.

  1. … 1 more file in changeset.
Allow query rules to be in a RuleUnit.

    • -0
    • +1
    ./api/impl/PackageDescrBuilderImpl.java
refactor of type declaration creation and property reactive mask calculation (#1290)

  1. … 18 more files in changeset.
[DROOLS-1564] change oopath syntax (#1268)

(cherry picked from commit 9b66b6cddbdf7efd62d24d63d228935a2951d5f7)

  1. … 22 more files in changeset.
[DROOLS-1564] change oopath syntax (#1268)

  1. … 22 more files in changeset.
[DROOLS-1544] ensure that ReturnValueRestrictionDescr has a reference to the resource from which it has been created (#1247)

* DROOLS-1544: Incremental Compilation with GDST ResourceType fails

* [DROOLS-1544] ensure that ReturnValueRestrictionDescr has a reference to the resource from which it has been created

    • -1
    • +1
    ./descr/EvaluatorBasedRestrictionDescr.java
    • -30
    • +6
    ./descr/ReturnValueRestrictionDescr.java
  1. … 3 more files in changeset.
[DROOLS-1544] ensure that ReturnValueRestrictionDescr has a reference to the resource from which it has been created (#1247)

* DROOLS-1544: Incremental Compilation with GDST ResourceType fails

* [DROOLS-1544] ensure that ReturnValueRestrictionDescr has a reference to the resource from which it has been created

(cherry picked from commit d17656db081d774558257dc498094978fbafe25a)

    • -1
    • +1
    ./descr/EvaluatorBasedRestrictionDescr.java
    • -30
    • +6
    ./descr/ReturnValueRestrictionDescr.java
  1. … 3 more files in changeset.
[DROOLS-1491] allow a type declaration to extend a Java class (#1156)

    • -11
    • +10
    ./descr/AbstractClassTypeDeclarationDescr.java
  1. … 3 more files in changeset.
[DROOLS-1445] make property reactivity to also automatically watch va… (#1112)

[DROOLS-1445] make property reactivity to also automatically watch variables used in patterns different from the declaring one

  1. … 8 more files in changeset.
[DROOLS-1446] ruleunit implementation (#1107)

    • -0
    • +32
    ./api/UnitDescrBuilder.java
    • -5
    • +13
    ./api/impl/PackageDescrBuilderImpl.java
    • -0
    • +36
    ./api/impl/UnitDescrBuilderImpl.java
  1. … 191 more files in changeset.
[DROOLS-1411] fix constraint using declaration bound to oopath + compil… (#1070)

* [DROOLS-1411] fix constraint using declaration bound to oopath + compile-time error using more than one oopath in same pattern + fix use of local declarations inside an oopath

  1. … 8 more files in changeset.
DROOLS-1337 A FQN inline cast followed by a method invocation causes an ArrayIndexOutOfBoundsException (#976)

  1. … 1 more file in changeset.
[DROOLS-1261] browse trait class hierarchy when creating a mixin and implement conflict resolution strategy

  1. … 9 more files in changeset.
[DROOLS-1261] browse trait class hierarchy when creating a mixin and implement conflict resolution strategy

(cherry picked from commit e7a8aaac83ea0e1549d3ebcfa62ad18ea50fa528)

Conflicts:

drools-compiler/src/test/java/org/drools/compiler/factmodel/traits/TraitTest.java

  1. … 9 more files in changeset.
[DROOLS-1243] prevent compilation of from patterns that cannot be matched due to type incompatibility

Built-in accumulate function result type.

(cherry picked from commit 29a1a5015575f3fd6f21b11f6c7e956f2a1c5801)

  1. … 17 more files in changeset.