Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[FINDBUGS] First bunch of fixes for problems reported by FindBugs in drools-core (#1971)

* [findbugs] Create classloaders only inside doPrivileged block

* [findbugs] Use correct map for accumulate imports initialization

* [findbugs] Uncallable method defined in anonymous class

* [findbugs] Impossible cast

* [findbugs] Code checks for specific values returned by compareTo

* [findbugs] Bad attempt to compute abs. value of signed 32-bit hashcode

* [findbugs] Nullcheck of value previously dereferenced

* [findbugs] Uninit. read of field method called from constr. of superclass

* [findbugs] equals overrides equals in superclass and may not be symmetric

* [findbugs] Possible null pointer dereference

* [findbugs] Fix failing tests

* [findbugs] Should be a static inner class

* [findbugs] Private method is never called

* [findbugs] Inefficient use of keySet iterator instead of entrySet iterator

* [findbugs] Private method is never called

* [findbugs] Method concatenates strings using + in a loop

* [findbugs] Method invokes inefficient Number constructor

* [findbugs] Boxing/unboxing to parse a primitive

* [findbugs] Boxed value is unboxed and then immediately reboxed

* [findbugs] Other boxing/unboxing issues

* [findbugs] Method allocates a boxed primitive just to call toString

* [findbugs] Fix test

* [findbugs] Sequence of calls to concurrent abstraction may not be atomic

* [findbugs] Possible double check of field (double-checked locking)

* [findbugs] Method does not release lock on all exception paths

* [findbugs] Class is Serializable, but doesn't define serialVersionUID

* [findbugs] Method ignores exceptional return value

* [findbugs] Method uses the same code for two branches

* [findbugs] Write to static field from instance method

* Revert to instanceOf comparison

    • -26
    • +11
    ./GenericKieSessionMonitoringImpl.java
  1. … 65 more files in changeset.
DROOLS-1277 Remove detailed info by process instance, ... (#904)

... keeping statistics by process (aggregated) only

(cherry picked from commit 948bb071daba1968952a6eca527822b4e5a7a68a)

Conflicts:

drools-core/src/main/java/org/drools/core/management/GenericKieSessionMonitoringImpl.java

    • -76
    • +0
    ./GenericKieSessionMonitoringImpl.java
DROOLS-1277 Remove detailed info by process instance, ... (#904)

... keeping statistics by process (aggregated) only

    • -71
    • +0
    ./GenericKieSessionMonitoringImpl.java
DROOLS-1237 force a cast to make Java 6 compatibility. (#900)

    • -3
    • +3
    ./GenericKieSessionMonitoringImpl.java
DROOLS-1237 MBean statistics from String property to proper JMX table. (#894)

MBean currently provide statistics as a String property list for

historical reasons.

As JMX support Table, rework them as proper JMX Table support.

(cherry picked from commit 195c9a60ab2b7cbd21a5f22ad5d193800cca2d2f)

    • -33
    • +72
    ./GenericKieSessionMonitoringImpl.java
    • -2
    • +2
    ./StatelessKieSessionMonitoringImpl.java
  1. … 1 more file in changeset.
DROOLS-1237 MBean statistics from String property to proper JMX table. (#894)

MBean currently provide statistics as a String property list for

historical reasons.

As JMX support Table, rework them as proper JMX Table support.

    • -33
    • +72
    ./GenericKieSessionMonitoringImpl.java
    • -2
    • +2
    ./StatelessKieSessionMonitoringImpl.java
  1. … 1 more file in changeset.
DROOLS-1236 JMX objectnaming separation for Stateful Vs Stateless (#890)

(and for alignment with RHQ/JON plug-in).

(cherry picked from commit 7fa8780980a3c6ff2940a3f93b8c16be72ab5bd0)

    • -10
    • +1
    ./GenericKieSessionMonitoringImpl.java
    • -1
    • +11
    ./StatelessKieSessionMonitoringImpl.java
  1. … 1 more file in changeset.
DROOLS-1236 JMX objectnaming separation for Stateful Vs Stateless (#890)

(and for alignment with RHQ/JON plug-in).

    • -10
    • +1
    ./GenericKieSessionMonitoringImpl.java
    • -1
    • +11
    ./StatelessKieSessionMonitoringImpl.java
  1. … 1 more file in changeset.
DROOLS-1236 MBean aggregation of statistics mechanism (#877)

* DROOLS-1236 MBean aggregation of statistics mechanism

* DROOLS-1236 MBean aggregation of statistics mechanism

refactoring MBean into different Stateful, Stateless providing tailored

methods and also better performances.

(cherry picked from commit 0a73451dd67a4ffe07e30196c78fd4e344386749)

    • -0
    • +500
    ./GenericKieSessionMonitoringImpl.java
    • -492
    • +12
    ./KieSessionMonitoringImpl.java
    • -0
    • +116
    ./StatelessKieSessionMonitoringImpl.java
  1. … 5 more files in changeset.
DROOLS-1236 MBean aggregation of statistics mechanism (#877)

* DROOLS-1236 MBean aggregation of statistics mechanism

* DROOLS-1236 MBean aggregation of statistics mechanism

refactoring MBean into different Stateful, Stateless providing tailored

methods and also better performances.

    • -0
    • +500
    ./GenericKieSessionMonitoringImpl.java
    • -492
    • +12
    ./KieSessionMonitoringImpl.java
    • -0
    • +116
    ./StatelessKieSessionMonitoringImpl.java
  1. … 5 more files in changeset.
DROOLS-1235 MBean naming rework (#866)

* Fixing kie-container monitoring

* DROOLS-1235 MBean naming rework

* give KieContainer an optional user defined name

* KieContainer MBean and various refactorings.

* jargon: containerId

* jargon: configuredReleaseId, resolvedReleaseId

* unit testing

* assuming the containerId can be "recycled" on dispose.

* introducing test for KieServices API with containerId.

* fixing other tests.

* avoid using lock and leverage ConcurrentMap without java8

* fixing objectname conventions.

  1. … 10 more files in changeset.
DROOLS-1235 MBean naming rework (#866)

* Fixing kie-container monitoring

* DROOLS-1235 MBean naming rework

* give KieContainer an optional user defined name

* KieContainer MBean and various refactorings.

* jargon: containerId

* jargon: configuredReleaseId, resolvedReleaseId

* unit testing

* assuming the containerId can be "recycled" on dispose.

* introducing test for KieServices API with containerId.

* fixing other tests.

* avoid using lock and leverage ConcurrentMap without java8

* fixing objectname conventions.

(cherry picked from commit b274c62d077b0651fe945b1075640af2a085c5c8)

  1. … 10 more files in changeset.
[DROOLS-1119] fix timers serialization (#732)

  1. … 5 more files in changeset.
[DROOLS-1119] fix timers serialization (#732) (cherry picked from commit dae76dcf996969b1804e4ccf72f675cd8dc85010)

Conflicts:

drools-persistence-jpa/src/main/java/org/drools/persistence/SingleSessionCommandService.java

  1. … 5 more files in changeset.
[DROOLS-1119] fix timers serialization (#732) (cherry picked from commit dae76dcf996969b1804e4ccf72f675cd8dc85010)

  1. … 5 more files in changeset.
changes in license header closes #586

  1. … 5166 more files in changeset.
[DROOLS-875] optimize KieSession creation performances

  1. … 7 more files in changeset.
[DROOLS-875] optimize KieSession creation performances

(cherry picked from commit 99be702bab5f1d981d1ce3118631633882af3ae7)

  1. … 7 more files in changeset.
remove legacy AgendaEventListener

  1. … 16 more files in changeset.
merge RuleBase and KnowledgeBase

  1. … 292 more files in changeset.
major cleanup 4.x legacy API

  1. … 753 more files in changeset.
remove 4.x legacy API

  1. … 596 more files in changeset.
DROOLS-192 Refactor Drools legacy classes and interfaces

  1. … 11 more files in changeset.
DROOLS-192 Refactor Drools legacy classes and interfaces

  1. … 11 more files in changeset.
Resolve split-packages: move everything from kie-api under org.kie.api: move classes directly under org.kie.event

  1. … 86 more files in changeset.
Resolve split-packages: move everything from kie-api under org.kie.api: move classes directly under org.kie.management

    • -17
    • +17
    ./KieBaseConfigurationMonitor.java
Resolve split-packages: move everything from kie-internal under org.kie.internal: move org.kie.task

  1. … 168 more files in changeset.
Resolve split-packages: move everything from kie-internal under org.kie.internal: move classes directly under org.kie

  1. … 205 more files in changeset.
Resolve split-packages: move everything from drools-core under org.drools.core: move org.drools.reteoo

  1. … 679 more files in changeset.
Resolve split-packages: move everything from drools-core under org.drools.core: move classes directly under org.drools

  1. … 504 more files in changeset.