Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DROOLS-4184 Fix first set of issues reported by SonarCloud (#2398)

* DROOLS-4181 Fix blocker issues reported by SonarCloud

* DROOLS-4181 Fix critical issues reported by SonarCloud

* DROOLS-4181 Fix first set of major issues reported by SonarCloud

* DROOLS-4181 Fix second set of major issues reported by SonarCloud

* DROOLS-4181 Fix third set of major issues reported by SonarCloud

* DROOLS-4181 Fix test related to SonarCloud fixes.

* DROOLS-4181 Fix downstream problems.

    • -3
    • +3
    ./org/drools/games/pong/PongConfiguration.java
  1. … 145 more files in changeset.
fix logging in HelloWorld example

fix compilation problem

Update backward chaining example (#2182)

Update backward chaining example

  1. … 1 more file in changeset.
Update HelloWorldExample (#2178)

Update HelloWorldExample to align with updated docs

[DROOLS-2871] remove manners example

    • -58
    • +0
    ./org/drools/benchmark/manners/Chosen.java
    • -59
    • +0
    ./org/drools/benchmark/manners/Count.java
    • -58
    • +0
    ./org/drools/benchmark/manners/Guest.java
    • -89
    • +0
    ./org/drools/benchmark/manners/Hobby.java
    • -216
    • +0
    ./org/drools/benchmark/manners/MannersBenchmark.java
    • -53
    • +0
    ./org/drools/benchmark/manners/Path.java
    • -67
    • +0
    ./org/drools/benchmark/manners/Sex.java
  1. … 36 more files in changeset.
DROOLS-1607 Internal refactor removing KnowledgeBase in preparation for DROOLS-1583 (#1293)

* DROOLS-1583 Refactor KnowledgeBaseImpl

step1

Passes just src main compilation with :

```

$ mvn clean compile -pl \!drools-examples

```

* Align drools-core tests

* Method change

InternalKnowledgeBase

from:

void addPackages( final Collection<InternalKnowledgePackage> newPkgs );

to:

void addPackages( final Collection<KiePackage> newPkgs );

* Align drools-beliefs tests.

* Align drools-cdi tests.

* Align drools-templates tests.

* Align drools-decisiontables tests.

* Align drools-verifier tests.

* Align drools-persistence-jpa tests.

* Align drools-examples CODE.

* Align drools-scorecards tests.

* Align drools-test-suite tests.

* Align removal of KnowledgeRuntimer(EventManager|Logger) interfaces.

* rebase code.

* Rebase drools-compiler tests package org.drools.compiler

* Rebase drools-compiler tests package org.drools.compiler.api

* Rebase drools-compiler tests package org.drools.compiler.beliefsystem.abductive

* Rebase drools-compiler tests package org.drools.compiler.beliefsystem.defeasible

* Rebase drools-compiler tests package org.drools.compiler.beliefsystem.jtms

* Rebase drools-compiler tests package org.drools.compiler.builder.impl

* Rebase drools-compiler tests package org.drools.compiler.command

* Rebase drools-compiler tests package org.drools.compiler.common

* Rebase drools-compiler tests package org.drools.compiler.compiler

* Rebase drools-compiler tests package org.drools.compiler.xml.changeset

* Rebase drools-compiler tests package org.drools.compiler.conf

* Rebase drools-compiler tests package org.drools.compiler.definitions

* Rebase drools-compiler tests package org.drools.compiler.factmodel.traits

* Fix rebase of CommonTestMethodBase

* Rebase drools-compiler tests package org.drools.compiler.integrationtests A-E

* Rebase drools-compiler tests package org.drools.compiler.integrationtests F-L

* Rebase drools-compiler tests package org.drools.compiler.integrationtests M-R

* Rebase drools-compiler tests package org.drools.compiler.integrationtests S-Z

* Rebase drools-compiler tests package org.drools.compiler.integrationtests.drl

* Rebase drools-compiler tests package org.drools.compiler.integrationtests.eventgenerator.example

* Rebase drools-compiler tests package org.drools.compiler.integrationtests.incrementalcompilation

* Rebase drools-compiler tests package org.drools.compiler.integrationtests.manners

* Rebase drools-compiler tests package org.drools.compiler.integrationtests.marshalling

* Rebase drools-compiler tests package org.drools.compiler.integrationtests.operators

* Rebase drools-compiler tests package org.drools.compiler.integrationtests.sequential

* Rebase drools-compiler tests package org.drools.compiler.integrationtests.session

* Rebase drools-compiler tests package org.drools.compiler.integrationtests.waltz

* Rebase drools-compiler tests package org.drools.compiler.lang.api

* Rebase drools-compiler tests package org.drools.compiler.phreak

* Rebase drools-compiler tests package org.drools.compiler.reteoo

* Rebase drools-compiler tests package org.drools.compiler.rule.builder.java

* Rebase drools-compiler tests package org.drools.compiler.rule.builder.mvel

* Rebase drools-compiler tests package org.drools.compiler.test

* Rebase drools-compiler tests package org.drools.compiler.util.debug

* Align drools-core org.drools.core.osgi.Activator CODE.

  1. … 255 more files in changeset.
Fix exception when Pong GUI window is closed, when originally launched.. (#1225)

...from the main app menu.

This fixes the stacktraces below, albeit slightly differ from original

reporter stacktrace, it manifest the same issue:

attempt to redraw GUI from rules, after CLOSE window button is pressed

from Swing side.

The solution is to let the KieSession aware the GUI is disposed, and

more generally in this case the solution is simply to halt() the

KieSession.

Exception executing consequence for rule "Redraw" in org.drools.games.pong: java.lang.RuntimeException: cannot invoke method: drawGame

at org.drools.core.runtime.rule.impl.DefaultConsequenceExceptionHandler.handleException(DefaultConsequenceExceptionHandler.java:39)

at org.drools.core.common.DefaultAgenda.handleException(DefaultAgenda.java:1256)

at org.drools.core.phreak.RuleExecutor.innerFireActivation(RuleExecutor.java:440)

at org.drools.core.phreak.RuleExecutor.fireActivation(RuleExecutor.java:382)

at org.drools.core.phreak.RuleExecutor.fire(RuleExecutor.java:136)

at org.drools.core.phreak.RuleExecutor.evaluateNetworkAndFire(RuleExecutor.java:89)

at org.drools.core.concurrent.AbstractRuleEvaluator.internalEvaluateAndFire(AbstractRuleEvaluator.java:37)

at org.drools.core.concurrent.SequentialRuleEvaluator.evaluateAndFire(SequentialRuleEvaluator.java:43)

at org.drools.core.common.DefaultAgenda.fireLoop(DefaultAgenda.java:1072)

at org.drools.core.common.DefaultAgenda.internalFireUntilHalt(DefaultAgenda.java:1001)

at org.drools.core.common.DefaultAgenda.fireUntilHalt(DefaultAgenda.java:994)

at org.drools.core.impl.StatefulKnowledgeSessionImpl.fireUntilHalt(StatefulKnowledgeSessionImpl.java:1360)

at org.drools.core.impl.StatefulKnowledgeSessionImpl.fireUntilHalt(StatefulKnowledgeSessionImpl.java:1339)

at org.drools.games.pong.PongMain$1.run(PongMain.java:56)

at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)

at java.util.concurrent.FutureTask.run(FutureTask.java:266)

at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)

at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)

at java.lang.Thread.run(Thread.java:745)

Caused by: java.lang.RuntimeException: cannot invoke method: drawGame

at org.mvel2.optimizers.impl.refl.nodes.MethodAccessor.getValue(MethodAccessor.java:55)

at org.mvel2.optimizers.impl.refl.nodes.VariableAccessor.getValue(VariableAccessor.java:37)

at org.mvel2.ast.ASTNode.getReducedValueAccelerated(ASTNode.java:108)

at org.mvel2.MVELRuntime.execute(MVELRuntime.java:85)

at org.mvel2.compiler.CompiledExpression.getDirectValue(CompiledExpression.java:123)

at org.mvel2.compiler.CompiledExpression.getValue(CompiledExpression.java:119)

at org.mvel2.MVEL.executeExpression(MVEL.java:929)

at org.drools.core.base.mvel.MVELConsequence.evaluate(MVELConsequence.java:110)

at org.drools.core.phreak.RuleExecutor.innerFireActivation(RuleExecutor.java:433)

... 16 more

Caused by: java.lang.reflect.InvocationTargetException

at sun.reflect.GeneratedMethodAccessor21.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:498)

at org.mvel2.optimizers.impl.refl.nodes.MethodAccessor.getValue(MethodAccessor.java:40)

... 24 more

Caused by: java.lang.IllegalStateException: Component must have a valid peer

at java.awt.Component$FlipBufferStrategy.getBackBuffer(Component.java:4067)

at java.awt.Component$FlipBufferStrategy.updateInternalBuffers(Component.java:4050)

at java.awt.Component$FlipBufferStrategy.revalidate(Component.java:4165)

at java.awt.Component$FlipBufferStrategy.revalidate(Component.java:4147)

at java.awt.Component$FlipBufferStrategy.getDrawGraphics(Component.java:4139)

at org.drools.games.GameUI.getGraphics(GameUI.java:87)

at org.drools.games.pong.PongUI.drawGame(PongUI.java:59)

... 28 more

(cherry picked from commit 169c596e59f75f9ee97cb728b013fed21f543f36)

    • -0
    • +14
    ./org/drools/games/pong/PongUI.java
Fix exception when Pong GUI window is closed, when originally launched.. (#1225)

...from the main app menu.

This fixes the stacktraces below, albeit slightly differ from original

reporter stacktrace, it manifest the same issue:

attempt to redraw GUI from rules, after CLOSE window button is pressed

from Swing side.

The solution is to let the KieSession aware the GUI is disposed, and

more generally in this case the solution is simply to halt() the

KieSession.

Exception executing consequence for rule "Redraw" in org.drools.games.pong: java.lang.RuntimeException: cannot invoke method: drawGame

at org.drools.core.runtime.rule.impl.DefaultConsequenceExceptionHandler.handleException(DefaultConsequenceExceptionHandler.java:39)

at org.drools.core.common.DefaultAgenda.handleException(DefaultAgenda.java:1256)

at org.drools.core.phreak.RuleExecutor.innerFireActivation(RuleExecutor.java:440)

at org.drools.core.phreak.RuleExecutor.fireActivation(RuleExecutor.java:382)

at org.drools.core.phreak.RuleExecutor.fire(RuleExecutor.java:136)

at org.drools.core.phreak.RuleExecutor.evaluateNetworkAndFire(RuleExecutor.java:89)

at org.drools.core.concurrent.AbstractRuleEvaluator.internalEvaluateAndFire(AbstractRuleEvaluator.java:37)

at org.drools.core.concurrent.SequentialRuleEvaluator.evaluateAndFire(SequentialRuleEvaluator.java:43)

at org.drools.core.common.DefaultAgenda.fireLoop(DefaultAgenda.java:1072)

at org.drools.core.common.DefaultAgenda.internalFireUntilHalt(DefaultAgenda.java:1001)

at org.drools.core.common.DefaultAgenda.fireUntilHalt(DefaultAgenda.java:994)

at org.drools.core.impl.StatefulKnowledgeSessionImpl.fireUntilHalt(StatefulKnowledgeSessionImpl.java:1360)

at org.drools.core.impl.StatefulKnowledgeSessionImpl.fireUntilHalt(StatefulKnowledgeSessionImpl.java:1339)

at org.drools.games.pong.PongMain$1.run(PongMain.java:56)

at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)

at java.util.concurrent.FutureTask.run(FutureTask.java:266)

at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)

at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)

at java.lang.Thread.run(Thread.java:745)

Caused by: java.lang.RuntimeException: cannot invoke method: drawGame

at org.mvel2.optimizers.impl.refl.nodes.MethodAccessor.getValue(MethodAccessor.java:55)

at org.mvel2.optimizers.impl.refl.nodes.VariableAccessor.getValue(VariableAccessor.java:37)

at org.mvel2.ast.ASTNode.getReducedValueAccelerated(ASTNode.java:108)

at org.mvel2.MVELRuntime.execute(MVELRuntime.java:85)

at org.mvel2.compiler.CompiledExpression.getDirectValue(CompiledExpression.java:123)

at org.mvel2.compiler.CompiledExpression.getValue(CompiledExpression.java:119)

at org.mvel2.MVEL.executeExpression(MVEL.java:929)

at org.drools.core.base.mvel.MVELConsequence.evaluate(MVELConsequence.java:110)

at org.drools.core.phreak.RuleExecutor.innerFireActivation(RuleExecutor.java:433)

... 16 more

Caused by: java.lang.reflect.InvocationTargetException

at sun.reflect.GeneratedMethodAccessor21.invoke(Unknown Source)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:498)

at org.mvel2.optimizers.impl.refl.nodes.MethodAccessor.getValue(MethodAccessor.java:40)

... 24 more

Caused by: java.lang.IllegalStateException: Component must have a valid peer

at java.awt.Component$FlipBufferStrategy.getBackBuffer(Component.java:4067)

at java.awt.Component$FlipBufferStrategy.updateInternalBuffers(Component.java:4050)

at java.awt.Component$FlipBufferStrategy.revalidate(Component.java:4165)

at java.awt.Component$FlipBufferStrategy.revalidate(Component.java:4147)

at java.awt.Component$FlipBufferStrategy.getDrawGraphics(Component.java:4139)

at org.drools.games.GameUI.getGraphics(GameUI.java:87)

at org.drools.games.pong.PongUI.drawGame(PongUI.java:59)

... 28 more

    • -0
    • +14
    ./org/drools/games/pong/PongUI.java
fix examples after having enabled property reactivity by default (#1129)

(cherry picked from commit 02004198b9598fc7445754e85bbf84ad2810383d)

    • -3
    • +0
    ./org/drools/examples/fire/Sprinkler.java
  1. … 52 more files in changeset.
fix examples after having enabled property reactivity by default (#1129)

    • -3
    • +0
    ./org/drools/examples/fire/Sprinkler.java
  1. … 52 more files in changeset.
[DROOLS-1377] remove reteoo implementation (#1026)

  1. … 574 more files in changeset.
Fix drools-example GameUI keylistener (#1020)

Avoid to Pong, Invaders end users the need to click the Canvas in order

to actually produce the key pressed events.

This way, the external JFrame registers the keylistener.

The internal JPanel and Canvas are not responsive to the user hence are

set as non-focusable.

When the external JFrame becomes visible, the keylistener is immediately

active to create the key pressed events necessary for the game/rules.

Please notice GameUI is only used by Canvas-based games: Pong, Invaders.

Fix drools-example GameUI keylistener (#1020)

Avoid to Pong, Invaders end users the need to click the Canvas in order

to actually produce the key pressed events.

This way, the external JFrame registers the keylistener.

The internal JPanel and Canvas are not responsive to the user hence are

set as non-focusable.

When the external JFrame becomes visible, the keylistener is immediately

active to create the key pressed events necessary for the game/rules.

Please notice GameUI is only used by Canvas-based games: Pong, Invaders.

(cherry picked from commit 5ed5a5baac717242f1f76977b2b309c9c5750c95)

Fix drools-example Sudoku grid "Dump" feature (#1018)

(cherry picked from commit 6c2d532b369addaa75d3e886510c8d43cd03f48f)

    • -4
    • +6
    ./org/drools/examples/sudoku/Sudoku.java
Fix drools-example Sudoku grid "Dump" feature (#1018)

    • -4
    • +6
    ./org/drools/examples/sudoku/Sudoku.java
-pong fixes. Redraw is now simpler. (#964)

-Reversed dispose and show double buffer

(cherry picked from commit d0ebd561fc9490245ed7aece039ac02240e10cd3)

    • -22
    • +5
    ./org/drools/games/pong/PongUI.java
  1. … 3 more files in changeset.
-pong fixes. Redraw is now simpler. (#964)

-Reversed dispose and show double buffer

    • -22
    • +5
    ./org/drools/games/pong/PongUI.java
  1. … 3 more files in changeset.
Pull947+mmortari (#952)

* -Fixed double buffering for Invaders

-Added sleep to try and average closed to 60 FPS

* DROOLS-1258

Based on Mark's PR "-Fixed double buffering for Invaders" #947

(cherry picked from commit 09f76e900d78a40569d105a2704fa23a76d15f89)

    • -0
    • +28
    ./org/drools/games/invaders/FPSTimer.java
    • -0
    • +1
    ./org/drools/games/invaders/Invaders6Main.java
  1. … 7 more files in changeset.
Pull947+mmortari (#952)

* -Fixed double buffering for Invaders

-Added sleep to try and average closed to 60 FPS

* DROOLS-1258

Based on Mark's PR "-Fixed double buffering for Invaders" #947

(cherry picked from commit 09f76e900d78a40569d105a2704fa23a76d15f89)

(cherry picked from commit b9e5368d7ac51964788235547b2dfdaa368cff0b)

    • -0
    • +28
    ./org/drools/games/invaders/FPSTimer.java
    • -0
    • +1
    ./org/drools/games/invaders/Invaders6Main.java
  1. … 7 more files in changeset.
Pull947+mmortari (#952)

* -Fixed double buffering for Invaders

-Added sleep to try and average closed to 60 FPS

* DROOLS-1258

Based on Mark's PR "-Fixed double buffering for Invaders" #947

    • -0
    • +28
    ./org/drools/games/invaders/FPSTimer.java
    • -0
    • +1
    ./org/drools/games/invaders/Invaders6Main.java
  1. … 7 more files in changeset.
uncomment trait examples

uncomment trait examples

(cherry picked from commit 7973f4beab4e14ecca0e23cbe551c986761210d3)

[DROOLS-1261] browse trait class hierarchy when creating a mixin and implement conflict resolution strategy

  1. … 9 more files in changeset.
[DROOLS-1261] browse trait class hierarchy when creating a mixin and implement conflict resolution strategy

(cherry picked from commit e7a8aaac83ea0e1549d3ebcfa62ad18ea50fa528)

Conflicts:

drools-compiler/src/test/java/org/drools/compiler/factmodel/traits/TraitTest.java

  1. … 9 more files in changeset.
-improve the invaders game, to demonstrate transitive closures via the "search" command. (#857)

-Update the game to lock the door and place the key in an envelop, which is in a draw, which is in desk.

    • -1
    • +8
    ./org/drools/games/adventures/GameEngine.java
    • -0
    • +7
    ./org/drools/games/adventures/UserSession.java
    • -0
    • +64
    ./org/drools/games/adventures/model/SearchCommand.java
  1. … 4 more files in changeset.
-improve the invaders game, to demonstrate transitive closures via the "search" command. (#857)

-Update the game to lock the door and place the key in an envelop, which is in a draw, which is in desk.

(cherry picked from commit b5b093a61a06f2ff479e216b87f8ae01f323bff1)

    • -1
    • +8
    ./org/drools/games/adventures/GameEngine.java
    • -0
    • +7
    ./org/drools/games/adventures/UserSession.java
    • -0
    • +64
    ./org/drools/games/adventures/model/SearchCommand.java
  1. … 4 more files in changeset.
contextual conversations

  1. … 49 more files in changeset.
[DROOLS-1026] Allow FromNodes sharing

  1. … 26 more files in changeset.
[DROOLS-1026] Allow FromNodes sharing

(cherry picked from commit b9b06186b1d632cfeacd7ac4619e262439b2352c)

  1. … 26 more files in changeset.