Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DROOLS-4529 Use KnowledgeBuilder directly to handle process resources (#2539)

[DROOLS-4307] Drools unable to compile rules when using a declared enum in the DRL file (#2536)

* Added new test for enum field

* Support for enum

* Support for enum

* EnumGenerator

* POJOGenerator is not static anymore

* Refactor

* Enum Generator

* Test for enum in DeclaredTypesTest.java

* Moved POJO generator to package

* Removed test

* Removed test

* Green tests

* Simplified toClassDeclaration

* Extracted GeneratedHashCode

* Moved toString generation

* Separated generated equals

* Generated constructor

* Split constructor and annotation processor

* Separated construction generation

* Added comment for failing test

* FullArgumentConstructor

* NoConstructor

* Ignore soft annotations by passing empty list

* Refactor

* Processing of EnumDescr in ModelBuilderImpl.java

* Generation of enum, passing test

* Refactor

* SonarLint

* Fix regression in error messages

  1. … 7 more files in changeset.
[DROOLS-4509] fix @watch on an alpha node followed by a from

  1. … 3 more files in changeset.
[DROOLS-4492] fix type declaration definition in executable model

  1. … 3 more files in changeset.
[DROOLS-4475] generate stable ids for field indexes across different executable model compilations (#2523)

  1. … 4 more files in changeset.
DROOLS-4458 Fix String to Boolean coercion in executable model (#2513)

  1. … 2 more files in changeset.
[DROOLS-4374] Align error messages when missing semicolons (#2501)

  1. … 1 more file in changeset.
[DROOLS-4546] BigDecimal in from accumulate with MVEL with executable-model (#2497)

* Tests

* Post process phase to transform BigDecimal literals after having processed the LHS phase

* Convert BigDecimal assign plus operator to add or remove

* Passing AccumulateTest

* Null case for BigDecimalConversion

* Moved accumulateInline in separate class

* Moved to constructor

* Removed dead code

* Refactor of AccumulateInline

* Mvel compiler is a field

* New field

* Avoid recompile init block twice

* Use inline template in resource folder

* Use specific exception

* First refactor of parseInitBlock

* Remove dead code

* use MVEL compiler for everything

* Better control flow

* Check for unsupported Inline Accumulate

* Better control flow for LegacyAccumulateInline

* Better control flow for LegacyAccumulateInline

* Moved reverse method closer

* write accumulate method closer

* Extracted parsing method

* Rename

* Moved method

* Removed TODO

* Reverted unwanted commit

  1. … 14 more files in changeset.
[DROOLS-4291] ModelWriter: refactor to smaller classes (#2428)

* [DROOLS-4291] ModelWriter: refactor to smaller classes

* fix: did not set file names correctly, did not add models to list

* adjust path for broken integration tests

    • -0
    • +50
    ./org/drools/modelcompiler/builder/AccumulateClassWriter.java
    • -0
    • +47
    ./org/drools/modelcompiler/builder/DeclaredTypeWriter.java
    • -0
    • +56
    ./org/drools/modelcompiler/builder/PackageModelWriter.java
    • -0
    • +92
    ./org/drools/modelcompiler/builder/RuleWriter.java
[DROOLS-4376] [DROOLS-4377] [DROOLS-4831] (#2490)

* CompilerTest.testMapAbbreviatedComparison

* New case for ExpressionTyper

* Refactor

* WithCast

* Removed author and javadoc for HalfBinary

* New test for simple half binary

* Avoid handcrafted parsing

* Avoid putting meaningless generic type into parameter

* Allow special comparison case to change the expression

* Default in findLelftLeafOfNameExpr

* Refactor PatternDSL

* Removed impl from Implementation causing OSGi to fail

* Fix rebase

* Avoid handcrafted parsing

* Allow special comparison case to change the expression

* test and first refactor

* Can coerce map

* added todo

* Fix ExpressionTyper test

* Coerce map expressions

* Better check

* Remove useless cast to object

* SonarLint

  1. … 4 more files in changeset.
[DROOLS-4382] fix function invocation as argument of a point-free expression in executable model

  1. … 4 more files in changeset.
DROOLS-4343 Change fact handle id type to long (#2468)

* DROOLS-4343 Change fact handle id type to long

* DROOLS-4343 Change fact handle id type to long

  1. … 35 more files in changeset.
DROOLS-4362 Fix date parsing in executable model on non-English locale (#2470)

[DROOLS-4188] Error while using Declared Types in different kjars with includes (#2469)

* [DROOLS-4188] Error while using Declared Types in different kjars with include

* Fix classloader in included kbase

  1. … 1 more file in changeset.
[DROOLS-4342] Using BigDecimal with From Accumulate causes an "Error: argument type mismatch" (#2464)

* Reproducer

* Reproducer that fails on the executable model

* Reproducer

* Reproducer with our classes

* Accumulate with MVEL uses the correct function

* Removed reproducer class

* Passing test

  1. … 2 more files in changeset.
[DROOLS-4335] promote sequential option to public API (#2466)

  1. … 9 more files in changeset.
[RHDM-1020] Error while beta joining short and integer fields (#2459)

* 4207-1

* 4207-2

* Fix compilation

  1. … 5 more files in changeset.
[DROOLS-4339] Avoid implicit conversion while accumulating, type is always one returned from the function (#2450)

* Avoid implicit conversion while accumulating, type is always the one of the returned function

* Added reference test for accumulating short using a Number pattern matching

* Renamed test

  1. … 1 more file in changeset.
[7.23.x] DROOLS-4061 : Guided Score card rules not executed via test scenario. (#2445)

* DROOLS-4061 : Guided Score card rules not executed via test scenario.

(cherry picked from commit a0ba9249e99c0299f886f4a0516f8c1049c40678)

* [DROOLS-4125] restore TypeResolver and RuleUnitDescritors after Knowl… (#2374)

* [DROOLS-4125] restore TypeResolver and RuleUnitDescritors after KnowledgePackage cloning

* additional change

* [DROOLS-4125] restore TypeResolver and RuleUnitDescritors after KnowledgePackage cloning

(cherry picked from commit 1b379a3658cb9dce74e362cdd2484ee31cab11b0)

  1. … 22 more files in changeset.
[DROOLS-4175] Error in compiling BigLiteral binding as literal (#2444)

  1. … 2 more files in changeset.
[DROOLS-4276] avoid using reflection in accumulate statements generated by the executable model

  1. … 3 more files in changeset.
[DROOLS-4292] executable-model fails with more than 5 arguments query (#2443)

* Five arguments query

* QueryDefImplGenerator

* QueryDef generator

* FlowDSL

* Moved PatternDSL query

* Flow Pattern Generator

* Fix typo

* Fix typo

* Improved generation of PatternDSL

* Improved generation of Pattern and Flow DSL

* Improved generation of QueryDef

* Improved generation of QueryDef

* Better writing file

* Regenerated QueryDef

* Regenerated QueryImpl

* Regenerated querydef without public

* Regenerated QueryImpl with copyright

* PatternDSL

* FlowDSL

* Revert "FlowDSL"

This reverts commit e8cf8b28

* Ordered FlowDSL query method

* Regenerated FlowDSL with every overloads

* Regenerated Impl with correct package name

* SonarCloud issues

    • -0
    • +134
    ./org/drools/modelcompiler/builder/generator/query/Generator.java
  1. … 26 more files in changeset.
Mvel parser: Support modify statement with new line (#2429)

* Mvel parser: Support modify statement with new line

* Failing test

* While extracting modified properties in a chain of methods, don't use the last getter

  1. … 4 more files in changeset.
[DROOLS-4207] Error while beta joining short and integer fields (#2419)

* Avoid casting numeric expressions while using equality helper

* Reproducer (still not the same error)

* Always use helper method for number comparison

* Null check for uncast, to be removed

* Always use helper for equality, this time for real

* Renamed

* Also box other comparisons

* Add overloads to allow compiler to emit valid code

* Fix QueryTest without types

* Fix negative test

* Removed TODO

* Added assert to test

  1. … 3 more files in changeset.
[DROOLS-4207] Error in executable model while joining fields with short and int (#2408)

* Three tests

* Better test without declared types

* Avoid casting nameExprs

* Use Number.class in indexedBy

* Removed test

* renamed test

  1. … 3 more files in changeset.
DROOLS-4184 Fix first set of issues reported by SonarCloud (#2398)

* DROOLS-4181 Fix blocker issues reported by SonarCloud

* DROOLS-4181 Fix critical issues reported by SonarCloud

* DROOLS-4181 Fix first set of major issues reported by SonarCloud

* DROOLS-4181 Fix second set of major issues reported by SonarCloud

* DROOLS-4181 Fix third set of major issues reported by SonarCloud

* DROOLS-4181 Fix test related to SonarCloud fixes.

* DROOLS-4181 Fix downstream problems.

  1. … 137 more files in changeset.
[DROOLS-4175] Error in compiling BigLiteral binding as literal (#2388)

* Two failing tests

* Avoid try to parse a String as a BigDecimal or BigInteger literal if it's a declaration

* Better fix

  1. … 2 more files in changeset.
[DROOLS-4104] Mvel-compiler (#2381)

* First commit

Some data type

First two phases

Some design

Rules of the game

Improved visitors

Copy and pasted solution

Removed inlinecast

Removed other classes

Algorithm explained

Other possible phases

Try to parse only types

First commit

Removed imperative assignment

Create type information phase

Subtyping!

toString

Test runnning

Removed phase

Moved packages

Moved packages

Moved context

FlattenExpressionPhase

FlattenExpressionPhase

New Phase

Refactor test

* New test

* Flatten phase

* Avoid flatten

* Inverted phase 2 and 3

* Process first node using the tree

* Navigating tree?

* JavaParser utilities

* Removed javaparser-utilities

* Removed javaparser-utilities

* Removed stream

* Only one phase, visiting the tree

* Moved error message

* Refactor

* Error message

* Reintroduced original grammar to support block

* Disabled comma expression in grammar, they should be only inside a modify block

* Variable declaration

* Multiple statements

* Refactor test

* Convert property access mixed

* Test modify

* Correct mvel modify syntax

* Renamed to DroolsConstraintParserTest.java

* New test in parser for modify

* Support MVEl modify statements

* Fix consequence

* Removed attach_pid files from git

* Modify is a statement, not an expression

* First draft of modify compiling

* testSetter

* StringLiteralExpressionT.java

* Removed duplicated test

* Method to find the stter

* Split among LHS and RHS

* String literal expression

* setter test passing, every other test failing

* Fixed property test

* Create a new declaration if missing

* Modify test

* Added transitive depedency

* Removed useless code

* Removed dependency from Drools Model Compiler

* Plugged in mvel compiler

* Refactor renaming

* Type is optional now

* Missing the scope from field accessors

* Public field accessor

* Pass scope instead of stack in context

* Refactor

* added todo

* Fix scope

* Refactor

* Uncompiled expression

* Plugged mvel compiler, found problems with modify and semicolons

* Added support for semicolon in mvel modify syntax

* Ignored test

* Added test

* Fix 7.20

* Preprocess methodcallexpr in modify statements

* sanitize single line scripts

* Plugged in compiler, removed validation of mvel scripts

* testAccessor ForArguments

* Better default method

* Fix testAccessorInArguments, broke other tests

* Fix all tests

* Removed println

* Better semicolons

* Semicolon sanitizier

* Also propagate errors

* Removed useless test

* Fix type in binary expressions

* Better sanitizier for modify

* Better sanitizer 2

* Do not append ; to empty strings

* Added modify object among modified properties

* Implement update with modify blocks

* Type resolver

* Better test

* Added trace of LHS

* Create new reference when missing

* Assume only one variable per decorator, removed declaration/declarator dualism

* testInitializerArrayAccess

* TypedExpression is an interface rather than an abstract class

* Map conversion

* testMixArrayMap and testMVELConsequenceWithMapsAndArray

* Test without semicolon

* Without semicolon test

* Fix rebase

* Fix hardcoded version

* Better test without semicolon

* simple test without semicolon

* Another test with method call

* Another test with method call

* Fix comment in GeneratedDrlConstraintParserTokenManagerBase.java

* Failing test with comment

* Test with comments passing

* Unignored test with comments

* New test for single line statement

* Single line block with comment with both and without semicolon

* Support empty statements with only new line

* All test passing

* Fix ModifyPreprocessPhase.java

* Fix first modify rewrite code, removed custom modify parsing

* Support new line in argument list

* Removed debug mode

* test property reactivity

* Fix modify empty block

* Fix new lines in argument list

* Removed SemicolonSanitizer.java

* Fix property reactivity

* Avoid processing nested methodCallExpr in modify setters

* fix NPE

* Refactor Mvel rewrite

* Removed mvel validation

* Removed unused import

* Fix AccumulateTest.testAccumulateMVELWithModify

* Fixed testNoLoopAccumulate

* Support target type when RHS type is missing

* Fix all AccumulaTest

* ImportsTest

* New test for EOL in BinaryExpr

* Support EOL after binary expr token

* Fix Nesting Test added new test for BinaryExpr with newLine

* Support variable declaration without initializer

* Fix StreamTest, correct drools scope

* Support arbitrary expressions in modify block

* Cep test, 4 tests left

* Better test

* Test for crashing pretty printer

* Fix rebase

* Added new test for new line expressions

* Added two new tests

* Fix typo

* Added negative test

* Formatting

* renamed test

* With statement support

* Constructor in with statement

* Correct implementation of with preprocessor

* Refactor

* Recurse over ModifyProcessor

* Fix MapInitializationDrools3800 by recursing the modify preprocessor

* Fix MapInitializationDrools3800 by recursing the modify preprocessor

* Use mvel compiler instead of ExpressionTyper during parsing of Mvel Accumulate Nodes

* Fix NPE

* Compilation after updating JP

* Fix mvel compiler dependency

* Fix version

* minimalized reproducer

* AST reproducer

* Compare reproducer with AssertJ

* Compare AST with diff, more similar

* Even more similar

* Avoid sharing static nodes that breaks the pretty printer

* Removed debugPrettyPrinter

* Reintroduced needed class generation

* Fix testPrettyPrinterCrashing

* Reverted model writer

* Revert packagemodel

* Reverted packageModel

* Removed PrettyPrinterTest.java

* Reverted ExpressionTyperTest.java

* Removed README.MD

* Duplication of removal of EmptyStmt

* Fixed ModifyCompilerTest

* Fix version

* Failing test for nested modify

* Recurse over blocks in consequence, new test for failing

* Fix ordering of with preprocessor

* Removed duplication in nested Modify preprocessor and fixed ordering

* Removed TODO

* Removed unused properties

* Public fields on LHS

* Removed another TODO

* Better type check

* Removed last todo

* Dependency in -boostrap

* Unsupported cases in DorolsConstraintParserTest

* Also support window EOL

* Renamed drools-constraint-parser to drools-mvel-parser

* Fix OSGI

* Assertj to test

* Removed ignore to 3505 test

* Fix typo

* Fix trace message

* Formatting

* Removed trace

* Added README.md of the module that explains how it works

* Fix typo

* Removed currying renamed method

* Renamed modified properties to used bindings

* Typo

* Removed drlconstraintparser

* Used consumer in test, reformatting

* Unused statement

* Added some documentation

* Improved documentation of the module

  1. … 144 more files in changeset.
[DROOLS-4125] restore TypeResolver and RuleUnitDescritors after Knowl… (#2374)

* [DROOLS-4125] restore TypeResolver and RuleUnitDescritors after KnowledgePackage cloning

* additional change

* [DROOLS-4125] restore TypeResolver and RuleUnitDescritors after KnowledgePackage cloning

  1. … 4 more files in changeset.
Update Java Parser from 3.10.2 to 3.13.10 (#2353)

* Drools compile after upgrade of JP from 3.10.2 to 3.13.10

* DrlNameExpr is a NameExpr

* support toString in DroolsConstraintParser nodes

  1. … 14 more files in changeset.