Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DROOLS-4184 Fix first set of issues reported by SonarCloud (#2398)

* DROOLS-4181 Fix blocker issues reported by SonarCloud

* DROOLS-4181 Fix critical issues reported by SonarCloud

* DROOLS-4181 Fix first set of major issues reported by SonarCloud

* DROOLS-4181 Fix second set of major issues reported by SonarCloud

* DROOLS-4181 Fix third set of major issues reported by SonarCloud

* DROOLS-4181 Fix test related to SonarCloud fixes.

* DROOLS-4181 Fix downstream problems.

  1. … 148 more files in changeset.
DROOLS-3542 DMN FEEL function parameter typecheck (#2372)

* DROOLS-3542 DMN FEEL function parameter typecheck

* .

* .

* Implement code review feedback

* Implement code review feedback

    • -0
    • +68
    ./FormalParameterNode.java
  1. … 9 more files in changeset.
DROOLS-4088 DMN FEEL instance of minor alignments (#2367)

  1. … 4 more files in changeset.
DROOLS-3848 DMN Years and Months internals expect value is Comparable (#2315)

* DROOLS-3848 DMN Years and Months internals expect value is Comparable

* Move ComparablePeriod to standalone class

* formatting.

* Implement code review feedback and enforce type change for +- binary ops

* Handle user-provided Collection<Period> instead of <ComparablePeriod>

* .

  1. … 26 more files in changeset.
DROOLS-3858 DMN fix large memory allocation bug (#2304)

* DROOLS-3858 WIP

* Avoid retaining lexer structures.

* Proper fix for DMN layer

  1. … 5 more files in changeset.
DROOLS-3670 DMN `between` FEEL operator alignments (#2267)

* DROOLS-3670 DMN `between` FEEL operator alignments

* DROOLS-3670: Test now() between two date times

* Align test for deterministic result checks

  1. … 6 more files in changeset.
DROOLS-3627 DMN compare FEEL time with tz (#2248)

* WIP

* adding small comments as suggested.

  1. … 3 more files in changeset.
DROOLS-3538 DMN between FEEL operator for FEEL duration operands (#2223)

* DROOLS-3538 DMN between FEEL operator for FEEL duration operands

...during interpreted

* fix

  1. … 2 more files in changeset.
[DROOLS-3088] FEEL Compiler: refactor to AST-based tree walk (#2107)

* [DROOLS-3088] FEEL Compiler: refactor to AST-based tree walk

* missing push/pop in scope handler

* missing ! in FEEL grammar

* reworded rewrite ast methods

* remove commented out code

* add copyright notices

* use precise pow for big decimal

  1. … 34 more files in changeset.
Integrated a BigDecimal Math Library to support the power FEEL function with non integer exponent. Also used that new library to change the sqrt() FEEL function to use that library. (#2148)

  1. … 6 more files in changeset.
DROOLS-2823 FEEL Parser: refactor `not` unary negation and `not` function call; fix support to wildcard `?` (#2059) (#2074)

* wip

* all tests pass

* wip

* fix input var type

* fields order, notExitst builtin f

* most compile-time tests pass

* fix all compiler tests

* fix all tests

* grammar fix

* cleanup

* move method back into its original position

* fix short-circuiting on null (notExists)

* test support to listeners

* fix error logging

* remove decision table in feel expresion tests -- no longer in 1.2

* replace commented out tests with error-checking tests

* move NOT to lexing section;

* fix erroneous reference to non-existing symbol "Not_Key"

(cherry picked from commit 23b87d2e62a1f550ed7afd47dba27b34c9b9a01c)

  1. … 26 more files in changeset.
DROOLS-2823 FEEL Parser: refactor `not` unary negation and `not` function call; fix support to wildcard `?` (#2059)

* wip

* all tests pass

* wip

* fix input var type

* fields order, notExitst builtin f

* most compile-time tests pass

* fix all compiler tests

* fix all tests

* grammar fix

* cleanup

* move method back into its original position

* fix short-circuiting on null (notExists)

* test support to listeners

* fix error logging

* remove decision table in feel expresion tests -- no longer in 1.2

* replace commented out tests with error-checking tests

* move NOT to lexing section;

* fix erroneous reference to non-existing symbol "Not_Key"

  1. … 26 more files in changeset.
DROOLS-2732 FEEL invoking a function on a literal context (#1979)

  1. … 7 more files in changeset.
DROOLS-1701 Fix list test cases (#9)

  1. … 4 more files in changeset.
DROOLS-1701 Fix closure context handling, misc fn issues (#8)

  1. … 8 more files in changeset.
DROOLS-1663 Kie DMN support for IMPORT decisions between DMN files (#1943)

* WIP

* WIP2

* Reverting unnecessary code changes.

* Provisionally working, at least for the test of 2 bkms.

* Import with BKM chain working -- baseline

* Added 3 layers test, and misc refactoring

* Final refactorings

* Applying code review comment 1/2

* Apply PR code review comments 2/2

  1. … 23 more files in changeset.
DROOLS-1701 fix: ranges cannot be (always) promoted to fields (#5)

* DROOLS-1701 fix: ranges cannot be (always) promoted to fields

it won't work if boundaries are non-constants!

* DROOLS-1701 fix: use parenthesized expression in cast (ranges)

* DROOLS-1701 Comparable: do not cast in source code, check in RangeImpl -- for now

* DROOLS-1701 Use ObjectCreation for numeric constants, factory method otherwise

* DROOLS-1701 move range() factory to CompiledFEELSemanticMappings

  1. … 3 more files in changeset.
DROOLS-1701 Support for FEEL quantified expression `some`, `every`

  1. … 4 more files in changeset.
DROOLS-1701 Basic support for FEEL `for` expression

  1. … 4 more files in changeset.
DROOLS-2558 Improve error message for Msg.EXPRESSION_IS_RANGE ... (#1907)

... _BUT_VALUE_IS_NOT_COMPARABLE

Improve error message for:

Msg.EXPRESSION_IS_RANGE_BUT_VALUE_IS_NOT_COMPARABLE

Before

```

Value 'PT24H' is not comparable with range '[

org.kie.dmn.feel.lang.ast.RangeNode$ComparablePeriod@e ..

org.kie.dmn.feel.lang.ast.RangeNode$ComparablePeriod@f ]'

```

After:

```

Value 'PT24H' is not comparable with range '[ duration( "P1Y2M" ) ..

duration( "P1Y3M" ) ]'

```

Please notice throw e; was introduced with

https://github.com/kiegroup/drools/pull/1300/files#diff-08e75d1c223499cdf91a46ba16639841L86

but before this commit, there was no test coverage of the `throw e;`

branch in the codebase in fact was wrong, it should as originally report

the message but return null. Now the test cases introduced with this

commit do cover for that branch.

  1. … 1 more file in changeset.
DROOLS-2544 fix [For,Quantified,FunctionDef]...Node.getChildrenNode() (#1904)

  1. … 3 more files in changeset.
DROOLS-2274 : adding support for extended unary tests (#1890)

* DROOLS-2274 support '?' variable in decision tables

* Minor fixes on the test model

* DROOLS-2274: implementing support for extended unary tests

  1. … 13 more files in changeset.
RHDM-568 DROOLS-2286 Java Object in DMNContext not working properly with (#1886)

... Filter function.

Fix by moving ExecutionFrame from a eager to lazy logic for inspecting

properties.

Cherry pick of

https://github.com/kiegroup/drools/commit/6d3b98b79d0b2b717554e4c6df53fd02d013904e

from master to community 7.5.x branch.

  1. … 8 more files in changeset.
DROOLS-2506 Lexical scope for FEEL Function invocation (#1880)

  1. … 1 more file in changeset.
DROOLS-2441 DMN runtime not using the kiecontainer root classloader ... (#1853)

* DROOLS-2441 DMN runtime not using the kiecontainer root classloader ...

... to load classes

* Implementing correction 1/n: refactor method for default ClassLoader

* Implementing correction 2/n: rename to getRootClassLoader()

* Implementing correction 3/n: DMNFEELHelper overload constructor and ...

... Have a default classloader if one is not set.

* Implementing correction 4/4: FEELImpl overload the constructor ...

best to overload the constructor and set the default inside the

parameterless constructor instead of on the invocation [call site].

* Remove unnecessary comments.

* fixing typo

  1. … 22 more files in changeset.
DROOLS-2416 UnaryTest Not list in DT not correctly checking containment (#1835)

  1. … 3 more files in changeset.
DROOLS-1679 revert and empty-list if any error in FEEL list filtering (#1793)

Continued from commit 6c8d3f9a1b6c3ba420445c99f50a65f066a01ca7

https://github.com/kiegroup/drools/pull/1514

  1. … 3 more files in changeset.
When range endpoint is not a number, error and return null

  1. … 2 more files in changeset.
partial magic variable and config delegated to ParserHelper

  1. … 3 more files in changeset.
extension and test coverage

  1. … 1 more file in changeset.