Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DROOLS-2823 FEEL Parser: refactor `not` unary negation and `not` function call; fix support to wildcard `?` (#2059)

* wip

* all tests pass

* wip

* fix input var type

* fields order, notExitst builtin f

* most compile-time tests pass

* fix all compiler tests

* fix all tests

* grammar fix

* cleanup

* move method back into its original position

* fix short-circuiting on null (notExists)

* test support to listeners

* fix error logging

* remove decision table in feel expresion tests -- no longer in 1.2

* replace commented out tests with error-checking tests

* move NOT to lexing section;

* fix erroneous reference to non-existing symbol "Not_Key"

    • -0
    • +5
    ./feel/codegen/feel11/CodegenTestUtil.java
    • -239
    • +0
    ./feel/lang/examples/SimpleDecisionTablesTest.java
    • -1
    • +1
    ./feel/parser/feel11/FEELParserTest.java
    • -15
    • +2
    ./feel/runtime/FEELExpressionsTest.java
  1. … 20 more files in changeset.
DROOLS-2812 FEEL Translation number coercion for QualifiedName accessor (#2004)

    • -4
    • +26
    ./feel/runtime/BaseFEELCompilerTest.java
    • -9
    • +7
    ./feel/runtime/FEELStaticTypeTest.java
  1. … 2 more files in changeset.
DROOLS-2822 FEEL augment not() heuristic for function invocation (#2007)

  1. … 3 more files in changeset.
DROOLS-2811 Enrich FEEL Test parameter for translation mode (#2003)

    • -3
    • +3
    ./feel/runtime/FEELExpressionsTest.java
    • -3
    • +3
    ./feel/runtime/FEELMathOperationsTest.java
    • -3
    • +3
    ./feel/runtime/FEELTernaryLogicTest.java
DROOLS-2732 FEEL invoking a function on a literal context (#1979)

  1. … 7 more files in changeset.
DROOLS-1701 Final refactoring accordingly to PR comments and feedback

DROOLS-1701 Final refactoring accordingly to PR comments and feedback

DROOLS-1701 Final refactoring accordingly to PR comments and feedback

    • -232
    • +0
    ./feel/codegen/feel11/CompiledFEELParserTest.java
    • -14
    • +18
    ./feel/codegen/feel11/DirectCompilerTest.java
    • -2
    • +12
    ./feel/codegen/feel11/ManualContextTest.java
    • -2
    • +12
    ./feel/codegen/feel11/ManualForTest.java
    • -3
    • +10
    ./feel/codegen/feel11/ManualQuantTest.java
    • -3
    • +10
    ./feel/codegen/feel11/ManualUnaryTestsTest.java
  1. … 4 more files in changeset.
DROOLS-1701 Fix list test cases (#9)

  1. … 3 more files in changeset.
DROOLS-2648 DMN v1.2 weekday on 'date', 'date and time' (#1957)

* DROOLS-2648 DMN v1.2 weekday on 'date', 'date and time'

* .

  1. … 4 more files in changeset.
DROOLS-1701 misc fixes

DROOLS-1701 fix grounding to null for binaryexprs if any operand is null

DROOLS-1701 fix proper string literal escape and java translation

.

DROOLS-1701 fix number string into Java representation of primitive

DROOLS-1701 fix list construct a compiled semantic mapping, support null

  1. … 2 more files in changeset.
DROOLS-1701 migrate from upstream JP to org.drools:drlx-parser

    • -8
    • +8
    ./feel/codegen/feel11/CompiledFEELParserTest.java
  1. … 5 more files in changeset.
DROOLS-1701 misc fixes

DROOLS-1701 Fix Number literal original expression text rounding issue

DROOLS-1701 fix behaviour when divide-by-zero to return null

DROOLS-1701 fix IF to default returning else as a default (with no err)

DROOLS-1701 fix FunctionCall with zero argument

DROOLS-1701 fix Filter over list to report error if index out of bounds

  1. … 2 more files in changeset.
DROOLS-1701 unify CompiledExpression interface and JIT FEEL compilation

    • -209
    • +0
    ./feel/codegen/feel11/CompilerBytecodeLoader.java
    • -10
    • +15
    ./feel/runtime/BaseFEELTest.java
  1. … 5 more files in changeset.
DROOLS-2605 Extend test coverage of not() with predicates (#1934)

  1. … 3 more files in changeset.
DROOLS-1701 Support floating point constant values

  1. … 2 more files in changeset.
DROOLS-1701 Support for FEEL fn invocation using named parameters

    • -0
    • +54
    ./feel/codegen/feel11/ManualNamedFunctionInvocationTest.java
  1. … 1 more file in changeset.
DROOLS-1701 Support for FEEL fn definition (non-external, FEEL defined)

  1. … 4 more files in changeset.
DROOLS-1701 Support for FEEL fn invocation using positional parameters

    • -0
    • +53
    ./feel/codegen/feel11/ManualBasicFunctionInvocationTest.java
  1. … 2 more files in changeset.
DROOLS-1701 Support for FEEL quantified expression `some`, `every`

    • -0
    • +12
    ./feel/codegen/feel11/DirectCompilerTest.java
    • -0
    • +60
    ./feel/codegen/feel11/ManualQuantTest.java
  1. … 3 more files in changeset.
DROOLS-1701 Basic support for FEEL `for` expression

    • -0
    • +14
    ./feel/codegen/feel11/DirectCompilerTest.java
    • -0
    • +63
    ./feel/codegen/feel11/ManualForTest.java
  1. … 3 more files in changeset.
DROOLS-1701 Align with new signature of EvaluationContext

    • -0
    • +16
    ./feel/codegen/feel11/CodegenTestUtil.java
    • -6
    • +5
    ./feel/codegen/feel11/CompiledFEELParserTest.java
    • -4
    • +3
    ./feel/codegen/feel11/ManualUnaryTestsTest.java
DROOLS-2558 Improve error message for Msg.EXPRESSION_IS_RANGE ... (#1907)

... _BUT_VALUE_IS_NOT_COMPARABLE

Improve error message for:

Msg.EXPRESSION_IS_RANGE_BUT_VALUE_IS_NOT_COMPARABLE

Before

```

Value 'PT24H' is not comparable with range '[

org.kie.dmn.feel.lang.ast.RangeNode$ComparablePeriod@e ..

org.kie.dmn.feel.lang.ast.RangeNode$ComparablePeriod@f ]'

```

After:

```

Value 'PT24H' is not comparable with range '[ duration( "P1Y2M" ) ..

duration( "P1Y3M" ) ]'

```

Please notice throw e; was introduced with

https://github.com/kiegroup/drools/pull/1300/files#diff-08e75d1c223499cdf91a46ba16639841L86

but before this commit, there was no test coverage of the `throw e;`

branch in the codebase in fact was wrong, it should as originally report

the message but return null. Now the test cases introduced with this

commit do cover for that branch.

  1. … 2 more files in changeset.
DROOLS-2274 Add more extended unary test tests (#1898)

* DROOLS-2274 Add more extended unary test tests

* DROOLS-2274 Ignore reproducers until fixes are done

    • -1
    • +7
    ./feel/runtime/FEELExpressionsTest.java
  1. … 19 more files in changeset.
DROOLS-1480 Support timezones in date and type variables (#1870)

  1. … 5 more files in changeset.
DROOLS-2506 Lexical scope for FEEL Function invocation (#1880)

  1. … 1 more file in changeset.
DROOLS-1679 revert and empty-list if any error in FEEL list filtering (#1793)

Continued from commit 6c8d3f9a1b6c3ba420445c99f50a65f066a01ca7

https://github.com/kiegroup/drools/pull/1514

  1. … 3 more files in changeset.
DMN FEEL fix typing mistake in test (#1791)

It looked like a set of 2, but is just a single map defining "x" and "y"

DROOLS-1701 extend coverage for Qualified name

    • -0
    • +16
    ./feel/codegen/feel11/DirectCompilerTest.java
  1. … 1 more file in changeset.
DROOLS-1701 coverage filter/path for PATH selection

    • -1
    • +11
    ./feel/codegen/feel11/CompilerBytecodeLoader.java
  1. … 2 more files in changeset.
DROOLS-1701 coverage filter/path ONLY ref Table 54: Semantics of lists

    • -4
    • +13
    ./feel/codegen/feel11/CompilerBytecodeLoader.java
    • -0
    • +53
    ./feel/codegen/feel11/DirectCompilerTest.java
    • -0
    • +62
    ./feel/codegen/feel11/ManualFilterTest.java
  1. … 2 more files in changeset.
DROOLS-1701 coverage of "between" function

    • -0
    • +10
    ./feel/codegen/feel11/DirectCompilerTest.java
  1. … 3 more files in changeset.