Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
DROOLS-3087 DMN Validation of DecisionService referencing a missing import (#2102)

* Test case

* fix.

* .

    • -0
    • +7
    ./kie/dmn/validation/DSWithImport20181008-ModelA.dmn
    • -0
    • +23
    ./kie/dmn/validation/DSWithImport20181008-ModelB-missingDMNImport.dmn
    • -0
    • +21
    ./kie/dmn/validation/DSWithImport20181008-ModelB.dmn
  1. … 2 more files in changeset.
DROOLS-2938 DMN Validator DMN<import> extended attributre drools:modelName error (#2032)

* Test case

* Fix

  1. … 2 more files in changeset.
DROOLS-2832 DMN support for DMN v1.2 serialization (#2018)

* (kie-dmn-model)

* (kie-dmn-backend)

* BROKEN (kie-dmn-core) align imports and minor alignments

* (kie-dmn-core) realign new infra to run -core with DMN v1.1

* BROKEN (kie-dmn-core) alignments

* (kie-dmn-core) align for missing synonims of feel:Any

* API CHANGE: realign Marshaller to proper package name

* WIP -- working on DMNDI to externalize the interface and v1.2 marshaller

* Unmarshal DMN v1.2 files

* Move FEELHelper as part of DMNCompilerCtx and manage FEEL v1.2 flags

* Marshaller factory generalized, execution test w/ DMN v1.2 ch11 example

* (kie-dmn-validation)

* (kie-dmn-signavio)

* Realign Validation to support DMN v1.2

* minor/comment changes.

* Minor header/comment changes.

* Minor import .* changes

* Minor alignments and implement logic instead of hardcode QMap logic

* .

* Remove XSD(s) where not necessary.

* DROOLS-2893 DMN v1.2 Serialization degraded mode without XSD

* Fix OSGi maven plugin export/import filters.

* Implementing the correct specialised interface for b/c

* Package refactor

kie-dmn-model:

from org.kie.dmn.model.v1x

to org.kie.dmn.model.api

kie-dmn-api:

from org.kie.dmn.api.marshalling.v1x

to org.kie.dmn.api.marshalling

* Implement code review feedback.

* Implement code review feedback

* .

    • -0
    • +2084
    ./kie/dmn/validation/DMNv12_ch11.dmn
  1. … 397 more files in changeset.
DROOLS-2512 Add support for multi-file validation on the DMN Validator (#2012)

* WIP broken

* wip broken

* WIP broken

* WIP only 1 remaining failing check from DRLs

* Element reference namespaceOfImport#drgElementID DRL rules aligned.

.

.

* .

* (working OK) Base Model now defines a DS

* (working OK) Importing a DS

* (working OK) few refactorings

* (working OK) refactored API

* (working OK) Finalizations

* .

    • -0
    • +55
    ./kie/dmn/validation/import/Base-model.dmn
    • -0
    • +113
    ./kie/dmn/validation/import/Import-base-model.dmn
    • -0
    • +11
    ./kie/dmn/validation/import/Only-Import-base-model.dmn
    • -0
    • +14
    ./kie/dmn/validation/import/Wrong-Import-base-model.dmn
  1. … 13 more files in changeset.
DROOLS-2631 Validation rule of BKM typeref (#1945)

(bkm's variable element, typeref attribute)

    • -0
    • +28
    ./kie/dmn/validation/typeref/BKM_WITH_NO_TYPEREF_IS_OK.dmn
  1. … 2 more files in changeset.
DROOLS-2447 DMNValidator for schema to use an embed version of DMN XSD (#1857)

* DROOLS-2447 DMNValidator for schema to use an embed version of DMN XSD

* Implementing code review feedback

    • -0
    • +35
    ./kie/dmn/validation/Hello_World_no_prefix_with_extensions.dmn
    • -0
    • +35
    ./kie/dmn/validation/Hello_World_semantic_namespace_with_extensions.dmn
  1. … 62 more files in changeset.
DROOLS-2419 schema validation for definition xml element with prefix (#1856)

* DROOLS-2419 schema validation for definition xml element with prefix

* Demonstrating not a bug and necessary to specify xsi:schemaLocation

    • -0
    • +26
    ./kie/dmn/validation/UsingSemanticNS.dmn
  1. … 1 more file in changeset.
RHDM-513 RHBA-655 DROOLS-2443 update publication URL for DMN XSD (#1851)

  1. … 54 more files in changeset.
RHDM-512 DROOLS-2443 update publication URL for DMN XSD (#1850)

  1. … 54 more files in changeset.
DROOLS-2443 update publication URL for DMN XSD (#1849)

  1. … 54 more files in changeset.
[DROOLS-1767] FEEL: add compile-time cycle detection (#1550)

    • -0
    • +60
    ./kie/dmn/validation/decision/DECISION_DEADLY_DIAMOND.dmn
    • -0
    • +69
    ./kie/dmn/validation/decision/DECISION_DEADLY_KITE.dmn
  1. … 4 more files in changeset.
DROOLS-1527: fixing validation error message (#1212)

    • -0
    • +526
    ./kie/dmn/validation/validation.dmn
  1. … 3 more files in changeset.
DROOLS-1527: fixing validation error message (#1212)

(cherry picked from commit 76503b7c3d12e8ccdd94673f88c0435ddd4be2de)

    • -0
    • +526
    ./kie/dmn/validation/validation.dmn
  1. … 3 more files in changeset.
DROOLS-1526: adding rule and compilation check to report empty decision table input entries (#1211)

* DROOLS-1526: adding rule and compilation check to report empty decision table input entries

* Fix empty decision table input entries in DMN test models

(cherry picked from commit 1c167482b4f5fa94382a2b0035ad05d651286c52)

    • -0
    • +121
    ./kie/dmn/validation/DTABLE_EMPTY_ENTRY.dmn
  1. … 8 more files in changeset.
DROOLS-1526: adding rule and compilation check to report empty decision table input entries (#1211)

* DROOLS-1526: adding rule and compilation check to report empty decision table input entries

* Fix empty decision table input entries in DMN test models

    • -0
    • +121
    ./kie/dmn/validation/DTABLE_EMPTY_ENTRY.dmn
  1. … 8 more files in changeset.
DMN Validator tests part 1 (#1190)

* Add AuthorityRequirement validations

Add requiredDecision a requiredInput validation according to the spec.

* Add Association validation rules + reorganization of rules

- 2 new validation rules added for Association

- Changed DMNModelInstrumentedBase.getParentDRGElement() method

so Artifact instances can be get as parents

- Reorganization of validation rules

* Add KnowledgeSource validation rule + AuthorityRequirement rules polish

* Add InformationRequirement validation rules

* Move AuthorityRequirement tests to separate package

* Add KnowledgeRequirement validation rule and test

* Move Decision and DMNElementReference tests to separate package

* Add DMNElementReference validation rule - validate reference existence

* Add BusinessContext and Decision validation rules and tests

* Move InputData tests to separate package

* Move BusinessKnowledgeModel tests to separate package

* Move typeRef tests to separate package

* Move Context tests to separate package

* Cleanup after merge.

* Cleanup after merge.

* Fixes from PR reviews

* Change line separator to a separator not dependant on OS in messages

    • -23
    • +33
    ./kie/dmn/validation/RELATION_ROW_CELL_NOTLITERAL.dmn
  1. … 82 more files in changeset.
DMN Validator tests part 1 (#1190)

* Add AuthorityRequirement validations

Add requiredDecision a requiredInput validation according to the spec.

* Add Association validation rules + reorganization of rules

- 2 new validation rules added for Association

- Changed DMNModelInstrumentedBase.getParentDRGElement() method

so Artifact instances can be get as parents

- Reorganization of validation rules

* Add KnowledgeSource validation rule + AuthorityRequirement rules polish

* Add InformationRequirement validation rules

* Move AuthorityRequirement tests to separate package

* Add KnowledgeRequirement validation rule and test

* Move Decision and DMNElementReference tests to separate package

* Add DMNElementReference validation rule - validate reference existence

* Add BusinessContext and Decision validation rules and tests

* Move InputData tests to separate package

* Move BusinessKnowledgeModel tests to separate package

* Move typeRef tests to separate package

* Move Context tests to separate package

* Cleanup after merge.

* Cleanup after merge.

* Fixes from PR reviews

* Change line separator to a separator not dependant on OS in messages

(cherry picked from commit c7c3d6623ff2a5d0a56e583afdf27f37afe97f50)

    • -23
    • +33
    ./kie/dmn/validation/RELATION_ROW_CELL_NOTLITERAL.dmn
  1. … 82 more files in changeset.
Small improvements on error message handling (#1186)

    • -0
    • +33
    ./kie/dmn/validation/UNKNOWN_VARIABLE.dmn
  1. … 6 more files in changeset.
DROOLS-1504 Resolution of variable with leading or trailing spaces (#1185)

    • -0
    • +55
    ./kie/dmn/validation/VARIABLE_LEADING_TRAILING_SPACES.dmn
  1. … 7 more files in changeset.
DROOLS-1463: finishing consolidation work and adding remaining context validations (#75)

* DROOLS-1463: finishing error message consolidation

* DROOLS-1463: adding the remaining context validations

    • -0
    • +40
    ./kie/dmn/validation/CONTEXT_ENTRY_MISSING_VARIABLE.dmn
    • -0
    • +28
    ./kie/dmn/validation/CONTEXT_MISSING_ENTRIES.dmn
  1. … 6 more files in changeset.
DROOLS-1463: missing test file

    • -0
    • +3296
    ./kie/dmn/validation/MortgageRecommender.dmn
DROOLS-1463: Improving validation (#73)

* DROOLS-1463: Improving validation

* DROOLS-1463: Improving validation

* DROOLS-1463: Improving validation

* DROOLS-1463: Improving validation

  1. … 9 more files in changeset.
DROOLS-1463: consolidating validation and error reporting (#69)

* Refactoring the DMNValidator interface to allow selection of validation type to perform

* DROOLS-1463: improving error messages

    • -0
    • +38
    ./kie/dmn/validation/BKM_MISMATCH_VAR.dmn
    • -5
    • +1
    ./kie/dmn/validation/BKM_MISSING_VAR.dmn
    • -1
    • +1
    ./kie/dmn/validation/CONTEXT_DUP_ENTRY.dmn
    • -0
    • +31
    ./kie/dmn/validation/CONTEXT_MISSING_EXPR.dmn
    • -0
    • +36
    ./kie/dmn/validation/DECISION_MISMATCH_VAR.dmn
    • -2
    • +2
    ./kie/dmn/validation/ELEMREF_NOHASH.dmn
    • -0
    • +36
    ./kie/dmn/validation/INPUTDATA_MISMATCH_VAR.dmn
    • -0
    • +47
    ./kie/dmn/validation/INVOCATION_MISSING_EXPR.dmn
  1. … 24 more files in changeset.
renaming organization to kiegroup (#62)

    • -1
    • +1
    ./kie/dmn/validation/BKM_MISSING_EXPR.dmn
    • -1
    • +1
    ./kie/dmn/validation/BKM_MISSING_VAR.dmn
    • -1
    • +1
    ./kie/dmn/validation/CONTEXT_DUP_ENTRY.dmn
    • -1
    • +1
    ./kie/dmn/validation/ELEMREF_NOHASH.dmn
  1. … 41 more files in changeset.
Do not report redundant NAME_INVALID validation messages (#51)

* Do not report redundant NAME_INVALID validation messages

Do not report NAME_INVALID validation twice for Decision name and the

companion Decision's variable name.

Additionally, do not report NAME_INVALID for root note Definitions node.

* Refine condition for parent check

    • -0
    • +36
    ./kie/dmn/validation/NAME_INVALID_bis.dmn
  1. … 2 more files in changeset.
DROOLS-1447 Fix FEELParser.isVariableNameValid() for empty string (#42)

    • -0
    • +28
    ./kie/dmn/validation/DROOLS-1447.dmn
  1. … 2 more files in changeset.
DROOLS-1450 Validation rule ITEMDEF_NOT_UNIQUE not allowing (#43)

* DROOLS-1450 Validation rule ITEMDEF_NOT_UNIQUE not allowing

.. two structure with same attributes.

* Augment example data to demonstrate correctness.

    • -0
    • +38
    ./kie/dmn/validation/ITEMDEF_NOT_UNIQUE_DROOLS-1450.dmn
  1. … 2 more files in changeset.
DROOLS-1435 fix REQAUTH_NOT_KNOWLEDGESOURCE when authorityRequirement (#36)

.. is not a requiredAuthority but another valid node.

    • -0
    • +29
    ./kie/dmn/validation/REQAUTH_NOT_KNOWLEDGESOURCEbis.dmn
  1. … 2 more files in changeset.
DROOLS-1433 fix DMN Model node with no typeRef affected by wrong validation message (#33)

    • -0
    • +1402
    ./kie/dmn/validation/TYPEREF_NOT_FEEL_NOT_DEF_valid.dmn
  1. … 2 more files in changeset.
DROOLS-1429 Validate DMN model `name` attributes to be valid FEEL name definition (#30)

    • -0
    • +36
    ./kie/dmn/validation/NAME_INVALID.dmn
  1. … 3 more files in changeset.