Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
decouple ruleunit + pluggable classloader (#2652)

* decouple ruleunit

* pluggable classloader

* create osgi bundle

* register dynamic component factory in osgi Activator

* fix osgi integration

  1. … 184 more files in changeset.
RHPAM-2307[7.26.x] (#2564)

* DROOLS-4467 PMML with capitalized field names does not work (#2525)

* Updated the findDataDictionaryEntry method of PMML4UnitImpl. It now

looks through the raw DataDictionary values to find the entry, if the

entry isn't found using the field name as a key to the

dataDictionaryMap.

* Changed the AbstractModel.getMiningFields method (used by all models

except the MiningModel) to use findDataDictionaryEntry instead of trying

to use the field name as key into the dataDictionaryMap.

* Added a set of unit tests to make sure that the

findDataDictionaryEntry method works as intended. This includes also

adding a PMML file that contains fields, with names that start with both

upper and lower cases.

* RHPAM-2307 Guided Scorecard can not be tested according its name (#2520)

* Fixed methods that are used to find the package with a RuleUnit, so

that the model name can be in either upper or lower case.

* Updated the unit tests in kie-pmml so that they all use the

PMML4ExecutionHelper. This allowed refactoring of other classes, to

remove duplicated methods for determining the RuleUnit class to be used.

* Updated one of the test PMML resources (in kie-pmml) so that it has a

model name that starts with a lower case letter. This should make sure

that we are testing models with both upper and lower case letters at the

start of the model name.

    • -3
    • +10
    ./test/java/org/kie/pmml/pmml_4_2/PMMLExecutor.java
    • -0
    • +83
    ./test/java/org/kie/pmml/pmml_4_2/model/PMML4UnitImplTest.java
  1. … 4 more files in changeset.
RHPAM-2307 Guided Scorecard can not be tested according its name (#2520)

* Fixed methods that are used to find the package with a RuleUnit, so

that the model name can be in either upper or lower case.

* Updated the unit tests in kie-pmml so that they all use the

PMML4ExecutionHelper. This allowed refactoring of other classes, to

remove duplicated methods for determining the RuleUnit class to be used.

* Updated one of the test PMML resources (in kie-pmml) so that it has a

model name that starts with a lower case letter. This should make sure

that we are testing models with both upper and lower case letters at the

start of the model name.

    • -3
    • +10
    ./test/java/org/kie/pmml/pmml_4_2/PMMLExecutor.java
  1. … 4 more files in changeset.
DROOLS-4467 PMML with capitalized field names does not work (#2525)

* Updated the findDataDictionaryEntry method of PMML4UnitImpl. It now

looks through the raw DataDictionary values to find the entry, if the

entry isn't found using the field name as a key to the

dataDictionaryMap.

* Changed the AbstractModel.getMiningFields method (used by all models

except the MiningModel) to use findDataDictionaryEntry instead of trying

to use the field name as key into the dataDictionaryMap.

* Added a set of unit tests to make sure that the

findDataDictionaryEntry method works as intended. This includes also

adding a PMML file that contains fields, with names that start with both

upper and lower cases.

    • -0
    • +83
    ./test/java/org/kie/pmml/pmml_4_2/model/PMML4UnitImplTest.java
DROOLS-4332 Disable PMML parsing via kie-pmml if jPMML is in the classpath (#2498)

  1. … 1 more file in changeset.
RHDM-1049 Wrong output variable values in PMML mining model (#2505)

* RHPAM-1049 Wrong output variable values in PMML mining model

* Changed output of the target field to be a simple value that is set at

the same time as the Sum_ version is created.

* Updated test to make sure change was effective in adding the output

value

* Fixed output so that it is based on PMML4OutputField. Actual class name is based on the package name, plus the name of the output field.

[RHDM-867] force load of package-info into PMML4Compiler classloader (#2436) (#2452)

[RHDM-867] force load of package-info into PMML4Compiler classloader (#2436)

RHDM-961 Random test failures (#2352)

The error message indicated that sometimes the format function being

called by an accumulate, in the rule "processDerivedField_MapValues",

was being called with a "type" parameter that was not a String. I

updated the function's signature to take a generic Object for the "type"

parameter, and then modified the function to check to see if the

parameter was indeed a String. If it is a String then the function works

as it was originally coded; otherwise it returns the passed in "val"

parameter, just as though the "type" parameter was null.

[DROOLS-4019] ScenarioRunner for PMML (#2345)

  1. … 8 more files in changeset.
RHPAM 1815 7.18.x (#2295)

* RHPAM-1815 Unit tests fail for drools-scorecards

Declared types in the rules that are used to generate the rules from

PMML cause issues in Windows.

* Removed commented out declare statements

RHPAM-1815 Renamed the file ScoringStrategiesTest.java... (#2290)

* RHPAM-1815 Unit tests fail for drools-scorecards

Declared types in the rules that are used to generate the rules from

PMML cause issues in Windows.

* Removed commented out declare statements

RHPAM-1900 Fixes for XStream marshall/unmarshall using PMML structures (#2273) (#2283)

    • -0
    • +65
    ./main/java/org/kie/pmml/pmml_4_2/model/DataXstreamConverter.java
    • -0
    • +42
    ./main/java/org/kie/pmml/pmml_4_2/model/PMMLOutputConverter.java
  1. … 2 more files in changeset.
RHPAM-1900 Fixes for XStream marshall/unmarshall using PMML structures (#2273)

    • -0
    • +65
    ./main/java/org/kie/pmml/pmml_4_2/model/DataXstreamConverter.java
    • -0
    • +42
    ./main/java/org/kie/pmml/pmml_4_2/model/PMMLOutputConverter.java
  1. … 2 more files in changeset.
RHPAM-1875 Fixes for JSON marshalling/unmarshalling of PMML (#2258)

  1. … 1 more file in changeset.
Moved all the DRLs to the proper directory for the package name (#2252)

Moved the DRL files from the model-based subdirectory to the package

name directory org/kie/pmml/pmml_4_2/compiler

  1. … 3 more files in changeset.
RHDM-766 / DROOLS-3404 (#2202)

* DROOLS-3404 Finish removing 'declare' statements from generated rules

@Ignored tests in guided scorecards that don't work due to empty field names

RHDM-766 Implementing REST API/kie-server support for PMML

Requested updates

Made requested change to the PMML4Compiler

* Added back in tests that had been @Ignored

Added back tests that had been @Ignored. This required updating the

Helper so that it produced scorecard models that had valid output field

definitions.

    • -0
    • +31
    ./main/java/org/kie/pmml/pmml_4_2/PMML4Exception.java
  1. … 32 more files in changeset.
DROOLS-3355: Improve Assembler/Weaver API (#2181)

* cleanup

* fix compile

* rename AssemblerContext to DroolsAssemblerContext

* whitespace

* docs

* simpler ProcessPackage API

* use less specific result type in processbuilder interface

* revert process changes

* fix package serialization

* require non-null namespace on BaseDescr

as a side-effect: raises an expected exception in a jbpm test

  1. … 32 more files in changeset.
[RHDM-709][RHPAM-1453] upgrade mvel version (#2196)

  1. … 18 more files in changeset.
DROOLS-3343 Refactor Message/MessageImpl to avoid rely on impl (#2163)

* DROOLS-3343 Refactor Message/MessageImpl to avoid rely on impl

* Realign imports in other modules

* .

* .

  1. … 30 more files in changeset.
[DROOLS-3194] jdk11 support (#2145)

  1. … 18 more files in changeset.
DROOLS-3180 Split RuleUnitRegistry to two separate classes (#2119)

* DROOLS-3180 Encapsulate two different behaviours of RuleUnitRegistry

* DROOLS-3180 Fix PMML executor

  1. … 22 more files in changeset.
DROOLS-2592 PMML - Fix race conditions caused by corner cases of used "after" and "before" operators (#2070)

* DROOLS-2592 Fix scorecards reason code update race condition

* DROOLS-2592 Fix possible race conditions in PMML rule templates

RHPAM-1509 Mining model modelChain mode does not compile (#2069)

* Fixed an error, in the PMML4Compiler, that was caused when instead of creating a copy of a DataField object the object was being updated

* Fixed problems in the test data...

- Models need to have a modelName attribute

- A target element, in a MiningSchema, must have a corresponding DataField defined

DROOLS-2592 PMML - Fix race conditions caused by corner cases of used "after" and "before" operators (#2067)

* DROOLS-2592 Fix scorecards reason code update race condition

* DROOLS-2592 Fix possible race conditions in PMML rule templates

RHPAM-1509 Mining model modelChain mode does not compile (#2068)

* Fixed an error, in the PMML4Compiler, that was caused when instead of creating a copy of a DataField object the object was being updated

* Fixed problems in the test data...

- Models need to have a modelName attribute

- A target element, in a MiningSchema, must have a corresponding DataField defined

DROOLS-2972 Don't use Collections.emptyList() as a class provided to PMML template (#2060)

* Don't use Collections.emptyList() as a class provided to PMML template

* Add comment about not using Collections.emptyList() in PMML classes

  1. … 6 more files in changeset.
[BAPL-944] Test for model chain operator in mining model (#2064)

[BAPL-944] Test for model chain operator in mining model (#2057)

RHPAM-1492_ 7_11 (#2063)

* RHPAM-1492 Surrogate operator does not work correctly in decision trees

* Fixed problems in the PredicateRuleProducer classes, where the generated constraints

were not correctly taking into account compound predicates

* Changed treeCompiler.drl to use constraints created by PredicateRuleProducer classes

instead of using the compileConstraints query in common.drl

* Added a method to PMML4Helper (utils within treeCompiler.drl) to retrieve the

constraints/predicate for a node

* Added fix that uses new ArrayList<>() in place of Collections.emptyList()

    • -2
    • +34
    ./main/java/org/kie/pmml/pmml_4_2/PMML4Helper.java
  1. … 3 more files in changeset.