Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
[DROOLS-5739] Fix PMML implementation retrieval (#3176)

  1. … 1 more file in changeset.
[DROOLS-5739] Fix PMML implementation retrieval (#3175)

  1. … 1 more file in changeset.
[KOGITO-2852] descoping of mvel/asm from the core engine (#3066)

* [KOGITO-2852] descoping of mvel/asm from the core engine

* remove unused spotbugs-maven-plugin in drools-mvel

* [KOGITO-2852] fix osgi support in drools-mvel

* [KOGITO-2852] report meaningful error when drools-mvel is not present on the classpath

* [KOGITO-2852] add readme file for the new drools-mvel module

* [KOGITO-2852] upgrade drools-mvel version in pom

* wip

  1. … 2305 more files in changeset.
[DROOLS-5613] Completely disabling kie-pmml (legacy and trusty) if jpmml is present in classpath (#3076)

  1. … 1 more file in changeset.
Drools 5372 - Implement PMML coexistence (#2948)

* [Drools-5373] Refactored PMMLAssembler - implemented two delegates PMMLCompilerService and PMMLLoaderService

* [DROOLS-5372] Implement dynamic ResourceType switch inside PMMLAssemblerService(s)

* [DROOLS-5372] Using PMMLConstants for system property retrieval/setting

* [DROOLS-5372] Implementing AbstractDMNKiePMMLInvocationEvaluator and DMNKiePMMLNewInvocationEvaluator. Refactored DMNKiePMMLInvocationEvaluator. Implement switch between them inside AbstractPMMLInvocationEvaluator

* [DROOLS-5372] Fixing bug with nested node containing only a True predicate. Add test

* [DROOLS-5372] Working on DMN-PMML implementation

* [DROOLS-5423] Declaring glassfish jaxb-runtime dependency for JDK >= 11 to maintain compiler functionality in such environments

* [DROOLS-5372] Add specific message for missing PMML result. Working on tests (currently broken when run together)

* [DROOLS-5258] Working with tests. Currently broken if DMNTreePMMLTest and DMNTreePMMLNewImplTest run concurrently.

LOT of System.out.println to remove

* [DROOLS-5372] Working with tests. Currently broken if DMNTreePMMLTest and DMNTreePMMLNewImplTest run concurrently.

LOT of System.out.println to remove

* [DROOLS-5372] Implemented reset workaround

* [DROOLS-5372] Fixed DMN-PMML tests

* [DROOLS-5372] Replaced ContextClassLoader.loadClass(...) with Class.forName(...)

* [DROOLS-5372] Add kie-pmml-new to drools build

* [DROOLS-5372] Excluding dependencies from org.kie:kie-test-util due to ban-duplicated-classes enforcer rule fired on FDB

* [DROOLS-5372] Excluding dependencies due to ban-duplicated-classes enforcer rule fired on FDB

* [DROOLS-5372] Fixed as per PR suggestion

* [DROOLS-5372] Fixed as per PR suggestion

* [DROOLS-5372] Revert empty spaces/formatting modification

    • -1
    • +0
    ./org/kie/pmml/pmml_4_2/PMML4Compiler.java
  1. … 48 more files in changeset.
[DROOLS-5030] improve support for different resource types in KieFile… (#2758)

[DROOLS-5030] improve support for different resource types in KieFileSystem

    • -13
    • +2
    ./org/kie/pmml/pmml_4_2/PMML4Compiler.java
  1. … 29 more files in changeset.
make the JavaCompilerFactory a singleton (#2709)

  1. … 7 more files in changeset.
decouple ruleunit + pluggable classloader (#2652)

* decouple ruleunit

* pluggable classloader

* create osgi bundle

* register dynamic component factory in osgi Activator

* fix osgi integration

  1. … 194 more files in changeset.
RHPAM-2307[7.26.x] (#2564)

* DROOLS-4467 PMML with capitalized field names does not work (#2525)

* Updated the findDataDictionaryEntry method of PMML4UnitImpl. It now

looks through the raw DataDictionary values to find the entry, if the

entry isn't found using the field name as a key to the

dataDictionaryMap.

* Changed the AbstractModel.getMiningFields method (used by all models

except the MiningModel) to use findDataDictionaryEntry instead of trying

to use the field name as key into the dataDictionaryMap.

* Added a set of unit tests to make sure that the

findDataDictionaryEntry method works as intended. This includes also

adding a PMML file that contains fields, with names that start with both

upper and lower cases.

* RHPAM-2307 Guided Scorecard can not be tested according its name (#2520)

* Fixed methods that are used to find the package with a RuleUnit, so

that the model name can be in either upper or lower case.

* Updated the unit tests in kie-pmml so that they all use the

PMML4ExecutionHelper. This allowed refactoring of other classes, to

remove duplicated methods for determining the RuleUnit class to be used.

* Updated one of the test PMML resources (in kie-pmml) so that it has a

model name that starts with a lower case letter. This should make sure

that we are testing models with both upper and lower case letters at the

start of the model name.

  1. … 12 more files in changeset.
RHPAM-2307 Guided Scorecard can not be tested according its name (#2520)

* Fixed methods that are used to find the package with a RuleUnit, so

that the model name can be in either upper or lower case.

* Updated the unit tests in kie-pmml so that they all use the

PMML4ExecutionHelper. This allowed refactoring of other classes, to

remove duplicated methods for determining the RuleUnit class to be used.

* Updated one of the test PMML resources (in kie-pmml) so that it has a

model name that starts with a lower case letter. This should make sure

that we are testing models with both upper and lower case letters at the

start of the model name.

  1. … 10 more files in changeset.
DROOLS-4467 PMML with capitalized field names does not work (#2525)

* Updated the findDataDictionaryEntry method of PMML4UnitImpl. It now

looks through the raw DataDictionary values to find the entry, if the

entry isn't found using the field name as a key to the

dataDictionaryMap.

* Changed the AbstractModel.getMiningFields method (used by all models

except the MiningModel) to use findDataDictionaryEntry instead of trying

to use the field name as key into the dataDictionaryMap.

* Added a set of unit tests to make sure that the

findDataDictionaryEntry method works as intended. This includes also

adding a PMML file that contains fields, with names that start with both

upper and lower cases.

  1. … 2 more files in changeset.
DROOLS-4332 Disable PMML parsing via kie-pmml if jPMML is in the classpath (#2498)

  1. … 1 more file in changeset.
[RHDM-867] force load of package-info into PMML4Compiler classloader (#2436) (#2452)

    • -0
    • +5
    ./org/kie/pmml/pmml_4_2/PMML4Compiler.java
[RHDM-867] force load of package-info into PMML4Compiler classloader (#2436)

    • -0
    • +5
    ./org/kie/pmml/pmml_4_2/PMML4Compiler.java
RHPAM 1815 7.18.x (#2295)

* RHPAM-1815 Unit tests fail for drools-scorecards

Declared types in the rules that are used to generate the rules from

PMML cause issues in Windows.

* Removed commented out declare statements

    • -0
    • +65
    ./org/kie/pmml/pmml_4_2/compiler/FieldMarker.java
    • -0
    • +65
    ./org/kie/pmml/pmml_4_2/compiler/FieldScope.java
    • -0
    • +25
    ./org/kie/pmml/pmml_4_2/compiler/ModelStat.java
    • -0
    • +66
    ./org/kie/pmml/pmml_4_2/compiler/QueryMarker.java
    • -0
    • +73
    ./org/kie/pmml/pmml_4_2/compiler/TypeOfField.java
  1. … 1 more file in changeset.
RHPAM-1815 Renamed the file ScoringStrategiesTest.java... (#2290)

* RHPAM-1815 Unit tests fail for drools-scorecards

Declared types in the rules that are used to generate the rules from

PMML cause issues in Windows.

* Removed commented out declare statements

    • -0
    • +65
    ./org/kie/pmml/pmml_4_2/compiler/FieldMarker.java
    • -0
    • +65
    ./org/kie/pmml/pmml_4_2/compiler/FieldScope.java
    • -0
    • +25
    ./org/kie/pmml/pmml_4_2/compiler/ModelStat.java
    • -0
    • +66
    ./org/kie/pmml/pmml_4_2/compiler/QueryMarker.java
    • -0
    • +73
    ./org/kie/pmml/pmml_4_2/compiler/TypeOfField.java
  1. … 1 more file in changeset.
RHPAM-1900 Fixes for XStream marshall/unmarshall using PMML structures (#2273) (#2283)

    • -0
    • +65
    ./org/kie/pmml/pmml_4_2/model/DataXstreamConverter.java
    • -0
    • +42
    ./org/kie/pmml/pmml_4_2/model/PMMLOutputConverter.java
  1. … 4 more files in changeset.
RHPAM-1900 Fixes for XStream marshall/unmarshall using PMML structures (#2273)

    • -0
    • +65
    ./org/kie/pmml/pmml_4_2/model/DataXstreamConverter.java
    • -0
    • +42
    ./org/kie/pmml/pmml_4_2/model/PMMLOutputConverter.java
  1. … 4 more files in changeset.
RHPAM-1875 Fixes for JSON marshalling/unmarshalling of PMML (#2258)

  1. … 2 more files in changeset.
RHDM-766 / DROOLS-3404 (#2202)

* DROOLS-3404 Finish removing 'declare' statements from generated rules

@Ignored tests in guided scorecards that don't work due to empty field names

RHDM-766 Implementing REST API/kie-server support for PMML

Requested updates

Made requested change to the PMML4Compiler

* Added back in tests that had been @Ignored

Added back tests that had been @Ignored. This required updating the

Helper so that it produced scorecard models that had valid output field

definitions.

    • -12
    • +30
    ./org/kie/pmml/pmml_4_2/PMML4Compiler.java
    • -0
    • +31
    ./org/kie/pmml/pmml_4_2/PMML4Exception.java
    • -29
    • +0
    ./org/kie/pmml/pmml_4_2/PMML4Field.java
    • -1
    • +3
    ./org/kie/pmml/pmml_4_2/PMML4Model.java
    • -0
    • +1
    ./org/kie/pmml/pmml_4_2/PMML4Unit.java
    • -15
    • +92
    ./org/kie/pmml/pmml_4_2/model/AbstractModel.java
  1. … 32 more files in changeset.
[RHDM-709][RHPAM-1453] upgrade mvel version (#2196)

  1. … 18 more files in changeset.
DROOLS-3343 Refactor Message/MessageImpl to avoid rely on impl (#2163)

* DROOLS-3343 Refactor Message/MessageImpl to avoid rely on impl

* Realign imports in other modules

* .

* .

  1. … 30 more files in changeset.
[DROOLS-3194] jdk11 support (#2145)

  1. … 18 more files in changeset.
DROOLS-3180 Split RuleUnitRegistry to two separate classes (#2119)

* DROOLS-3180 Encapsulate two different behaviours of RuleUnitRegistry

* DROOLS-3180 Fix PMML executor

  1. … 24 more files in changeset.
RHPAM-1509 Mining model modelChain mode does not compile (#2069)

* Fixed an error, in the PMML4Compiler, that was caused when instead of creating a copy of a DataField object the object was being updated

* Fixed problems in the test data...

- Models need to have a modelName attribute

- A target element, in a MiningSchema, must have a corresponding DataField defined

    • -1
    • +15
    ./org/kie/pmml/pmml_4_2/PMML4Compiler.java
    • -0
    • +3
    ./org/kie/pmml/pmml_4_2/PMML4Helper.java
  1. … 4 more files in changeset.
RHPAM-1509 Mining model modelChain mode does not compile (#2068)

* Fixed an error, in the PMML4Compiler, that was caused when instead of creating a copy of a DataField object the object was being updated

* Fixed problems in the test data...

- Models need to have a modelName attribute

- A target element, in a MiningSchema, must have a corresponding DataField defined

    • -1
    • +15
    ./org/kie/pmml/pmml_4_2/PMML4Compiler.java
    • -0
    • +3
    ./org/kie/pmml/pmml_4_2/PMML4Helper.java
  1. … 4 more files in changeset.
DROOLS-2972 Don't use Collections.emptyList() as a class provided to PMML template (#2060)

* Don't use Collections.emptyList() as a class provided to PMML template

* Add comment about not using Collections.emptyList() in PMML classes

    • -14
    • +0
    ./org/kie/pmml/pmml_4_2/PMML4Compiler.java
    • -33
    • +22
    ./org/kie/pmml/pmml_4_2/model/PMMLDataField.java
  1. … 6 more files in changeset.
RHPAM-1492_ 7_11 (#2063)

* RHPAM-1492 Surrogate operator does not work correctly in decision trees

* Fixed problems in the PredicateRuleProducer classes, where the generated constraints

were not correctly taking into account compound predicates

* Changed treeCompiler.drl to use constraints created by PredicateRuleProducer classes

instead of using the compileConstraints query in common.drl

* Added a method to PMML4Helper (utils within treeCompiler.drl) to retrieve the

constraints/predicate for a node

* Added fix that uses new ArrayList<>() in place of Collections.emptyList()

    • -1
    • +1
    ./org/kie/pmml/pmml_4_2/PMML4Compiler.java
    • -2
    • +34
    ./org/kie/pmml/pmml_4_2/PMML4Helper.java
    • -0
    • +21
    ./org/kie/pmml/pmml_4_2/model/mining/PredicateRuleFactory.java
  1. … 6 more files in changeset.
RHPAM-1492 Surrogate operator does not work correctly in decision trees (#2062)

* Fixed problems in the PredicateRuleProducer classes, where the generated constraints

were not correctly taking into account compound predicates

* Changed treeCompiler.drl to use constraints created by PredicateRuleProducer classes

instead of using the compileConstraints query in common.drl

* Added a method to PMML4Helper (utils within treeCompiler.drl) to retrieve the

constraints/predicate for a node

Added fix that uses new ArrayList<>() in place of Collections.emptyList()

    • -1
    • +1
    ./org/kie/pmml/pmml_4_2/PMML4Compiler.java
    • -2
    • +34
    ./org/kie/pmml/pmml_4_2/PMML4Helper.java
    • -0
    • +21
    ./org/kie/pmml/pmml_4_2/model/mining/PredicateRuleFactory.java
  1. … 6 more files in changeset.
RHPAM-1500 PMML compilation problem with weightedAverage mining operator (#2052)

* Removed @Ignore from MiningModelWeightedAverageTest

* Added a method to get the Double value from the MiningSegmentWeight

* Fixed errors in the weightedAvg.mvel including

- making sure that the correct PMML4Result is used for setting a MiningSegmentWeight

- making sure that the correct PMML4Result gets the weighted average for its target field

- making sure that the all possible SegmentExecutions are inserted prior to starting any SegmentExecution

- updating the "Check Segment Can Fire" rules to update the proper SegmentExecution, instead of inserting a new one

* Fixed tests in MiningmodelTest that were broken by the above fixes

(cherry picked from commit 8eb1aae0dcbdf2b0f36e3ccbbc39e5291bf06c69)

  1. … 3 more files in changeset.