Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Drools 5372 - Implement PMML coexistence (#2948)

* [Drools-5373] Refactored PMMLAssembler - implemented two delegates PMMLCompilerService and PMMLLoaderService

* [DROOLS-5372] Implement dynamic ResourceType switch inside PMMLAssemblerService(s)

* [DROOLS-5372] Using PMMLConstants for system property retrieval/setting

* [DROOLS-5372] Implementing AbstractDMNKiePMMLInvocationEvaluator and DMNKiePMMLNewInvocationEvaluator. Refactored DMNKiePMMLInvocationEvaluator. Implement switch between them inside AbstractPMMLInvocationEvaluator

* [DROOLS-5372] Fixing bug with nested node containing only a True predicate. Add test

* [DROOLS-5372] Working on DMN-PMML implementation

* [DROOLS-5423] Declaring glassfish jaxb-runtime dependency for JDK >= 11 to maintain compiler functionality in such environments

* [DROOLS-5372] Add specific message for missing PMML result. Working on tests (currently broken when run together)

* [DROOLS-5258] Working with tests. Currently broken if DMNTreePMMLTest and DMNTreePMMLNewImplTest run concurrently.

LOT of System.out.println to remove

* [DROOLS-5372] Working with tests. Currently broken if DMNTreePMMLTest and DMNTreePMMLNewImplTest run concurrently.

LOT of System.out.println to remove

* [DROOLS-5372] Implemented reset workaround

* [DROOLS-5372] Fixed DMN-PMML tests

* [DROOLS-5372] Replaced ContextClassLoader.loadClass(...) with Class.forName(...)

* [DROOLS-5372] Add kie-pmml-new to drools build

* [DROOLS-5372] Excluding dependencies from org.kie:kie-test-util due to ban-duplicated-classes enforcer rule fired on FDB

* [DROOLS-5372] Excluding dependencies due to ban-duplicated-classes enforcer rule fired on FDB

* [DROOLS-5372] Fixed as per PR suggestion

* [DROOLS-5372] Fixed as per PR suggestion

* [DROOLS-5372] Revert empty spaces/formatting modification

  1. … 49 more files in changeset.
[DROOLS-5030] improve support for different resource types in KieFile… (#2758)

[DROOLS-5030] improve support for different resource types in KieFileSystem

  1. … 30 more files in changeset.
decouple ruleunit + pluggable classloader (#2652)

* decouple ruleunit

* pluggable classloader

* create osgi bundle

* register dynamic component factory in osgi Activator

* fix osgi integration

    • -49
    • +0
    ./model/mining/SegmentExecution.java
  1. … 195 more files in changeset.
RHPAM-2307[7.26.x] (#2564)

* DROOLS-4467 PMML with capitalized field names does not work (#2525)

* Updated the findDataDictionaryEntry method of PMML4UnitImpl. It now

looks through the raw DataDictionary values to find the entry, if the

entry isn't found using the field name as a key to the

dataDictionaryMap.

* Changed the AbstractModel.getMiningFields method (used by all models

except the MiningModel) to use findDataDictionaryEntry instead of trying

to use the field name as key into the dataDictionaryMap.

* Added a set of unit tests to make sure that the

findDataDictionaryEntry method works as intended. This includes also

adding a PMML file that contains fields, with names that start with both

upper and lower cases.

* RHPAM-2307 Guided Scorecard can not be tested according its name (#2520)

* Fixed methods that are used to find the package with a RuleUnit, so

that the model name can be in either upper or lower case.

* Updated the unit tests in kie-pmml so that they all use the

PMML4ExecutionHelper. This allowed refactoring of other classes, to

remove duplicated methods for determining the RuleUnit class to be used.

* Updated one of the test PMML resources (in kie-pmml) so that it has a

model name that starts with a lower case letter. This should make sure

that we are testing models with both upper and lower case letters at the

start of the model name.

  1. … 12 more files in changeset.
RHPAM-2307 Guided Scorecard can not be tested according its name (#2520)

* Fixed methods that are used to find the package with a RuleUnit, so

that the model name can be in either upper or lower case.

* Updated the unit tests in kie-pmml so that they all use the

PMML4ExecutionHelper. This allowed refactoring of other classes, to

remove duplicated methods for determining the RuleUnit class to be used.

* Updated one of the test PMML resources (in kie-pmml) so that it has a

model name that starts with a lower case letter. This should make sure

that we are testing models with both upper and lower case letters at the

start of the model name.

  1. … 10 more files in changeset.
DROOLS-4467 PMML with capitalized field names does not work (#2525)

* Updated the findDataDictionaryEntry method of PMML4UnitImpl. It now

looks through the raw DataDictionary values to find the entry, if the

entry isn't found using the field name as a key to the

dataDictionaryMap.

* Changed the AbstractModel.getMiningFields method (used by all models

except the MiningModel) to use findDataDictionaryEntry instead of trying

to use the field name as key into the dataDictionaryMap.

* Added a set of unit tests to make sure that the

findDataDictionaryEntry method works as intended. This includes also

adding a PMML file that contains fields, with names that start with both

upper and lower cases.

  1. … 2 more files in changeset.
[RHDM-867] force load of package-info into PMML4Compiler classloader (#2436) (#2452)

  1. … 1 more file in changeset.
[RHDM-867] force load of package-info into PMML4Compiler classloader (#2436)

  1. … 1 more file in changeset.
RHPAM 1815 7.18.x (#2295)

* RHPAM-1815 Unit tests fail for drools-scorecards

Declared types in the rules that are used to generate the rules from

PMML cause issues in Windows.

* Removed commented out declare statements

    • -0
    • +65
    ./compiler/FieldMarker.java
    • -0
    • +65
    ./compiler/FieldScope.java
    • -0
    • +25
    ./compiler/ModelStat.java
    • -0
    • +66
    ./compiler/QueryMarker.java
    • -0
    • +73
    ./compiler/TypeOfField.java
  1. … 1 more file in changeset.
RHPAM-1815 Renamed the file ScoringStrategiesTest.java... (#2290)

* RHPAM-1815 Unit tests fail for drools-scorecards

Declared types in the rules that are used to generate the rules from

PMML cause issues in Windows.

* Removed commented out declare statements

    • -0
    • +65
    ./compiler/FieldMarker.java
    • -0
    • +65
    ./compiler/FieldScope.java
    • -0
    • +25
    ./compiler/ModelStat.java
    • -0
    • +66
    ./compiler/QueryMarker.java
    • -0
    • +73
    ./compiler/TypeOfField.java
  1. … 1 more file in changeset.
RHPAM-1900 Fixes for XStream marshall/unmarshall using PMML structures (#2273) (#2283)

    • -0
    • +65
    ./model/DataXstreamConverter.java
    • -0
    • +42
    ./model/PMMLOutputConverter.java
  1. … 4 more files in changeset.
RHPAM-1900 Fixes for XStream marshall/unmarshall using PMML structures (#2273)

    • -0
    • +65
    ./model/DataXstreamConverter.java
    • -0
    • +42
    ./model/PMMLOutputConverter.java
  1. … 4 more files in changeset.
RHPAM-1875 Fixes for JSON marshalling/unmarshalling of PMML (#2258)

    • -2
    • +2
    ./model/datatypes/PMML4DataFactory.java
  1. … 2 more files in changeset.
RHDM-766 / DROOLS-3404 (#2202)

* DROOLS-3404 Finish removing 'declare' statements from generated rules

@Ignored tests in guided scorecards that don't work due to empty field names

RHDM-766 Implementing REST API/kie-server support for PMML

Requested updates

Made requested change to the PMML4Compiler

* Added back in tests that had been @Ignored

Added back tests that had been @Ignored. This required updating the

Helper so that it produced scorecard models that had valid output field

definitions.

    • -0
    • +31
    ./PMML4Exception.java
    • -115
    • +115
    ./model/mining/MiningSegment.java
  1. … 33 more files in changeset.
DROOLS-3180 Split RuleUnitRegistry to two separate classes (#2119)

* DROOLS-3180 Encapsulate two different behaviours of RuleUnitRegistry

* DROOLS-3180 Fix PMML executor

    • -14
    • +4
    ./model/mining/SegmentExecution.java
  1. … 24 more files in changeset.
RHPAM-1509 Mining model modelChain mode does not compile (#2069)

* Fixed an error, in the PMML4Compiler, that was caused when instead of creating a copy of a DataField object the object was being updated

* Fixed problems in the test data...

- Models need to have a modelName attribute

- A target element, in a MiningSchema, must have a corresponding DataField defined

    • -7
    • +1
    ./model/mining/MiningSegmentation.java
  1. … 4 more files in changeset.
RHPAM-1509 Mining model modelChain mode does not compile (#2068)

* Fixed an error, in the PMML4Compiler, that was caused when instead of creating a copy of a DataField object the object was being updated

* Fixed problems in the test data...

- Models need to have a modelName attribute

- A target element, in a MiningSchema, must have a corresponding DataField defined

    • -7
    • +1
    ./model/mining/MiningSegmentation.java
  1. … 4 more files in changeset.
DROOLS-2972 Don't use Collections.emptyList() as a class provided to PMML template (#2060)

* Don't use Collections.emptyList() as a class provided to PMML template

* Add comment about not using Collections.emptyList() in PMML classes

  1. … 6 more files in changeset.
RHPAM-1492_ 7_11 (#2063)

* RHPAM-1492 Surrogate operator does not work correctly in decision trees

* Fixed problems in the PredicateRuleProducer classes, where the generated constraints

were not correctly taking into account compound predicates

* Changed treeCompiler.drl to use constraints created by PredicateRuleProducer classes

instead of using the compileConstraints query in common.drl

* Added a method to PMML4Helper (utils within treeCompiler.drl) to retrieve the

constraints/predicate for a node

* Added fix that uses new ArrayList<>() in place of Collections.emptyList()

    • -0
    • +60
    ./model/mining/BooleanSegmentPredicate.java
    • -173
    • +212
    ./model/mining/CompoundSegmentPredicate.java
    • -0
    • +21
    ./model/mining/PredicateRuleFactory.java
    • -0
    • +2
    ./model/mining/PredicateRuleProducer.java
    • -6
    • +47
    ./model/mining/SimpleSegmentPredicate.java
    • -2
    • +14
    ./model/mining/SimpleSetSegmentPredicate.java
  1. … 6 more files in changeset.
RHPAM-1492 Surrogate operator does not work correctly in decision trees (#2062)

* Fixed problems in the PredicateRuleProducer classes, where the generated constraints

were not correctly taking into account compound predicates

* Changed treeCompiler.drl to use constraints created by PredicateRuleProducer classes

instead of using the compileConstraints query in common.drl

* Added a method to PMML4Helper (utils within treeCompiler.drl) to retrieve the

constraints/predicate for a node

Added fix that uses new ArrayList<>() in place of Collections.emptyList()

    • -0
    • +60
    ./model/mining/BooleanSegmentPredicate.java
    • -173
    • +212
    ./model/mining/CompoundSegmentPredicate.java
    • -0
    • +21
    ./model/mining/PredicateRuleFactory.java
    • -0
    • +2
    ./model/mining/PredicateRuleProducer.java
    • -6
    • +47
    ./model/mining/SimpleSegmentPredicate.java
    • -2
    • +14
    ./model/mining/SimpleSetSegmentPredicate.java
  1. … 6 more files in changeset.
RHPAM-1500 PMML compilation problem with weightedAverage mining operator (#2052)

* Removed @Ignore from MiningModelWeightedAverageTest

* Added a method to get the Double value from the MiningSegmentWeight

* Fixed errors in the weightedAvg.mvel including

- making sure that the correct PMML4Result is used for setting a MiningSegmentWeight

- making sure that the correct PMML4Result gets the weighted average for its target field

- making sure that the all possible SegmentExecutions are inserted prior to starting any SegmentExecution

- updating the "Check Segment Can Fire" rules to update the proper SegmentExecution, instead of inserting a new one

* Fixed tests in MiningmodelTest that were broken by the above fixes

    • -1
    • +5
    ./model/mining/MiningSegmentWeight.java
  1. … 3 more files in changeset.
RHPAM-1500 PMML compilation problem with weightedAverage mining operator (#2052)

* Removed @Ignore from MiningModelWeightedAverageTest

* Added a method to get the Double value from the MiningSegmentWeight

* Fixed errors in the weightedAvg.mvel including

- making sure that the correct PMML4Result is used for setting a MiningSegmentWeight

- making sure that the correct PMML4Result gets the weighted average for its target field

- making sure that the all possible SegmentExecutions are inserted prior to starting any SegmentExecution

- updating the "Check Segment Can Fire" rules to update the proper SegmentExecution, instead of inserting a new one

* Fixed tests in MiningmodelTest that were broken by the above fixes

(cherry picked from commit 8eb1aae0dcbdf2b0f36e3ccbbc39e5291bf06c69)

    • -1
    • +5
    ./model/mining/MiningSegmentWeight.java
  1. … 3 more files in changeset.
DROOLS-2908 Guided Score Card (#2035)

* Fixed/updated unit tests and verified that scorecards are compiling and executing

* Added ability to use external types when using the PMML4ExecutionHelper

  1. … 1 more file in changeset.
DROOLS-2884 Guided Score Card build fails (#2034)

* Fixed issue that prevented build/compile when the guided scorecard referenced a type without a fully qualified name

* Updated tests to include testing for external types referenced without fully qualified names

  1. … 5 more files in changeset.
DROOLS-2875 Problem compiling PMML when multiple output fields are present (#2016)

* scorecardOutputGeneration.drlt - Updated rule names to add the target field for situations where there are

multiple output fields defined.

* regParams.drlt - Changed the insertion of RegTable objects to be insert instead of insertLogical

* Updated test files to include multiple fields tagged as output

* Fixed Miningmodel.java so that the getMiningFields method would also return any fields that were used by

sub-models. This removes a limitation that previously existed where the all fields that were in a sub-model's

mining schema had to be included in the mining models mining schema.

  1. … 6 more files in changeset.
Removed all references to PMML from drools-compiler module (#1977)

Created PMMLAssemblerService to compile packages that contain PMML resources

    • -0
    • +132
    ./PMMLResource.java
  1. … 10 more files in changeset.
[DROOLS-2752] - Fix for issue that caused a StringIndexOutOfBounds exception (#1988)

when using external types, without a package name.

    • -3
    • +14
    ./model/ExternalBeanDefinition.java
  1. … 1 more file in changeset.
RHDM-594 Cleanup of PMML code (#1929)

    • -120
    • +123
    ./model/AbstractModel.java
    • -68
    • +75
    ./model/ExternalBeanDefinition.java
    • -138
    • +139
    ./model/PMML4UnitImpl.java
  1. … 17 more files in changeset.
RHDM-594 Remove drools-pmml dependency (#1922)

* Helper classes to streamline the creation of the elements necessary for submitting

a request to a PMML rule unit.

Updated tests to make use of the new helper classes

* * Removing dependencies on drools-pmml

* Changed the package for classes generated from the PMML schema and updated references to the package

* Added new methods for retrieving a KieBase, or a string that contains the PMML generated from a spreadsheet,

from the ScoreCardProvider and ScoreCardFactory classes

* * Making drools-scorecards work with kie-pmml

* Removing reliance by guided scorecards and adding in support for external beans

    • -0
    • +342
    ./PMML4ExecutionHelper.java
    • -0
    • +45
    ./PMMLRequestDataBuilder.java
    • -0
    • +75
    ./model/ExternalBeanDefinition.java
    • -0
    • +101
    ./model/ExternalBeanRef.java
  1. … 64 more files in changeset.
RHDM-522_7.7.x Add sum mode for MiningModel (#1859)

* Added new template for generating the segmentation rules, when the multipleModelMethod is "sum"

* Added new test that uses a model with the segmentation's multipleModelMethod set to "sum"

    • -0
    • +9
    ./model/mining/MiningSegmentation.java
  1. … 6 more files in changeset.