Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
decouple ruleunit + pluggable classloader (#2652)

* decouple ruleunit

* pluggable classloader

* create osgi bundle

* register dynamic component factory in osgi Activator

* fix osgi integration

  1. … 196 more files in changeset.
RHPAM-2307[7.26.x] (#2564)

* DROOLS-4467 PMML with capitalized field names does not work (#2525)

* Updated the findDataDictionaryEntry method of PMML4UnitImpl. It now

looks through the raw DataDictionary values to find the entry, if the

entry isn't found using the field name as a key to the

dataDictionaryMap.

* Changed the AbstractModel.getMiningFields method (used by all models

except the MiningModel) to use findDataDictionaryEntry instead of trying

to use the field name as key into the dataDictionaryMap.

* Added a set of unit tests to make sure that the

findDataDictionaryEntry method works as intended. This includes also

adding a PMML file that contains fields, with names that start with both

upper and lower cases.

* RHPAM-2307 Guided Scorecard can not be tested according its name (#2520)

* Fixed methods that are used to find the package with a RuleUnit, so

that the model name can be in either upper or lower case.

* Updated the unit tests in kie-pmml so that they all use the

PMML4ExecutionHelper. This allowed refactoring of other classes, to

remove duplicated methods for determining the RuleUnit class to be used.

* Updated one of the test PMML resources (in kie-pmml) so that it has a

model name that starts with a lower case letter. This should make sure

that we are testing models with both upper and lower case letters at the

start of the model name.

  1. … 13 more files in changeset.
DROOLS-4467 PMML with capitalized field names does not work (#2525)

* Updated the findDataDictionaryEntry method of PMML4UnitImpl. It now

looks through the raw DataDictionary values to find the entry, if the

entry isn't found using the field name as a key to the

dataDictionaryMap.

* Changed the AbstractModel.getMiningFields method (used by all models

except the MiningModel) to use findDataDictionaryEntry instead of trying

to use the field name as key into the dataDictionaryMap.

* Added a set of unit tests to make sure that the

findDataDictionaryEntry method works as intended. This includes also

adding a PMML file that contains fields, with names that start with both

upper and lower cases.

  1. … 2 more files in changeset.
RHPAM-1900 Fixes for XStream marshall/unmarshall using PMML structures (#2273) (#2283)

    • -0
    • +65
    ./DataXstreamConverter.java
    • -0
    • +42
    ./PMMLOutputConverter.java
  1. … 4 more files in changeset.
RHPAM-1900 Fixes for XStream marshall/unmarshall using PMML structures (#2273)

    • -0
    • +65
    ./DataXstreamConverter.java
    • -0
    • +42
    ./PMMLOutputConverter.java
  1. … 4 more files in changeset.
RHPAM-1875 Fixes for JSON marshalling/unmarshalling of PMML (#2258)

  1. … 2 more files in changeset.
RHDM-766 / DROOLS-3404 (#2202)

* DROOLS-3404 Finish removing 'declare' statements from generated rules

@Ignored tests in guided scorecards that don't work due to empty field names

RHDM-766 Implementing REST API/kie-server support for PMML

Requested updates

Made requested change to the PMML4Compiler

* Added back in tests that had been @Ignored

Added back tests that had been @Ignored. This required updating the

Helper so that it produced scorecard models that had valid output field

definitions.

    • -115
    • +115
    ./mining/MiningSegment.java
    • -0
    • +6
    ./regression/RegNormalizationFactor.java
  1. … 39 more files in changeset.
DROOLS-3180 Split RuleUnitRegistry to two separate classes (#2119)

* DROOLS-3180 Encapsulate two different behaviours of RuleUnitRegistry

* DROOLS-3180 Fix PMML executor

  1. … 25 more files in changeset.
RHPAM-1509 Mining model modelChain mode does not compile (#2069)

* Fixed an error, in the PMML4Compiler, that was caused when instead of creating a copy of a DataField object the object was being updated

* Fixed problems in the test data...

- Models need to have a modelName attribute

- A target element, in a MiningSchema, must have a corresponding DataField defined

  1. … 6 more files in changeset.
RHPAM-1509 Mining model modelChain mode does not compile (#2068)

* Fixed an error, in the PMML4Compiler, that was caused when instead of creating a copy of a DataField object the object was being updated

* Fixed problems in the test data...

- Models need to have a modelName attribute

- A target element, in a MiningSchema, must have a corresponding DataField defined

  1. … 6 more files in changeset.
DROOLS-2972 Don't use Collections.emptyList() as a class provided to PMML template (#2060)

* Don't use Collections.emptyList() as a class provided to PMML template

* Add comment about not using Collections.emptyList() in PMML classes

  1. … 7 more files in changeset.
RHPAM-1492_ 7_11 (#2063)

* RHPAM-1492 Surrogate operator does not work correctly in decision trees

* Fixed problems in the PredicateRuleProducer classes, where the generated constraints

were not correctly taking into account compound predicates

* Changed treeCompiler.drl to use constraints created by PredicateRuleProducer classes

instead of using the compileConstraints query in common.drl

* Added a method to PMML4Helper (utils within treeCompiler.drl) to retrieve the

constraints/predicate for a node

* Added fix that uses new ArrayList<>() in place of Collections.emptyList()

    • -0
    • +60
    ./mining/BooleanSegmentPredicate.java
    • -173
    • +212
    ./mining/CompoundSegmentPredicate.java
    • -0
    • +21
    ./mining/PredicateRuleFactory.java
    • -6
    • +47
    ./mining/SimpleSegmentPredicate.java
    • -2
    • +14
    ./mining/SimpleSetSegmentPredicate.java
  1. … 9 more files in changeset.
RHPAM-1492 Surrogate operator does not work correctly in decision trees (#2062)

* Fixed problems in the PredicateRuleProducer classes, where the generated constraints

were not correctly taking into account compound predicates

* Changed treeCompiler.drl to use constraints created by PredicateRuleProducer classes

instead of using the compileConstraints query in common.drl

* Added a method to PMML4Helper (utils within treeCompiler.drl) to retrieve the

constraints/predicate for a node

Added fix that uses new ArrayList<>() in place of Collections.emptyList()

    • -0
    • +60
    ./mining/BooleanSegmentPredicate.java
    • -173
    • +212
    ./mining/CompoundSegmentPredicate.java
    • -0
    • +21
    ./mining/PredicateRuleFactory.java
    • -6
    • +47
    ./mining/SimpleSegmentPredicate.java
    • -2
    • +14
    ./mining/SimpleSetSegmentPredicate.java
  1. … 9 more files in changeset.
RHPAM-1500 PMML compilation problem with weightedAverage mining operator (#2052)

* Removed @Ignore from MiningModelWeightedAverageTest

* Added a method to get the Double value from the MiningSegmentWeight

* Fixed errors in the weightedAvg.mvel including

- making sure that the correct PMML4Result is used for setting a MiningSegmentWeight

- making sure that the correct PMML4Result gets the weighted average for its target field

- making sure that the all possible SegmentExecutions are inserted prior to starting any SegmentExecution

- updating the "Check Segment Can Fire" rules to update the proper SegmentExecution, instead of inserting a new one

* Fixed tests in MiningmodelTest that were broken by the above fixes

  1. … 3 more files in changeset.
RHPAM-1500 PMML compilation problem with weightedAverage mining operator (#2052)

* Removed @Ignore from MiningModelWeightedAverageTest

* Added a method to get the Double value from the MiningSegmentWeight

* Fixed errors in the weightedAvg.mvel including

- making sure that the correct PMML4Result is used for setting a MiningSegmentWeight

- making sure that the correct PMML4Result gets the weighted average for its target field

- making sure that the all possible SegmentExecutions are inserted prior to starting any SegmentExecution

- updating the "Check Segment Can Fire" rules to update the proper SegmentExecution, instead of inserting a new one

* Fixed tests in MiningmodelTest that were broken by the above fixes

(cherry picked from commit 8eb1aae0dcbdf2b0f36e3ccbbc39e5291bf06c69)

  1. … 3 more files in changeset.
DROOLS-2884 Guided Score Card build fails (#2034)

* Fixed issue that prevented build/compile when the guided scorecard referenced a type without a fully qualified name

* Updated tests to include testing for external types referenced without fully qualified names

  1. … 5 more files in changeset.
DROOLS-2875 Problem compiling PMML when multiple output fields are present (#2016)

* scorecardOutputGeneration.drlt - Updated rule names to add the target field for situations where there are

multiple output fields defined.

* regParams.drlt - Changed the insertion of RegTable objects to be insert instead of insertLogical

* Updated test files to include multiple fields tagged as output

* Fixed Miningmodel.java so that the getMiningFields method would also return any fields that were used by

sub-models. This removes a limitation that previously existed where the all fields that were in a sub-model's

mining schema had to be included in the mining models mining schema.

  1. … 7 more files in changeset.
[DROOLS-2752] - Fix for issue that caused a StringIndexOutOfBounds exception (#1988)

when using external types, without a package name.

  1. … 1 more file in changeset.
RHDM-594 Cleanup of PMML code (#1929)

  1. … 19 more files in changeset.
RHDM-594 Remove drools-pmml dependency (#1922)

* Helper classes to streamline the creation of the elements necessary for submitting

a request to a PMML rule unit.

Updated tests to make use of the new helper classes

* * Removing dependencies on drools-pmml

* Changed the package for classes generated from the PMML schema and updated references to the package

* Added new methods for retrieving a KieBase, or a string that contains the PMML generated from a spreadsheet,

from the ScoreCardProvider and ScoreCardFactory classes

* * Making drools-scorecards work with kie-pmml

* Removing reliance by guided scorecards and adding in support for external beans

    • -0
    • +75
    ./ExternalBeanDefinition.java
    • -0
    • +101
    ./ExternalBeanRef.java
    • -3
    • +3
    ./mining/CompoundSegmentPredicate.java
  1. … 64 more files in changeset.
RHDM-522_7.7.x Add sum mode for MiningModel (#1859)

* Added new template for generating the segmentation rules, when the multipleModelMethod is "sum"

* Added new test that uses a model with the segmentation's multipleModelMethod set to "sum"

  1. … 6 more files in changeset.
RHDM-522 Add sum mode for MiningModel (#1858)

* Added new template for generating the segmentation rules, when the multipleModelMethod is "sum"

* Added new test that uses a model with the segmentation's multipleModelMethod set to "sum"

  1. … 6 more files in changeset.
RHDM-515 Add weighted average mode to MiningModel (#1855)

* Added functionality to retrieve the name of a segment's target field

* Added a new class MiningSegmentWeight that is used during the application of a model (as opposed to being used during rule generation)

* Updated the MiningSegmentation to generate rules for weighted average mode

* Added template for weighted average mode rules

* Added test to MiningmodelTest for weighted average mode

* Added a test PMML model

    • -0
    • +111
    ./mining/MiningSegmentWeight.java
  1. … 3 more files in changeset.
RHDM-515 Add weighted average mode to MiningModel (#1854)

* Added functionality to retrieve the name of a segment's target field

* Added a new class MiningSegmentWeight that is used during the application of a model (as opposed to being used during rule generation)

* Updated the MiningSegmentation to generate rules for weighted average mode

* Added template for weighted average mode rules

* Added test to MiningmodelTest for weighted average mode

* Added a test PMML model

    • -0
    • +111
    ./mining/MiningSegmentWeight.java
  1. … 3 more files in changeset.
RHBA-626 Tree model does not work on models expecting numeric output (#1847) (#1852)

* Updated the process that generates the Java classes to now include a TreeNode so that the node's outcome is of the type needed

* Updated the AbstractModel so that retrieving the mining fields does not exclude any fields

* Added a method to the Treemodel to return the source for a TreeNode java class

* Added context to the name of the generated TreeNode objects, in the templates that use TreeNode

* Created an mvel template to be used in generating the TreeNode java class

  1. … 16 more files in changeset.
RHBA-626_7.5.x Tree model does not work on models expecting numeric output (#1848)

* Updated the process that generates the Java classes to now include a TreeNode so that the node's outcome is of the type needed

* Updated the AbstractModel so that retrieving the mining fields does not exclude any fields

* Added a method to the Treemodel to return the source for a TreeNode java class

* Added context to the name of the generated TreeNode objects, in the templates that use TreeNode

* Created an mvel template to be used in generating the TreeNode java class

    • -0
    • +63
    ./tree/ScoreDistributionInfo.java
  1. … 16 more files in changeset.
RHBA-626 Tree model does not work on models expecting numeric output (#1847)

* Updated the process that generates the Java classes to now include a TreeNode so that the node's outcome is of the type needed

* Updated the AbstractModel so that retrieving the mining fields does not exclude any fields

* Added a method to the Treemodel to return the source for a TreeNode java class

* Added context to the name of the generated TreeNode objects, in the templates that use TreeNode

* Created an mvel template to be used in generating the TreeNode java class

  1. … 16 more files in changeset.
RHBA-623_7.5.x (#1840)

* interim checkin

* RHBA-623 Mining model with modelChain does not properly generate rules

* Added method to PMML4Compiler to retrieve field definitions for fields that are the result/output of an earlier sub-model

* Added methods to AbstractModel to find MiningField and OutputField entries from the model

* Updated the modelChain template so that it only attempts to create PMMLRequestData objects using the fields that are available in the controlling model

* Added a test to the MiningmodelTest for modelChain mode models

* Added the test_mining_model_modelchain.pmml file as a test model

  1. … 7 more files in changeset.
RHBA-623 (#1838)

* interim checkin

* RHBA-623 Mining model with modelChain does not properly generate rules

* Added method to PMML4Compiler to retrieve field definitions for fields that are the result/output of an earlier sub-model

* Added methods to AbstractModel to find MiningField and OutputField entries from the model

* Updated the modelChain template so that it only attempts to create PMMLRequestData objects using the fields that are available in the controlling model

* Added a test to the MiningmodelTest for modelChain mode models

* Added the test_mining_model_modelchain.pmml file as a test model

  1. … 7 more files in changeset.
DROOLS-2243_7_5_x - Backport to get kie-pmml visibility for the execu… (#1718)

* DROOLS-2243_7_5_x - Backport to get kie-pmml visibility for the execution server

* Updates to bring KIE-PMML changes into line with latest version

  1. … 72 more files in changeset.