Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
decouple ruleunit + pluggable classloader (#2652)

* decouple ruleunit

* pluggable classloader

* create osgi bundle

* register dynamic component factory in osgi Activator

* fix osgi integration

  1. … 190 more files in changeset.
RHDM-1049 Wrong output variable values in PMML mining model (#2505)

* RHPAM-1049 Wrong output variable values in PMML mining model

* Changed output of the target field to be a simple value that is set at

the same time as the Sum_ version is created.

* Updated test to make sure change was effective in adding the output

value

* Fixed output so that it is based on PMML4OutputField. Actual class name is based on the package name, plus the name of the output field.

  1. … 1 more file in changeset.
RHDM-961 Random test failures (#2352)

The error message indicated that sometimes the format function being

called by an accumulate, in the rule "processDerivedField_MapValues",

was being called with a "type" parameter that was not a String. I

updated the function's signature to take a generic Object for the "type"

parameter, and then modified the function to check to see if the

parameter was indeed a String. If it is a String then the function works

as it was originally coded; otherwise it returns the passed in "val"

parameter, just as though the "type" parameter was null.

    • -2
    • +9
    ./pmml/pmml_4_2/compiler/pmml_compiler.drl
RHPAM 1815 7.18.x (#2295)

* RHPAM-1815 Unit tests fail for drools-scorecards

Declared types in the rules that are used to generate the rules from

PMML cause issues in Windows.

* Removed commented out declare statements

    • -25
    • +0
    ./pmml/pmml_4_2/compiler/common.drl
  1. … 5 more files in changeset.
RHPAM-1815 Renamed the file ScoringStrategiesTest.java... (#2290)

* RHPAM-1815 Unit tests fail for drools-scorecards

Declared types in the rules that are used to generate the rules from

PMML cause issues in Windows.

* Removed commented out declare statements

    • -25
    • +0
    ./pmml/pmml_4_2/compiler/common.drl
  1. … 5 more files in changeset.
RHPAM-1900 Fixes for XStream marshall/unmarshall using PMML structures (#2273) (#2283)

  1. … 5 more files in changeset.
RHPAM-1900 Fixes for XStream marshall/unmarshall using PMML structures (#2273)

  1. … 5 more files in changeset.
RHPAM-1875 Fixes for JSON marshalling/unmarshalling of PMML (#2258)

  1. … 2 more files in changeset.
Moved all the DRLs to the proper directory for the package name (#2252)

Moved the DRL files from the model-based subdirectory to the package

name directory org/kie/pmml/pmml_4_2/compiler

    • -36
    • +0
    ./pmml/pmml_4_2/compiler/mining/mining_compiler.drl
    • -417
    • +0
    ./pmml/pmml_4_2/compiler/neural/neural_compiler.drl
    • -0
    • +0
    ./pmml/pmml_4_2/compiler/svm_compiler.drl
  1. … 3 more files in changeset.
RHDM-766 / DROOLS-3404 (#2202)

* DROOLS-3404 Finish removing 'declare' statements from generated rules

@Ignored tests in guided scorecards that don't work due to empty field names

RHDM-766 Implementing REST API/kie-server support for PMML

Requested updates

Made requested change to the PMML4Compiler

* Added back in tests that had been @Ignored

Added back tests that had been @Ignored. This required updating the

Helper so that it produced scorecard models that had valid output field

definitions.

    • -27
    • +1
    ./pmml/pmml_4_2/compiler/pmml_compiler.drl
    • -0
    • +130
    ./pmml/pmml_4_2/templates/mvel/global/outputbean.mvel
  1. … 32 more files in changeset.
DROOLS-2592 PMML - Fix race conditions caused by corner cases of used "after" and "before" operators (#2070)

* DROOLS-2592 Fix scorecards reason code update race condition

* DROOLS-2592 Fix possible race conditions in PMML rule templates

RHPAM-1509 Mining model modelChain mode does not compile (#2069)

* Fixed an error, in the PMML4Compiler, that was caused when instead of creating a copy of a DataField object the object was being updated

* Fixed problems in the test data...

- Models need to have a modelName attribute

- A target element, in a MiningSchema, must have a corresponding DataField defined

  1. … 6 more files in changeset.
DROOLS-2592 PMML - Fix race conditions caused by corner cases of used "after" and "before" operators (#2067)

* DROOLS-2592 Fix scorecards reason code update race condition

* DROOLS-2592 Fix possible race conditions in PMML rule templates

RHPAM-1509 Mining model modelChain mode does not compile (#2068)

* Fixed an error, in the PMML4Compiler, that was caused when instead of creating a copy of a DataField object the object was being updated

* Fixed problems in the test data...

- Models need to have a modelName attribute

- A target element, in a MiningSchema, must have a corresponding DataField defined

  1. … 6 more files in changeset.
RHPAM-1492_ 7_11 (#2063)

* RHPAM-1492 Surrogate operator does not work correctly in decision trees

* Fixed problems in the PredicateRuleProducer classes, where the generated constraints

were not correctly taking into account compound predicates

* Changed treeCompiler.drl to use constraints created by PredicateRuleProducer classes

instead of using the compileConstraints query in common.drl

* Added a method to PMML4Helper (utils within treeCompiler.drl) to retrieve the

constraints/predicate for a node

* Added fix that uses new ArrayList<>() in place of Collections.emptyList()

  1. … 17 more files in changeset.
RHPAM-1492 Surrogate operator does not work correctly in decision trees (#2062)

* Fixed problems in the PredicateRuleProducer classes, where the generated constraints

were not correctly taking into account compound predicates

* Changed treeCompiler.drl to use constraints created by PredicateRuleProducer classes

instead of using the compileConstraints query in common.drl

* Added a method to PMML4Helper (utils within treeCompiler.drl) to retrieve the

constraints/predicate for a node

Added fix that uses new ArrayList<>() in place of Collections.emptyList()

  1. … 17 more files in changeset.
RHPAM-1500 PMML compilation problem with weightedAverage mining operator (#2052)

* Removed @Ignore from MiningModelWeightedAverageTest

* Added a method to get the Double value from the MiningSegmentWeight

* Fixed errors in the weightedAvg.mvel including

- making sure that the correct PMML4Result is used for setting a MiningSegmentWeight

- making sure that the correct PMML4Result gets the weighted average for its target field

- making sure that the all possible SegmentExecutions are inserted prior to starting any SegmentExecution

- updating the "Check Segment Can Fire" rules to update the proper SegmentExecution, instead of inserting a new one

* Fixed tests in MiningmodelTest that were broken by the above fixes

  1. … 3 more files in changeset.
RHPAM-1500 PMML compilation problem with weightedAverage mining operator (#2052)

* Removed @Ignore from MiningModelWeightedAverageTest

* Added a method to get the Double value from the MiningSegmentWeight

* Fixed errors in the weightedAvg.mvel including

- making sure that the correct PMML4Result is used for setting a MiningSegmentWeight

- making sure that the correct PMML4Result gets the weighted average for its target field

- making sure that the all possible SegmentExecutions are inserted prior to starting any SegmentExecution

- updating the "Check Segment Can Fire" rules to update the proper SegmentExecution, instead of inserting a new one

* Fixed tests in MiningmodelTest that were broken by the above fixes

(cherry picked from commit 8eb1aae0dcbdf2b0f36e3ccbbc39e5291bf06c69)

  1. … 3 more files in changeset.
DROOLS-2884 Guided Score Card build fails (#2034)

* Fixed issue that prevented build/compile when the guided scorecard referenced a type without a fully qualified name

* Updated tests to include testing for external types referenced without fully qualified names

  1. … 4 more files in changeset.
DROOLS-2875 Problem compiling PMML when multiple output fields are present (#2016)

* scorecardOutputGeneration.drlt - Updated rule names to add the target field for situations where there are

multiple output fields defined.

* regParams.drlt - Changed the insertion of RegTable objects to be insert instead of insertLogical

* Updated test files to include multiple fields tagged as output

* Fixed Miningmodel.java so that the getMiningFields method would also return any fields that were used by

sub-models. This removes a limitation that previously existed where the all fields that were in a sub-model's

mining schema had to be included in the mining models mining schema.

  1. … 6 more files in changeset.
RHDM-594 Remove drools-pmml dependency (#1922)

* Helper classes to streamline the creation of the elements necessary for submitting

a request to a PMML rule unit.

Updated tests to make use of the new helper classes

* * Removing dependencies on drools-pmml

* Changed the package for classes generated from the PMML schema and updated references to the package

* Added new methods for retrieving a KieBase, or a string that contains the PMML generated from a spreadsheet,

from the ScoreCardProvider and ScoreCardFactory classes

* * Making drools-scorecards work with kie-pmml

* Removing reliance by guided scorecards and adding in support for external beans

    • -1
    • +1
    ./pmml/pmml_4_2/compiler/pmml_compiler.drl
    • -1
    • +1
    ./pmml/pmml_4_2/compiler/pmml_visitor.drl
    • -0
    • +30
    ./pmml/pmml_4_2/templates/mvel/global/externalBeanInput.mvel
  1. … 65 more files in changeset.
RHDM-522_7.7.x Add sum mode for MiningModel (#1859)

* Added new template for generating the segmentation rules, when the multipleModelMethod is "sum"

* Added new test that uses a model with the segmentation's multipleModelMethod set to "sum"

    • -0
    • +162
    ./pmml/pmml_4_2/templates/mvel/mining/summed.mvel
  1. … 5 more files in changeset.
RHDM-522 Add sum mode for MiningModel (#1858)

* Added new template for generating the segmentation rules, when the multipleModelMethod is "sum"

* Added new test that uses a model with the segmentation's multipleModelMethod set to "sum"

    • -0
    • +162
    ./pmml/pmml_4_2/templates/mvel/mining/summed.mvel
  1. … 5 more files in changeset.
RHDM-515 Add weighted average mode to MiningModel (#1855)

* Added functionality to retrieve the name of a segment's target field

* Added a new class MiningSegmentWeight that is used during the application of a model (as opposed to being used during rule generation)

* Updated the MiningSegmentation to generate rules for weighted average mode

* Added template for weighted average mode rules

* Added test to MiningmodelTest for weighted average mode

* Added a test PMML model

    • -0
    • +165
    ./pmml/pmml_4_2/templates/mvel/mining/weightedAvg.mvel
  1. … 6 more files in changeset.
RHDM-515 Add weighted average mode to MiningModel (#1854)

* Added functionality to retrieve the name of a segment's target field

* Added a new class MiningSegmentWeight that is used during the application of a model (as opposed to being used during rule generation)

* Updated the MiningSegmentation to generate rules for weighted average mode

* Added template for weighted average mode rules

* Added test to MiningmodelTest for weighted average mode

* Added a test PMML model

    • -0
    • +165
    ./pmml/pmml_4_2/templates/mvel/mining/weightedAvg.mvel
  1. … 6 more files in changeset.
RHBA-626 Tree model does not work on models expecting numeric output (#1847) (#1852)

* Updated the process that generates the Java classes to now include a TreeNode so that the node's outcome is of the type needed

* Updated the AbstractModel so that retrieving the mining fields does not exclude any fields

* Added a method to the Treemodel to return the source for a TreeNode java class

* Added context to the name of the generated TreeNode objects, in the templates that use TreeNode

* Created an mvel template to be used in generating the TreeNode java class

    • -0
    • +48
    ./pmml/pmml_4_2/templates/mvel/tree/treeNodePojo.mvel
  1. … 9 more files in changeset.
RHBA-626_7.5.x Tree model does not work on models expecting numeric output (#1848)

* Updated the process that generates the Java classes to now include a TreeNode so that the node's outcome is of the type needed

* Updated the AbstractModel so that retrieving the mining fields does not exclude any fields

* Added a method to the Treemodel to return the source for a TreeNode java class

* Added context to the name of the generated TreeNode objects, in the templates that use TreeNode

* Created an mvel template to be used in generating the TreeNode java class

    • -0
    • +48
    ./pmml/pmml_4_2/templates/mvel/tree/treeNodePojo.mvel
  1. … 10 more files in changeset.
RHBA-626 Tree model does not work on models expecting numeric output (#1847)

* Updated the process that generates the Java classes to now include a TreeNode so that the node's outcome is of the type needed

* Updated the AbstractModel so that retrieving the mining fields does not exclude any fields

* Added a method to the Treemodel to return the source for a TreeNode java class

* Added context to the name of the generated TreeNode objects, in the templates that use TreeNode

* Created an mvel template to be used in generating the TreeNode java class

    • -0
    • +48
    ./pmml/pmml_4_2/templates/mvel/tree/treeNodePojo.mvel
  1. … 9 more files in changeset.
RHBA-623_7.5.x (#1840)

* interim checkin

* RHBA-623 Mining model with modelChain does not properly generate rules

* Added method to PMML4Compiler to retrieve field definitions for fields that are the result/output of an earlier sub-model

* Added methods to AbstractModel to find MiningField and OutputField entries from the model

* Updated the modelChain template so that it only attempts to create PMMLRequestData objects using the fields that are available in the controlling model

* Added a test to the MiningmodelTest for modelChain mode models

* Added the test_mining_model_modelchain.pmml file as a test model

  1. … 9 more files in changeset.
RHBA-623 (#1838)

* interim checkin

* RHBA-623 Mining model with modelChain does not properly generate rules

* Added method to PMML4Compiler to retrieve field definitions for fields that are the result/output of an earlier sub-model

* Added methods to AbstractModel to find MiningField and OutputField entries from the model

* Updated the modelChain template so that it only attempts to create PMMLRequestData objects using the fields that are available in the controlling model

* Added a test to the MiningmodelTest for modelChain mode models

* Added the test_mining_model_modelchain.pmml file as a test model

  1. … 9 more files in changeset.