Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
decouple ruleunit + pluggable classloader (#2652)

* decouple ruleunit

* pluggable classloader

* create osgi bundle

* register dynamic component factory in osgi Activator

* fix osgi integration

  1. … 194 more files in changeset.
RHPAM-2307[7.26.x] (#2564)

* DROOLS-4467 PMML with capitalized field names does not work (#2525)

* Updated the findDataDictionaryEntry method of PMML4UnitImpl. It now

looks through the raw DataDictionary values to find the entry, if the

entry isn't found using the field name as a key to the

dataDictionaryMap.

* Changed the AbstractModel.getMiningFields method (used by all models

except the MiningModel) to use findDataDictionaryEntry instead of trying

to use the field name as key into the dataDictionaryMap.

* Added a set of unit tests to make sure that the

findDataDictionaryEntry method works as intended. This includes also

adding a PMML file that contains fields, with names that start with both

upper and lower cases.

* RHPAM-2307 Guided Scorecard can not be tested according its name (#2520)

* Fixed methods that are used to find the package with a RuleUnit, so

that the model name can be in either upper or lower case.

* Updated the unit tests in kie-pmml so that they all use the

PMML4ExecutionHelper. This allowed refactoring of other classes, to

remove duplicated methods for determining the RuleUnit class to be used.

* Updated one of the test PMML resources (in kie-pmml) so that it has a

model name that starts with a lower case letter. This should make sure

that we are testing models with both upper and lower case letters at the

start of the model name.

    • -0
    • +83
    ./pmml/pmml_4_2/model/PMML4UnitImplTest.java
  1. … 9 more files in changeset.
RHPAM-2307 Guided Scorecard can not be tested according its name (#2520)

* Fixed methods that are used to find the package with a RuleUnit, so

that the model name can be in either upper or lower case.

* Updated the unit tests in kie-pmml so that they all use the

PMML4ExecutionHelper. This allowed refactoring of other classes, to

remove duplicated methods for determining the RuleUnit class to be used.

* Updated one of the test PMML resources (in kie-pmml) so that it has a

model name that starts with a lower case letter. This should make sure

that we are testing models with both upper and lower case letters at the

start of the model name.

  1. … 6 more files in changeset.
DROOLS-4467 PMML with capitalized field names does not work (#2525)

* Updated the findDataDictionaryEntry method of PMML4UnitImpl. It now

looks through the raw DataDictionary values to find the entry, if the

entry isn't found using the field name as a key to the

dataDictionaryMap.

* Changed the AbstractModel.getMiningFields method (used by all models

except the MiningModel) to use findDataDictionaryEntry instead of trying

to use the field name as key into the dataDictionaryMap.

* Added a set of unit tests to make sure that the

findDataDictionaryEntry method works as intended. This includes also

adding a PMML file that contains fields, with names that start with both

upper and lower cases.

    • -0
    • +83
    ./pmml/pmml_4_2/model/PMML4UnitImplTest.java
  1. … 3 more files in changeset.
RHDM-1049 Wrong output variable values in PMML mining model (#2505)

* RHPAM-1049 Wrong output variable values in PMML mining model

* Changed output of the target field to be a simple value that is set at

the same time as the Sum_ version is created.

* Updated test to make sure change was effective in adding the output

value

* Fixed output so that it is based on PMML4OutputField. Actual class name is based on the package name, plus the name of the output field.

  1. … 1 more file in changeset.
[DROOLS-4019] ScenarioRunner for PMML (#2345)

  1. … 8 more files in changeset.
RHDM-766 / DROOLS-3404 (#2202)

* DROOLS-3404 Finish removing 'declare' statements from generated rules

@Ignored tests in guided scorecards that don't work due to empty field names

RHDM-766 Implementing REST API/kie-server support for PMML

Requested updates

Made requested change to the PMML4Compiler

* Added back in tests that had been @Ignored

Added back tests that had been @Ignored. This required updating the

Helper so that it produced scorecard models that had valid output field

definitions.

  1. … 41 more files in changeset.
DROOLS-3355: Improve Assembler/Weaver API (#2181)

* cleanup

* fix compile

* rename AssemblerContext to DroolsAssemblerContext

* whitespace

* docs

* simpler ProcessPackage API

* use less specific result type in processbuilder interface

* revert process changes

* fix package serialization

* require non-null namespace on BaseDescr

as a side-effect: raises an expected exception in a jbpm test

  1. … 32 more files in changeset.
DROOLS-3180 Split RuleUnitRegistry to two separate classes (#2119)

* DROOLS-3180 Encapsulate two different behaviours of RuleUnitRegistry

* DROOLS-3180 Fix PMML executor

    • -254
    • +210
    ./pmml/pmml_4_2/DroolsAbstractPMMLTest.java
  1. … 24 more files in changeset.
RHPAM-1509 Mining model modelChain mode does not compile (#2069)

* Fixed an error, in the PMML4Compiler, that was caused when instead of creating a copy of a DataField object the object was being updated

* Fixed problems in the test data...

- Models need to have a modelName attribute

- A target element, in a MiningSchema, must have a corresponding DataField defined

  1. … 6 more files in changeset.
RHPAM-1509 Mining model modelChain mode does not compile (#2068)

* Fixed an error, in the PMML4Compiler, that was caused when instead of creating a copy of a DataField object the object was being updated

* Fixed problems in the test data...

- Models need to have a modelName attribute

- A target element, in a MiningSchema, must have a corresponding DataField defined

  1. … 6 more files in changeset.
[BAPL-944] Test for model chain operator in mining model (#2064)

  1. … 1 more file in changeset.
[BAPL-944] Test for model chain operator in mining model (#2057)

  1. … 1 more file in changeset.
RHPAM-1492_ 7_11 (#2063)

* RHPAM-1492 Surrogate operator does not work correctly in decision trees

* Fixed problems in the PredicateRuleProducer classes, where the generated constraints

were not correctly taking into account compound predicates

* Changed treeCompiler.drl to use constraints created by PredicateRuleProducer classes

instead of using the compileConstraints query in common.drl

* Added a method to PMML4Helper (utils within treeCompiler.drl) to retrieve the

constraints/predicate for a node

* Added fix that uses new ArrayList<>() in place of Collections.emptyList()

  1. … 13 more files in changeset.
RHPAM-1492 Surrogate operator does not work correctly in decision trees (#2062)

* Fixed problems in the PredicateRuleProducer classes, where the generated constraints

were not correctly taking into account compound predicates

* Changed treeCompiler.drl to use constraints created by PredicateRuleProducer classes

instead of using the compileConstraints query in common.drl

* Added a method to PMML4Helper (utils within treeCompiler.drl) to retrieve the

constraints/predicate for a node

Added fix that uses new ArrayList<>() in place of Collections.emptyList()

  1. … 13 more files in changeset.
[BAPL-944] PMML test for surrogate predicate (#2056)

  1. … 1 more file in changeset.
[BAPL-944] PMML test for surrogate predicate (#2041)

  1. … 1 more file in changeset.
RHPAM-1500 PMML compilation problem with weightedAverage mining operator (#2052)

* Removed @Ignore from MiningModelWeightedAverageTest

* Added a method to get the Double value from the MiningSegmentWeight

* Fixed errors in the weightedAvg.mvel including

- making sure that the correct PMML4Result is used for setting a MiningSegmentWeight

- making sure that the correct PMML4Result gets the weighted average for its target field

- making sure that the all possible SegmentExecutions are inserted prior to starting any SegmentExecution

- updating the "Check Segment Can Fire" rules to update the proper SegmentExecution, instead of inserting a new one

* Fixed tests in MiningmodelTest that were broken by the above fixes

  1. … 2 more files in changeset.
RHPAM-1500 PMML compilation problem with weightedAverage mining operator (#2052)

* Removed @Ignore from MiningModelWeightedAverageTest

* Added a method to get the Double value from the MiningSegmentWeight

* Fixed errors in the weightedAvg.mvel including

- making sure that the correct PMML4Result is used for setting a MiningSegmentWeight

- making sure that the correct PMML4Result gets the weighted average for its target field

- making sure that the all possible SegmentExecutions are inserted prior to starting any SegmentExecution

- updating the "Check Segment Can Fire" rules to update the proper SegmentExecution, instead of inserting a new one

* Fixed tests in MiningmodelTest that were broken by the above fixes

(cherry picked from commit 8eb1aae0dcbdf2b0f36e3ccbbc39e5291bf06c69)

  1. … 2 more files in changeset.
[7.11.x] [BAPL-944] Tests for mining model - sum, weighted avg., selectAll (#2047)

* [BAPL-944] Tests for sum strategy in PMML mining model

* [BAPL-944] Tests for weighted avg operator in mining model

* [BAPL-944] Tests for select all mining model operator

  1. … 3 more files in changeset.
[BAPL-944] Tests for mining model - sum, weighted avg., selectAll (#2046)

* [BAPL-944] Tests for sum strategy in PMML mining model

* [BAPL-944] Tests for weighted avg operator in mining model

* [BAPL-944] Tests for select all mining model operator

  1. … 3 more files in changeset.
[BAPL-944] Parameterize and fix PMML regression test (#2044)

  1. … 1 more file in changeset.
[BAPL-944] Parameterize and fix PMML regression test (#2042)

  1. … 1 more file in changeset.
[BAPL-944] Tests for selectFirst strategy in PMML mining model (#2040) (#2043)

(cherry picked from commit e142035e8e068edf857f032849db25f931ac796d)

  1. … 2 more files in changeset.
[BAPL-944] Tests for selectFirst strategy in PMML mining model (#2040)

  1. … 2 more files in changeset.
DROOLS-2875 Problem compiling PMML when multiple output fields are present (#2016)

* scorecardOutputGeneration.drlt - Updated rule names to add the target field for situations where there are

multiple output fields defined.

* regParams.drlt - Changed the insertion of RegTable objects to be insert instead of insertLogical

* Updated test files to include multiple fields tagged as output

* Fixed Miningmodel.java so that the getMiningFields method would also return any fields that were used by

sub-models. This removes a limitation that previously existed where the all fields that were in a sub-model's

mining schema had to be included in the mining models mining schema.

  1. … 7 more files in changeset.
Removed all references to PMML from drools-compiler module (#1977)

Created PMMLAssemblerService to compile packages that contain PMML resources

  1. … 11 more files in changeset.
[DROOLS-2752] - Fix for issue that caused a StringIndexOutOfBounds exception (#1988)

when using external types, without a package name.

    • -5
    • +37
    ./pmml/pmml_4_2/model/ExternalBeanRefTest.java
  1. … 3 more files in changeset.
RHDM-594 Cleanup of PMML code (#1929)

    • -10
    • +9
    ./pmml/pmml_4_2/model/ExternalBeanRefTest.java
  1. … 22 more files in changeset.
RHDM-594 Remove drools-pmml dependency (#1922)

* Helper classes to streamline the creation of the elements necessary for submitting

a request to a PMML rule unit.

Updated tests to make use of the new helper classes

* * Removing dependencies on drools-pmml

* Changed the package for classes generated from the PMML schema and updated references to the package

* Added new methods for retrieving a KieBase, or a string that contains the PMML generated from a spreadsheet,

from the ScoreCardProvider and ScoreCardFactory classes

* * Making drools-scorecards work with kie-pmml

* Removing reliance by guided scorecards and adding in support for external beans

    • -3
    • +3
    ./pmml/pmml_4_2/PMMLGenerationTest.java
    • -0
    • +21
    ./pmml/pmml_4_2/model/ExternalBeanRefTest.java
    • -102
    • +103
    ./pmml/pmml_4_2/predictive/models/ScorecardTest.java
  1. … 72 more files in changeset.