Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
FUSETOOLS-3222 - use https for legal license URL

Signed-off-by: Aurélien Pupier <apupier@redhat.com>

    • -1
    • +1
    ./pages/BeanRefClassExistsValidator.java
    • -1
    • +1
    ./pages/BeanRequiredPropertyValidator.java
    • -1
    • +1
    ./pages/NewBeanIdPropertyValidator.java
  1. … 1718 more files in changeset.
FUSETOOLS-2433 - fixing issue with not being able to cancel bean edit

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

  1. … 1 more file in changeset.
FUSETOOLS-2457 - Don't allow to finish wizard when no class nor ref is provided

Signed-off-by: Aurélien Pupier <apupier@redhat.com>

Fix for SAP detection and possible disposed control NPE

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

  1. … 2 more files in changeset.
Altering the edit wizard page to disallow changing of class or bean ref

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

    • -0
    • +10
    ./pages/GlobalBeanEditWizardPage.java
Externalizing string in multivalidator and fixing issue with edit wizard

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

    • -0
    • +17
    ./pages/GlobalBeanBaseWizardPage.java
    • -14
    • +29
    ./pages/GlobalBeanEditWizardPage.java
  1. … 1 more file in changeset.
FUSETOOLS-2458 - Cross Validation

- separate cross-validation in a dedicated MultiValidator

- Observe ISWTObservableValue (and not the model) to have the

ControlDecoration available in UI

Signed-off-by: Aurélien Pupier <apupier@redhat.com>

    • -15
    • +10
    ./pages/BeanClassExistsValidator.java
    • -22
    • +15
    ./pages/BeanRefClassExistsValidator.java
  1. … 2 more files in changeset.
Further code suggestions

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

-- Went with Java8 stream as suggested by Aurelien

-- Also fixed a couple of other things he noted and externalized a

string

-- And fixed an issue with filtering out the id of the bean being edited

in edit wizard page

    • -3
    • +11
    ./pages/GlobalBeanBaseWizardPage.java
  1. … 3 more files in changeset.
Consolidating bean reference utilities and using consistently

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

    • -26
    • +2
    ./pages/GlobalBeanBaseWizardPage.java
  1. … 2 more files in changeset.
Fixing issues with Spring beans/factory beans reported by @lhein

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

    • -1
    • +16
    ./pages/GlobalBeanBaseWizardPage.java
Fixing issues with wizard pages

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

    • -8
    • +10
    ./pages/GlobalBeanBaseWizardPage.java
    • -2
    • +26
    ./pages/GlobalBeanEditWizardPage.java
  1. … 1 more file in changeset.
Correcting the name of an externalized msg for a minor sonar issue

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

    • -2
    • +2
    ./pages/BeanRefClassExistsValidator.java
  1. … 2 more files in changeset.
Internationalizing a couple of strings and fixing another spaces issue

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

    • -8
    • +8
    ./pages/BeanRefClassExistsValidator.java
  1. … 2 more files in changeset.
Sonar and @apupier-related fixes

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

    • -23
    • +17
    ./pages/GlobalBeanBaseWizardPage.java
  1. … 4 more files in changeset.
Adding support for bean ref/class and method validation

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

    • -12
    • +39
    ./pages/BeanClassExistsValidator.java
    • -7
    • +20
    ./pages/BeanRefClassExistsValidator.java
  1. … 7 more files in changeset.
Updates for wizard handling both class and bean reference

Signed-off-by: Brian Fitzpatrick <bfitzpat@redhat.com>

    • -3
    • +44
    ./pages/BeanClassExistsValidator.java
    • -0
    • +95
    ./pages/BeanRefClassExistsValidator.java
    • -4
    • +92
    ./pages/GlobalBeanBaseWizardPage.java
  1. … 2 more files in changeset.
FUSETOOLS-2417 - pass current class name from field when open class wiz

  1. … 2 more files in changeset.
changes required due to rebase with master

  1. … 7 more files in changeset.
FUSETOOLS-2419 - Fixing remaining Sonar issues related to Bean commits (#996)

* FUSETOOLS-2419 - Fixing remaining Sonar issues related to Bean commits

* FUSETOOLS-2419 - addressing feedback

* FUSETOOLS-2419 - refactoring arg and prop tables

also fixing error introduced with wizard labels

* FUSETOOLS-2419 - refactoring bean wizard pages

* FUSETOOLS-2419 - moving a bit of shared validation code

* FUSETOOLS-2419 - fixing formatting issue

    • -1
    • +1
    ./pages/BeanRequiredPropertyValidator.java
    • -0
    • +174
    ./pages/GlobalBeanBaseWizardPage.java
    • -123
    • +27
    ./pages/GlobalBeanEditWizardPage.java
    • -142
    • +25
    ./pages/GlobalBeanWizardPage.java
    • -7
    • +2
    ./pages/NewBeanIdPropertyValidator.java
  1. … 25 more files in changeset.
fixed broken itest and extracted inner class from CamelBean

  1. … 15 more files in changeset.
rebase with bean global config PR from Brian

  1. … 3 more files in changeset.
FUSETOOLS-1585 - beginnings of adding bean support (#880)

* FUSETOOLS-1585 - beginnings of adding bean support

-- adding to Global Configuration page as an "Add" possibility

-- started work on the Bean wizard

-- started on property page for bean properties

-- have basic bean property page working

-- added ID validation for global configuration elements

-- added browse button for bean class in wizard page

-- added class name validation in wizard page

-- added class name validation on property page

-- added class browse button on property page

-- added method browse button on property page

-- added method validation on property page

-- added first cut of property and argument table controls to wizard

-- added support for defining arguments and properties in config

-- some Sonar cleanup

-- added edit buttons to property & argument tables

-- more sonar cleanup

-- addressing comments from Aurelien and more cleanup

-- additional sonar cleanup of lambdas and an icon issue

-- more sonar cleanup and addition of property name uniqueness

validation plus bean id uniqueness validation in property page

-- even more sonar suggested fixes

-- addressing a NPE and some other suggestions made by Aurelien

-- more sonar fixes

-- added edit functionality for properties and arguments

-- added a few sonar & Aurelien-requested changes

-- fixed issue with xml not being added/updated correctly

-- fixed some property name validation issues

-- fixed issue with adding wrong constructor argument tag name to

blueprint

-- further correction to method used to find namespace for blueprint

-- adding beginnings of IT test

-- updated test so it works and refactored some code for easier testing

-- beefed up test to cover basic use cases and blueprint vs. spring

testing

-- added additional tests for creation and editing of beans

-- did a little test refactoring

-- added factory-method/factory-bean functionality to property page and

tests for it

-- added ability to create new class from bean wizards and property page

* FUSETOOLS-1585 - set new java class wizard to not auto-open

Discovered that the new java class wizard opens the new class for

editing immediately after clicking Finish. For this case, we don't want

it to open, since focus would then shift from the Camel Editor.

* FUSETOOLS-1585 - addressing some of Aurelien's feedback,

adding a new test, and correcting a couple of labels

* FUSETOOLS-1585 - moving some XML attribute setting/getting code back to

the CamelBean model object. Adding a test to ensure that it can be

loaded properly and changed via the CamelBean object.

* FUSETOOLS-1585 - adding more tests and functionality to CamelBean

* FUSETOOLS-1585 - small code improvements

* Fixed issue with refresh

* Fixing issue where src/main/java not created yet

* FUSETOOLS-1585 - Factorize code and leverage java 8 streams

* Attempting to fix test issues with Shells

* Updates to PropertyInputDialogTest as suggested by @apupier

* Update to fix one issue

* fix the swt / cocoa lib failures from CI

* fixes model problem

* Specialize bean extension to not clash with SAP

* Addressing an issue found by the Core model test

-- also includes feedback from Aurelien on a couple of code tweaks

* Addressing more comments - test for SAP extension, code cleanup

* Externalizing strings for the Bean work

* Fixes for next round of comments

* Updates to allow specialization of Globel elements and a sonar fix

* FUSETOOLS-1585 - addressed more feedback

- factorized code requested in AdvancedBeanPropertiesSection and

AdvancedEndpointPropertiesSection

- updated developer name in javadocs to be consistent

- fixed validation issues with Property and Argument dialogs so

validation prevents OK button from being active

- removed code around potential WRONG_DOCUMENT_ERR since the last round

of model updates seems to have removed the necessity

* FUSETOOLS-1585 - Avoid having two times the same WizardPage

Before the pages on the wizard are added twice in

org.fusesource.ide.camel.editor.globalconfiguration.beans.BeanConfigUtil.handleNewClassWizard(IProject,

Shell) , there is a addPages() called which is also called when

wizard.open() is called which was causing that nothing happened when

clicking "Next"

Now, it is called a single time. No next button is displayed.

    • -0
    • +127
    ./AddGlobalBeanWizard.java
    • -0
    • +116
    ./EditGlobalBeanWizard.java
    • -0
    • +53
    ./pages/BeanClassExistsValidator.java
    • -0
    • +38
    ./pages/BeanRequiredPropertyValidator.java
    • -0
    • +202
    ./pages/GlobalBeanEditWizardPage.java
    • -0
    • +204
    ./pages/GlobalBeanWizardPage.java
    • -0
    • +46
    ./pages/NewBeanIdPropertyValidator.java
    • -0
    • +44
    ./pages/NewBeanIdValidator.java
  1. … 43 more files in changeset.