• last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
JBPORTAL-2368: Setting the ResourceResponse.HTTP_STATUS_CODE property does not modify the actual server response status code
- Moved read methods to CoordinationManager as it's more logical for them to be there.

- CoordinationConfigurator now extends CoordinationManager.

    • -97
    • +23
    ./coordination/CoordinationConfigurator.java
    • -21
    • +100
    ./coordination/CoordinationManager.java
  1. … 1 more file in changeset.
- Updated from 2.7.2

- Slightly modified styles (green instead of red for DnD zones, re-added bigger tab menu with less padding)

- Minor improvements.

  1. … 9 more files in changeset.
- JBPORTAL-2326: needs to be tested

+ If no parameters is passed to a page to be displayed, erased previous page navigational state

+ If we have a PNS, pass the current state as parameters to ViewPageCommand before full refresh in AJAX context (hackish)

+ Improved getPortletPublicNavigationalState method to avoid unnecessary work

    • -55
    • +59
    ./portlet/ControllerPageNavigationalState.java
  1. … 2 more files in changeset.
JBPORTAL-2335: Explicit public parameters don't work

    • -0
    • +2
    ./portlet/ControllerResponseFactory.java
- JBPORTAL-2328: if we have a page NS, force a full refresh for now... :(

- Minor optimization: do not loop over children but rather over dirty windows (which should be less) thus

avoiding to use getChildren which is costly...

- JBPORTAL-2326:

+ Not sure why previous PNS was saved in ViewPageCommand: limited testing hasn't shown any adverse side effects so far

+ Do not iterate over all bindings when looking for PNS for a window (was previously overwriting found PNS)

    • -81
    • +78
    ./portlet/ControllerPageNavigationalState.java
  1. … 1 more file in changeset.
- Replace Element.getElementsByClassName by select as it's deprecated in Prototype 1.6+. Should fix partial refresh.

- UpdateWindowResponse doesn't seem used anymore so make PortalObjectResponseHandler fail if we encounter one to try to see if it's really not used anymore.

- Removed duplicated code in InternalContentProvider (supportedModes and supportedWindowStates were reset when getting the ones for the current media type).

- Clean-ups.

  1. … 3 more files in changeset.
- JBPORTAL-2273: real fix: when we get an OpaqueStateString just transmit it as is since chances are it cannot be interpreted

(unless it was encoded by a Portal producer) and we cannot use the information locally to mix in the public navigational

state anyway.

    • -21
    • +19
    ./portlet/ControllerResponseFactory.java
- JBPORTAL-2273: Deal with opaque navigational state.

- Use portlet trunk-SNAPSHOT.

    • -2
    • +12
    ./portlet/ControllerResponseFactory.java
  1. … 1 more file in changeset.
- JBPORTAL-2270: check that we have properties before trying to manipulate them...
    • -26
    • +33
    ./portlet/ControllerResponseFactory.java
JBPORTAL-2242: pass Content-Disposition property to client
    • -2
    • +2
    ./portlet/ControllerResponseFactory.java
  1. … 1 more file in changeset.
JBPORTAL-2248: Action URL retained by client
    • -3
    • +0
    ./portlet/ControllerResponseFactory.java
JBPORTAL-2248: Action URL retained by client

    • -3
    • +27
    ./portlet/ControllerResponseFactory.java
  1. … 2 more files in changeset.
JBPORTAL-2248: Action URL retained by client

    • -2
    • +10
    ./portlet/ControllerResponseFactory.java
- JBPORTAL-2147: more API fixes
    • -2
    • +2
    ./coordination/CoordinationConfigurator.java
    • -12
    • +11
    ./coordination/CoordinationManager.java
  1. … 3 more files in changeset.
- JBPORTAL-2147: renamed AliasBindingInfo.getNames to getParameterNames.

- Fixed incorrect implementation of CoordinationService.getParameterBindings(page, qname) and added test cases.

  1. … 3 more files in changeset.
JBPORTAL-2178: NPE when requesting dashboard as unauthenticated user

Don't NPE but returns a 500 error

  1. … 1 more file in changeset.
- JBPORTAL-2147: first step.

+ Removed ParameterBindingInfo parent

+ Renamed WindowBindingInfo to ParameterBindingInfo

+ Renamed methods and variables accordingly

+ Improved getEventWindows implementation a little (needs test case, btw)

    • -11
    • +11
    ./coordination/CoordinationConfigurator.java
    • -37
    • +44
    ./coordination/ParameterBindingInfo.java
    • -39
    • +0
    ./coordination/WindowBindingInfo.java
  1. … 5 more files in changeset.
JBPORTAL-2187: Partial refresh broke while integrating portlet container 2.0
  1. … 1 more file in changeset.
JBPORTAL-2187: Partial refresh broke while integrating portlet container 2.0
- Implemented possibility to select several parameters for a given window. Not convinced this

is the proper way to do things but committing so it's not lost. Might be reverted.

    • -2
    • +2
    ./coordination/CoordinationConfigurator.java
    • -0
    • +54
    ./coordination/Utils.java
  1. … 11 more files in changeset.
- Added getAliasBinding(page, name), removeAliasBinding(page, name) and renameAliasBinding(page, alias name, new name) methods.

- Added test cases.

- I have "optimized" some cases by using declared properties instead of properties (in this commit and previous) and it just

occurred to me that this might break behavior. But as this potential behavior was not tested, I have no way to know... Bolek?

    • -0
    • +22
    ./coordination/CoordinationConfigurator.java
  1. … 2 more files in changeset.
- Oops, getWindowBindingInfo should really be getWindowBinding...
    • -1
    • +1
    ./coordination/CoordinationConfigurator.java
  1. … 2 more files in changeset.
- Added removeWindowBinding(page, name), renameWindowBinding(page, old name, new name) and getWindowBindingInfo(page, name) methods

- Fixed an issue with PREFIX_PARAMETER_ALIAS_LENGTH which wasn't correct.

- get*(page, name) should return null when the coordination element is not found instead of failing.

- Improved tests and coverage.

    • -12
    • +34
    ./coordination/CoordinationConfigurator.java
  1. … 2 more files in changeset.
- Re-organization and minor improvements.

- Javadoc of newly added methods.

    • -6
    • +29
    ./coordination/CoordinationConfigurator.java
  1. … 1 more file in changeset.
- Added getPage method on EventWiringInfo and ParameterBindingInfo

- Added getEventWiring, removeEventWiring(page, name) and renameEventWiring(page, oldName, newName) methods for easier use.

- EventWiringManagerBean uses new method and rename and delete operations should now properly work from the GUI.

- Added more tests.

    • -0
    • +6
    ./coordination/CoordinationConfigurator.java
    • -0
    • +4
    ./coordination/ParameterBindingInfo.java
  1. … 3 more files in changeset.
- Added rename operations on CoordinationConfigurator and associated test cases.

- Implemented rename behavior.

- Next step is looking at backend since operations don't seem to be persisted properly

and creation of wiring doesn't work.

    • -9
    • +31
    ./coordination/CoordinationConfigurator.java
  1. … 9 more files in changeset.
- Renamed ParameterBindingInfo.getId to getName for better consistency.

- Started adding support for deleting and renaming bindings.

    • -1
    • +1
    ./coordination/ParameterBindingInfo.java
  1. … 5 more files in changeset.
minor
    • -3
    • +2
    ./portlet/CoreEventControllerContext.java
  1. … 3 more files in changeset.