• last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
It fixes a bug when the user take the dashboard for the first time. If there is some denied access, the dashboard is half imported and it generates a NullPointerException. See JBPORTAL-2456
    • -1
    • +1
    ./model/CustomizationManagerService.java
JBPORTAL-2389: moved session.flush() as the previous fix did not cover all cases
    • -1
    • +2
    ./portlet/state/PersistentPortletStatePersistenceManager.java
Add session.flush() to fix JBPORTAL-2389
    • -0
    • +1
    ./portlet/state/PersistentPortletStatePersistenceManager.java
- JBPORTAL-2384:

+ Really avoid creating dashboard until needed.

+ Fixed incorrect behavior for copy to dashboard link where the link wouldn't appear if the dashboard didn't already exist.

+ Problem with new behavior: copy to dashboard is now also present on default/default which wasn't the case before... This

doesn't have any side effect has copy will not copy if the page already exists in dashboard.

    • -9
    • +24
    ./model/CustomizationManagerService.java
  1. … 2 more files in changeset.
JBPORTAL-2384: Avoid creating dashboard objects if dashboard isn't used

    • -0
    • +13
    ./model/CustomizationManagerService.java
  1. … 2 more files in changeset.
- Moved read methods to CoordinationManager as it's more logical for them to be there.

- CoordinationConfigurator now extends CoordinationManager.

    • -26
    • +26
    ./coordination/CoordinationService.java
  1. … 2 more files in changeset.
  1. … 1 more file in changeset.
- JBPORTAL-2040:

+ Re-wrote PortalObject.getChild to use container directly instead of going through ObjectNode.getChildren

to avoid having to retrieve all the children just to get one. This should yield a massive reduction in DB

requests.

+ Removed unused instances and pages SelectedItems in PortalObjectManagerBean

- Added PortalObjectId.getChildId to efficiently get a child's id from a parent and use ParameterValidation.

    • -10
    • +11
    ./model/portal/PortalObjectImpl.java
  1. … 2 more files in changeset.
- Replace Element.getElementsByClassName by select as it's deprecated in Prototype 1.6+. Should fix partial refresh.

- UpdateWindowResponse doesn't seem used anymore so make PortalObjectResponseHandler fail if we encounter one to try to see if it's really not used anymore.

- Removed duplicated code in InternalContentProvider (supportedModes and supportedWindowStates were reset when getting the ones for the current media type).

- Clean-ups.

  1. … 4 more files in changeset.
- JBPORTAL-2281: Fix incompatible behavior between Java 5 and Java 6
    • -13
    • +17
    ./model/portal/PortalObjectImpl.java
  1. … 2 more files in changeset.
- JBPORTAL-2281: we do always need ChildrenCollection after all...

- Added iterator tests.

    • -20
    • +19
    ./model/portal/PortalObjectImpl.java
  1. … 1 more file in changeset.
- JBPORTAL-2281: More fundamental performance improvements (yields about 40% improvement in my testing)...

- Added test cases.

- Fixed issues with testsuite build.

    • -52
    • +36
    ./model/portal/PortalObjectImpl.java
  1. … 3 more files in changeset.
- JBPORTAL-2257: possible fix... Needs associated test case.
- Fixed typos.
    • -1
    • +1
    ./model/portal/PersistentPortalObjectContainer.java
  1. … 1 more file in changeset.
JBPORTAL-2252: PortletPreferences composed of multiple strings always only return one

Thank you Manuel !

    • -1
    • +1
    ./portlet/state/PersistentPortletStateEntry.java
JBPORTAL-2251: MailModule update to support non-plaintext email

  1. … 1 more file in changeset.
JBPORTAL-2246: Portlet invoker exception during portlet window rendering

  1. … 2 more files in changeset.
- JBPORTAL-2208: Commented out change made for JBPORTAL-2114 as it's causing problems with WSRP
- JBPORTAL-2147: more API fixes
    • -13
    • +13
    ./coordination/CoordinationService.java
    • -4
    • +3
    ./coordination/SimpleEventConverter.java
  1. … 4 more files in changeset.
- JBPORTAL-2147: renamed AliasBindingInfo.getNames to getParameterNames.

- Fixed incorrect implementation of CoordinationService.getParameterBindings(page, qname) and added test cases.

    • -6
    • +10
    ./coordination/CoordinationService.java
  1. … 4 more files in changeset.
- JBPORTAL-2147: first step.

+ Removed ParameterBindingInfo parent

+ Renamed WindowBindingInfo to ParameterBindingInfo

+ Renamed methods and variables accordingly

+ Improved getEventWindows implementation a little (needs test case, btw)

    • -41
    • +34
    ./coordination/CoordinationService.java
  1. … 8 more files in changeset.
- JBPORTAL-2184: fixed NPE, cleaned-up code at the same time.
    • -25
    • +13
    ./api/node/PortalNodeEventContextImpl.java
- Implemented possibility to select several parameters for a given window. Not convinced this

is the proper way to do things but committing so it's not lost. Might be reverted.

    • -52
    • +59
    ./coordination/CoordinationService.java
  1. … 13 more files in changeset.
- Added getAliasBinding(page, name), removeAliasBinding(page, name) and renameAliasBinding(page, alias name, new name) methods.

- Added test cases.

- I have "optimized" some cases by using declared properties instead of properties (in this commit and previous) and it just

occurred to me that this might break behavior. But as this potential behavior was not tested, I have no way to know... Bolek?

    • -13
    • +51
    ./coordination/CoordinationService.java
  1. … 2 more files in changeset.
- Oops, getWindowBindingInfo should really be getWindowBinding...
    • -2
    • +2
    ./coordination/CoordinationService.java
  1. … 2 more files in changeset.
- Added removeWindowBinding(page, name), renameWindowBinding(page, old name, new name) and getWindowBindingInfo(page, name) methods

- Fixed an issue with PREFIX_PARAMETER_ALIAS_LENGTH which wasn't correct.

- get*(page, name) should return null when the coordination element is not found instead of failing.

- Improved tests and coverage.

    • -10
    • +68
    ./coordination/CoordinationService.java
  1. … 2 more files in changeset.
- Re-organization and minor improvements.

- Javadoc of newly added methods.

    • -46
    • +31
    ./coordination/CoordinationService.java
  1. … 1 more file in changeset.
- Added getPage method on EventWiringInfo and ParameterBindingInfo

- Added getEventWiring, removeEventWiring(page, name) and renameEventWiring(page, oldName, newName) methods for easier use.

- EventWiringManagerBean uses new method and rename and delete operations should now properly work from the GUI.

- Added more tests.

    • -60
    • +153
    ./coordination/CoordinationService.java
  1. … 5 more files in changeset.
- Minor.
- getEventWirings was not processing all the events due to a weird break...

- Added test case that replicates the bug.

    • -3
    • +1
    ./coordination/CoordinationService.java
  1. … 1 more file in changeset.