• last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- Extracted checking for default status to PortalObjectUtil so that it can be reused elsewhere.
    • -0
    • +54
    ./portal/PortalObjectUtil.java
  1. … 1 more file in changeset.
- JBPORTAL-2384:

+ Really avoid creating dashboard until needed.

+ Fixed incorrect behavior for copy to dashboard link where the link wouldn't appear if the dashboard didn't already exist.

+ Problem with new behavior: copy to dashboard is now also present on default/default which wasn't the case before... This

doesn't have any side effect has copy will not copy if the page already exists in dashboard.

  1. … 2 more files in changeset.
JBPORTAL-2384: Avoid creating dashboard objects if dashboard isn't used

  1. … 2 more files in changeset.
- Updated from 2.7.2

- Slightly modified styles (green instead of red for DnD zones, re-added bigger tab menu with less padding)

- Minor improvements.

    • -1
    • +2
    ./portal/PortalObjectResponseHandler.java
  1. … 8 more files in changeset.
- JBPORTAL-2326: needs to be tested

+ If no parameters is passed to a page to be displayed, erased previous page navigational state

+ If we have a PNS, pass the current state as parameters to ViewPageCommand before full refresh in AJAX context (hackish)

+ Improved getPortletPublicNavigationalState method to avoid unnecessary work

    • -8
    • +8
    ./portal/command/view/ViewPageCommand.java
    • -2
    • +2
    ./portal/navstate/PortalObjectNavigationalStateContext.java
  1. … 2 more files in changeset.
- Added getLastComponentName method to return the object name.
- Removed now useless query for previous PNS.
    • -3
    • +1
    ./portal/command/view/ViewPageCommand.java
- JBPORTAL-2326:

+ Not sure why previous PNS was saved in ViewPageCommand: limited testing hasn't shown any adverse side effects so far

+ Do not iterate over all bindings when looking for PNS for a window (was previously overwriting found PNS)

    • -13
    • +6
    ./portal/command/view/ViewPageCommand.java
  1. … 1 more file in changeset.
- JBPORTAL-2040:

+ Re-wrote PortalObject.getChild to use container directly instead of going through ObjectNode.getChildren

to avoid having to retrieve all the children just to get one. This should yield a massive reduction in DB

requests.

+ Removed unused instances and pages SelectedItems in PortalObjectManagerBean

- Added PortalObjectId.getChildId to efficiently get a child's id from a parent and use ParameterValidation.

  1. … 2 more files in changeset.
- Extracted display name behavior from Instance and PortalObject into a HasDisplayName interface.
    • -0
    • +47
    ./HasDisplayName.java
- Replace Element.getElementsByClassName by select as it's deprecated in Prototype 1.6+. Should fix partial refresh.

- UpdateWindowResponse doesn't seem used anymore so make PortalObjectResponseHandler fail if we encounter one to try to see if it's really not used anymore.

- Removed duplicated code in InternalContentProvider (supportedModes and supportedWindowStates were reset when getting the ones for the current media type).

- Clean-ups.

    • -13
    • +13
    ./portal/PortalObjectResponseHandler.java
  1. … 4 more files in changeset.
Japanese addon

  1. … 13 more files in changeset.
JBPORTAL-2248: Action URL retained by client

  1. … 1 more file in changeset.
JBPORTAL-2248: Action URL retained by client
    • -61
    • +0
    ./portal/command/action/InvokeWindowCommand.java
JBPORTAL-2246: Portlet invoker exception during portlet window rendering

    • -0
    • +56
    ./instance/InstanceInvoker.java
  1. … 2 more files in changeset.
sync from 2.6 branch

- JBPORTAL-2147: more API fixes
  1. … 5 more files in changeset.
- JBPORTAL-2147: Should have been removed.
JBPORTAL-2178: NPE when requesting dashboard as unauthenticated user

Don't NPE but returns a 500 error

    • -2
    • +17
    ./portal/command/view/ViewContextCommand.java
  1. … 2 more files in changeset.
- JBPORTAL-2147: first step.

+ Removed ParameterBindingInfo parent

+ Renamed WindowBindingInfo to ParameterBindingInfo

+ Renamed methods and variables accordingly

+ Improved getEventWindows implementation a little (needs test case, btw)

  1. … 7 more files in changeset.
JBPORTAL-2187: Partial refresh broke while integrating portlet container 2.0
    • -0
    • +4
    ./portal/navstate/PortalObjectNavigationalStateContext.java
  1. … 1 more file in changeset.
JBPORTAL-2165: Portal objects with a name longer than 57 cause javascript error in the admin portlet
  1. … 1 more file in changeset.
- Implemented possibility to select several parameters for a given window. Not convinced this

is the proper way to do things but committing so it's not lost. Might be reverted.

  1. … 7 more files in changeset.
- Added getChild(name, expectedType) convenience method.
  1. … 1 more file in changeset.
- Added getObject(id, expectedClass) method for convenience.
    • -0
    • +13
    ./portal/PortalObjectContainer.java
  1. … 1 more file in changeset.
- Generification.
    • -5
    • +1
    ./portal/metadata/ContextMetaData.java
  1. … 1 more file in changeset.
JBPORTAL-2144: Let a portlet defines the browser title
  1. … 14 more files in changeset.
- Minor.
    • -1
    • +1
    ./portal/DefaultPortalCommandFactory.java
  1. … 3 more files in changeset.
change <name>-> <id> in xml for <alias-binding> and <parameter-binding>
  1. … 2 more files in changeset.
Another Coordination refactoring - hopefully the very last one for now....

- Remove CoordinationStrategy, add implicit-mode and update configs and logic

  1. … 9 more files in changeset.