• last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- JBPORTAL-2428: Now properly validates inputs (including WSDL URL that wasn't properly validated by URL constructor due to a Java bug).

- JSFBeanContext now provides renderResponseImmediately method to bypass further processing in case of an error.

    • -0
    • +6
    ./org/jboss/portal/faces/gui/JSFBeanContext.java
  1. … 2 more files in changeset.
- Renamed ManagedBean.checkNameValidity to checkValidity as it's more correct.

- JBPORTAL-2427:

+ PreferenceBean now validates value in setValue

+ inject beanContext in PortletManagerBean and InstanceManagerBean so that it can be made available to PreferenceBean via PreferencesBean

+ added error reporting in editPreferences.xhtml and fixed typo

    • -15
    • +15
    ./org/jboss/portal/faces/gui/ManagedBean.java
  1. … 22 more files in changeset.
- Use bean context to output messages in PortalObjectManagerBean, improving localization.

- Made getErrorSeverity, getInfoSeverity and createLocalizedMessage methods public on BeanContext.

    • -3
    • +3
    ./org/jboss/portal/faces/gui/BeanContext.java
    • -5
    • +5
    ./org/jboss/portal/faces/gui/JSFBeanContext.java
  1. … 3 more files in changeset.
- Added isTargetResolved to BeanContext to be able to check that a given target String can be used to display error message.

- JBPORTAL-2419:

+ DisplayNameAction now switches the error target as it varies on context (defaults to status if cannot be resolved)

+ Added missing message in displayNameObject.xhtml

    • -0
    • +2
    ./org/jboss/portal/faces/gui/BeanContext.java
    • -4
    • +22
    ./org/jboss/portal/faces/gui/JSFBeanContext.java
  1. … 3 more files in changeset.
JBPORTAL-2412: Validate registration policy and registration validator class names.
    • -3
    • +4
    ./org/jboss/portal/faces/gui/ManagedBean.java
  1. … 4 more files in changeset.
- JBPORTAL-2409:

+ Properly inject bean context in PropertyBean and subclasses.

+ ManagedBean.PropertyValidator can now provide error message key to checkNameValidity for better error reporting.

    • -3
    • +11
    ./org/jboss/portal/faces/gui/ManagedBean.java
  1. … 7 more files in changeset.
- JBEPP-90:

+ Added XSS validation to username validator

+ Added JSF validator for user profile attributes to detect XSS attempts

+ PropertyValidator can now specify which validation pattern to use

    • -0
    • +20
    ./org/jboss/portal/faces/gui/JSFBeanContext.java
    • -1
    • +10
    ./org/jboss/portal/faces/gui/ManagedBean.java
  1. … 12 more files in changeset.
- JBEPP-83:

+ Added forgotten bean context to dashboardmgr instance

+ MessageValidationHandler instances can choose which error message to use

+ PropertyValidator implementations can provide their own ValidationErrorHandler for more flexibility

+ ControlPropertyBean now provides better error message

    • -4
    • +19
    ./org/jboss/portal/faces/gui/ManagedBean.java
  1. … 3 more files in changeset.
- JBPORTAL-2393:

+ PropertyValidator now provides doSimpleChecks method to validate properties after checking for null but

before checking for XSS or duplicates. In particular, we now forbid names containing . or /

+ Made ManagedBean.DefaultPropertyValidator an inner class so that we can reuse more code

+ Updated localization resources

    • -22
    • +42
    ./org/jboss/portal/faces/gui/ManagedBean.java
  1. … 14 more files in changeset.
- Added PropertyValidator to ManagedBean to allow for more flexible property validation.
    • -9
    • +51
    ./org/jboss/portal/faces/gui/ManagedBean.java
- Added checkNameValidity(name, targetForErrorMessage, checkForDuplicates) method for better control over validation

    • -1
    • +6
    ./org/jboss/portal/faces/gui/ManagedBean.java
- Made resource name where error messages are found injectable.

- Better handling of non-existent localization key: now display the key and log info instead of failing.

    • -4
    • +38
    ./org/jboss/portal/faces/gui/BeanContext.java
    • -1
    • +1
    ./org/jboss/portal/faces/gui/JSFBeanContext.java
- JBPORTAL-2317: Fixed name validation checking for WSRP.

- Fixed an improper update of consumers information when a consumer's id was changed.

- Fixed improper handling of null in ManagedBean.normalizeStringIfNeeded and added test cases.

    • -3
    • +25
    ./org/jboss/portal/faces/gui/ManagedBean.java
    • -0
    • +71
    ./org/jboss/portal/test/faces/ManagedBeanTestCase.java
  1. … 5 more files in changeset.
- JBPORTAL-2317:

+ Moved Action code up to ManagedBean as it can be used outside of core-admin

+ Fixed incorrect behavior in PropertyAction.updateProperty

+ Renamed RenameAction.pageContainer to renamedObject as it is more correct and fixed behavior

+ Adapted CoordinationBean hierarchy to ManagedBean changes (this needs more testing)

+ Adapted WSRP backing beans to ManagedBean changes (this needs more testing)

+ Renamed ConsumerBean.isOldAndNewEqual to isOldAndNewDifferent since that is the behavior that is

implemented and moved it to ManagedBean along with normalizeStringIfNeeded

+ Fixed implementation of JSFContextBean.createMessage

    • -0
    • +5
    ./org/jboss/portal/faces/gui/BeanContext.java
    • -1
    • +17
    ./org/jboss/portal/faces/gui/JSFBeanContext.java
    • -2
    • +85
    ./org/jboss/portal/faces/gui/ManagedBean.java
  1. … 14 more files in changeset.
- Added Javadoc and made parameter names more precise.

- JSFBeanContext.createMessage now uses BeanContext.STATUS as target if none is specified.

    • -12
    • +40
    ./org/jboss/portal/faces/gui/BeanContext.java
    • -0
    • +7
    ./org/jboss/portal/faces/gui/JSFBeanContext.java
- Clean-up.
    • -2
    • +0
    ./org/jboss/portal/faces/gui/BeanContext.java
- JBPORTAL-2274: added PhaseListener to redirect to consumer list view if we cannot restore a consumer after session expiration.
    • -3
    • +5
    ./org/jboss/portal/faces/gui/BeanContext.java
    • -3
    • +13
    ./org/jboss/portal/faces/gui/JSFBeanContext.java
  1. … 3 more files in changeset.
- JBPORTAL-2264, JBPORTAL-2259: Improved performance of functor.

- Added test cases.

    • -7
    • +33
    ./org/jboss/portal/faces/util/JSFFunctor.java
    • -0
    • +63
    ./util/JSFFunctorTestCase.java
  1. … 1 more file in changeset.
- JBPORTAL-2264, JBPORTAL-2259: Added id sanitization before using them as HTML ids, users can still use names

with . or spaces... Display performance of instance list seems to suffer from it so should investigate

optimization.

    • -0
    • +100
    ./org/jboss/portal/faces/util/JSFFunctor.java
  1. … 3 more files in changeset.
- JBPORTAL-2230:

+ Wrong version of createErrorMessage was sometimes called.

+ Single quotes need to be escape in localized messages containing parameters (added test case showing the issue, even though it's not technically a Portal issue)

    • -1
    • +1
    ./org/jboss/portal/faces/gui/BeanContext.java
    • -0
    • +51
    ./org/jboss/portal/test/faces/MessageFormatTestCase.java
  1. … 5 more files in changeset.
  1. … 1 more file in changeset.
- Added getFromSession method.
    • -9
    • +46
    ./org/jboss/portal/faces/gui/BeanContext.java
- JBPORTAL-2148:

+ Moved ManagedBean and BeanContext to faces module.

+ Extracted methods to ManagedBean

- Coordination GUI:

+ Fixed localization of parameterized messages.

+ Removed value change listener that wasn't used

    • -0
    • +183
    ./org/jboss/portal/faces/gui/BeanContext.java
    • -0
    • +79
    ./org/jboss/portal/faces/gui/JSFBeanContext.java
    • -0
    • +44
    ./org/jboss/portal/faces/gui/ManagedBean.java
  1. … 20 more files in changeset.
- WSRP needs navigational state to be passed when creating an action command for templating purpose.

PortletRequestEncoder.encodeAction can just discard the NS instead of throwing an exception.

  1. … 2 more files in changeset.
Fixing content framework some more
  1. … 9 more files in changeset.
Oups
- Requires Principal scope attributes
- Fix for WSRP

- Fixing UserContext implementations

  1. … 3 more files in changeset.
Portlet Container 2.0.0

Common 1.2.0

Web 1.2.0

  1. … 73 more files in changeset.
WindowName was lost