• last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- JBPORTAL-2425:

+ WSRPPortletURL.create is now able to handle extra characters in an uninterpreted way to allow for concatenation

+ Adapted toString methods.

- Fixed a bug in WSRPResourceURL.dealWithSpecificParams that wasn't properly removing consumed parameters.

  1. … 1 more file in changeset.
- Added timeout on WS operations so that we don't deadlock anymore when trying to access a service that's not answering.

- Minor: use safe cast.
- Producer can now validate registration properties. Of course, current implementation of acceptValueFor is no-op, so...
    • -9
    • +18
    ./producer/RegistrationHandler.java
- JBPORTAL-2367: should solve the infinite loop issue.
    • -13
    • +20
    ./consumer/EndpointConfigurationInfo.java
- JBPORTAL-2366:

+ RequestProcessor.initInvocation now takes a more specific WSRPPortletInvocationContext as parameter for downstream processing of WindowContext.

+ RequestProcessor.createNavigationalState now uses StateString factory method as it should (which should lead to less duplicated processing).

+ RenderRequestProcessor.initInvocation now remembers which namespace is used for this invocation so that it can be re-written when the markup is processed

without having to bracket it with marker strings.

+ WSRPPortletInvocationContext now provides access to WindowContext so that request processors can know what the namespace is.

+ Use safer namespace generation algorithm.

- Use StateString.JBPNS_PREFIX since it's where the constant is instead of ParametersStateString.

- ActionRequestProcessor.initInvocation doesn't deal with navigational state anymore since it's dealt with in RequestProcessor (less duplicated processing).

    • -8
    • +3
    ./producer/ActionRequestProcessor.java
    • -11
    • +9
    ./producer/RenderRequestProcessor.java
    • -1
    • +7
    ./producer/WSRPPortletInvocationContext.java
- JBPORTAL-2355:

+ Do no use & in URLs anymore, use &.

+ Now throws an exception in case a doubly encoded & is ever detected again (so that we can detect them better)

+ Adapted test to change of behavior.

  1. … 1 more file in changeset.
- JBPORTAL-2355: Do not encode & in URLs as contract for toString is supposed to be non-XML encoded URLs... Needs more testing in particular with other WSRP consumers.
- JBPORTAL-2306: Fixed WSRPPortletURL.toString() method to properly add WSRP end rewriting token.

- Added test case.

  1. … 1 more file in changeset.
"Fix" the serialization issue

    • -3
    • +4
    ./consumer/ProducerSessionInformation.java
- JBPORTAL-2287: Added possibility to reload the consumers from the database.
    • -21
    • +24
    ./consumer/ConsumerRegistry.java
    • -1
    • +5
    ./consumer/ConsumerRegistryService.java
  1. … 5 more files in changeset.
- JBPORTAL-2284: Fixed error in eraseRegistrationInfo, removed checks for null RegistrationInfo as it never is null now.
- JBPORTAL-2284: ProducerInfo are now created with a RegistrationInfo that's marked as undetermined instead of null.
  1. … 2 more files in changeset.
- JBPORTAL-2205: use proper mode and window state names...
Inlined 2 methods that were only used once and were one-liners
- JBPORTAL-2233:

+ Re-wrote traversal logic of WSRPExtensionHandler to traverse the whole tree.

+ Added test case.

+ Removed dependency on DOMUtils.

    • -49
    • +32
    ./handler/WSRPExtensionHandler.java
  1. … 3 more files in changeset.
- JBPORTAL-2229: Check that portal dir exists in JBoss data dir, if not create it.

- JBPORTAL-2231: Updated schema version.

    • -7
    • +29
    ./producer/config/impl/ProducerConfigurationServiceImpl.java
- JBPORTAL-2208: quick fix, real issue here is that we should have a concept of "WSRP transaction" so

that multiple WSRP calls can share information and avoid going to the producer even without cache.

- JBPORTAL-2201: Remove extra separator: rewrite token should be replaced by the namespace and nothing else!
- Added debugging output.
- Replaced "magic" numbers for better robustness.
- request context is not used anymore.
    • -7
    • +4
    ./producer/WSRPPortletInvocationContext.java
- Also set the navigational state if it exists.
    • -0
    • +4
    ./producer/ActionRequestProcessor.java
- JBPORTAL-1726: there were still some issues if a producer was configured with a

non-reachable URL and then switched to a valid one. In particular, refreshing

producer with unreachable URL led to infinite loop.

    • -0
    • +2
    ./services/RemoteSOAPInvokerServiceFactory.java
- JBPORTAL-2185: return empty NavigationInfo and EventingInfo instead of null as it'd cause an NPE otherwise.
    • -10
    • +43
    ./consumer/portlet/info/WSRPPortletInfo.java
- JBPORTAL-2183: do not keep a local copy of the configuration in producer but retrieve it from

configuration service to avoid de-synchronization of state.

- Changed property name generation algorithm to avoid collisions.

  1. … 2 more files in changeset.
- Sort registration properties before displaying them, based on the natural ordering of their name.

- Added toString to RegistrationStatus for easier debugging.

  1. … 2 more files in changeset.
- JBPORTAL-2183: Properly remember the listeners when reloading a producer configuration.

Something is still not quite right with how the producer deals with configuration changes.

    • -2
    • +2
    ./producer/ServiceDescriptionHandler.java
    • -0
    • +5
    ./producer/config/ProducerRegistrationRequirements.java
    • -2
    • +53
    ./producer/config/impl/ProducerConfigurationServiceImpl.java
    • -1
    • +10
    ./producer/config/impl/ProducerRegistrationRequirementsImpl.java
  1. … 1 more file in changeset.
- Added isRegistrationPropertiesEmpty method.
- Made listener extend default one. Seems to be properly called now.
    • -2
    • +4
    ./consumer/RegistrationInfoPostLoadEventListener.java