• last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- Use local variable for CapabilitiesInfo to avoid having to retrieve the portlet several times as it could be costly with WSRP.
    • -34
    • +36
    ./impl/model/content/InternalContentProvider.java
- portal object permission "view" should not imply "recursive view" on the same node (it was not on descendants)
    • -13
    • +13
    ./impl/model/portal/ObjectNode.java
    • -3
    • +3
    ./model/portal/PortalObjectContainer.java
    • -36
    • +4
    ./model/portal/PortalObjectPermission.java
  1. … 6 more files in changeset.
Slightly better error handling
    • -7
    • +13
    ./model/portal/command/view/ViewPortalCommand.java
Let the user configure which namespace to use. Useful to directly login into the dashboard.
  1. … 2 more files in changeset.
replace page customization String URL by a simple implémentation of PortalURL which allow to lazy create URLs and also provide more programmatic control over the generated URL
  1. … 2 more files in changeset.
fix issues for dashboard permission detection
improve dashboard implementation
    • -1
    • +2
    ./controller/ajax/AjaxCommandFactory.java
    • -1
    • +2
    ./controller/ajax/AjaxResponseHandler.java
    • -0
    • +13
    ./controller/portlet/InvokePortletCommandFactory.java
    • -25
    • +36
    ./deployment/jboss/ObjectDeployment.java
    • -6
    • +0
    ./impl/api/node/PortalNodeURLFactory.java
    • -19
    • +40
    ./impl/model/CustomizationManagerService.java
    • -17
    • +11
    ./impl/model/portal/ObjectNode.java
    • -0
    • +58
    ./impl/model/portal/PortalObjectIdUserType.java
    • -7
    • +2
    ./impl/model/portal/PortalObjectImpl.java
  1. … 43 more files in changeset.
cache toString value of PortalObjectId
    • -11
    • +26
    ./model/portal/PortalObjectId.java
- better split between instance container logic and persistence

- set persistent classes as package protected so it cannot leak out of the package

    • -0
    • +60
    ./impl/model/instance/InstanceContainerContext.java
    • -30
    • +14
    ./impl/model/instance/InstanceContainerImpl.java
    • -256
    • +0
    ./impl/model/instance/InstanceSecurityBinding.java
    • -0
    • +36
    ./impl/model/instance/JBossInstanceContainerContext.java
  1. … 6 more files in changeset.
Order locales
- improved instance container implementation with a cleaner separation between the logic and the hibernate persistence

- improved instance container test cases

    • -0
    • +82
    ./impl/model/instance/AbstractInstanceCustomization.java
    • -0
    • +82
    ./impl/model/instance/AbstractInstanceDefinition.java
    • -0
    • +517
    ./impl/model/instance/InstanceContainerImpl.java
    • -183
    • +0
    ./impl/model/instance/InstanceDefinitionImpl.java
    • -351
    • +0
    ./impl/model/instance/InstanceImpl.java
  1. … 13 more files in changeset.
- minor code reorg in portal object container

- no need to inject CustomizationManager in portal object container anymore as it is used by the internal portlet content provider instead

  1. … 4 more files in changeset.
- introduced PortletInfoFactory that allows to plug in PortletInfo extension

- replaced usage of build time meta data in portlet core aspects by an extension of the portlet runtime meta data

- optimized security checks in the PortalNodeImpl object by leveraging the fact that the security check view recursive on a node will imply the security check view on its children

    • -8
    • +8
    ./aspects/portlet/AjaxInterceptor.java
    • -22
    • +16
    ./aspects/portlet/HeaderInterceptor.java
    • -4
    • +13
    ./impl/api/node/PortalNodeImpl.java
    • -2
    • +2
    ./impl/model/portal/PortalObjectImpl.java
    • -0
    • +47
    ./impl/portlet/info/AjaxInfoImpl.java
    • -0
    • +44
    ./impl/portlet/info/CorePortletInfoFactory.java
    • -0
    • +80
    ./impl/portlet/info/CorePortletInfoImpl.java
    • -0
    • +61
    ./impl/portlet/info/MarkupHeaderInfoImpl.java
    • -0
    • +32
    ./portlet/info/AjaxInfo.java
    • -0
    • +50
    ./portlet/info/CorePortletInfo.java
    • -0
    • +34
    ./portlet/info/MarkupHeaderInfo.java
  1. … 52 more files in changeset.
Fix: JBPORTAL-1385 After assigning new role to a user, the User Portlet is left in a Maximized State

Slightly changed, now the wondows stays in maximize but list the users so that changes are directly seen

  1. … 1 more file in changeset.
removed useless constants
- added missing Context interface

- renamed instanceRef -> URI field on the WindowImpl object (need to keep the underlying DB field instanceRef though)

- added convenient Window.getPage() method

    • -15
    • +16
    ./impl/model/portal/WindowImpl.java
  1. … 1 more file in changeset.
minor locale improvement
- JBPORTAL-1380 : LocaleInterceptor does not build correctly the Locale from the user favorite locale
    • -4
    • +7
    ./aspects/server/LocaleInterceptor.java
- removed obsolete LocaleInfo class

- moved locale conversion methods which are useful and used to new LocaleFormat class which alllow conversion of Locale to a string format back and forth

- updated test cases accordingly

- moved ConversionException class to o.j.p.common.util so it can be reused more easily in various packages

  1. … 31 more files in changeset.
minor variable renaming
    • -6
    • +6
    ./controller/ajax/AjaxResponseHandler.java
removed unused code statements
    • -1
    • +0
    ./controller/ajax/AjaxResponseHandler.java
removed unused code statements
    • -3
    • +1
    ./controller/ajax/AjaxResponseHandler.java
renamed EventBridge to ServletEventBridge as we bridge servlet events to portal events
    • -145
    • +0
    ./impl/api/event/EventBridge.java
    • -0
    • +145
    ./impl/api/event/ServletEventBridge.java
  1. … 1 more file in changeset.
minor
    • -4
    • +3
    ./impl/api/node/PortalNodeURLFactory.java
transform inner classes into outter classes
    • -0
    • +93
    ./impl/api/node/AbstractPortalNodeURL.java
    • -0
    • +49
    ./impl/api/node/PageURL.java
    • -93
    • +0
    ./impl/api/node/PortalNodeURLFactory.java
    • -0
    • +49
    ./impl/api/node/WindowURL.java
- WindowRenderEvent was not returned properly

- package reorg in the portal api impl to better match the api package org

    • -4
    • +4
    ./aspects/controller/node/Navigation.java
    • -132
    • +0
    ./impl/api/CoreNavigationalStateContext.java
    • -97
    • +0
    ./impl/api/CorePortalRuntimeContext.java
    • -158
    • +0
    ./impl/api/PortalNodeURLFactory.java
    • -0
    • +100
    ./impl/api/PortalRuntimeContextImpl.java
    • -0
    • +145
    ./impl/api/event/EventBridge.java
    • -0
    • +47
    ./impl/api/event/PortalEventContextImpl.java
  1. … 12 more files in changeset.
- create WindowRenderEvent correctly
- reorg of PortalSession and UserSessionEvent->PortalSessionEvent

- improved WindowRenderEvent

    • -1
    • +1
    ./impl/api/CorePortalRuntimeContext.java
  1. … 11 more files in changeset.
- document the header injection of content in dtd
    • -2
    • +1
    ./deployment/JBossApplicationMetaDataFactory.java
    • -3
    • +2
    ./metadata/portlet/ElementMetaData.java
  1. … 9 more files in changeset.
- WindowNS serialiable