Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
JBIDE-16753 - Provide support for server-side Filters and Interceptors

Added support for ContainerRequestFilter, ContainerResponseFilter, ReaderInterceptor and WriterInterceptor

Renamed org.jboss.tools.ws.jaxrs.core.jdt to org.jboss.tools.ws.jaxrs.utils to better reflect the content of this package

Removed org.jboss.tools.ws.jaxrs.core.utils.JavaFieldsVisitor and replaced by using org.eclipse.jdt.core.dom.NodeFinder

Added Hyperlink navigation when selecting a NameBinding element, to navigate from a Resource/ResourceMethod/Application to

its associated Filter/Interceptor.

Added JUnit tests in core and ui (validation) to cover new code

Also fixed:

* JBIDE-16790 - Should add/remove Resource Methods and Endpoints when adding/removing @HttpMethod annotation

* JBIDE-15526 - JAX-RS validation problems are not linked

    • -539
    • +0
    ./JaxrsProviderValidatorTestCase.java
    • -630
    • +0
    ./JaxrsApplicationValidatorTestCase.java
    • -405
    • +0
    ./JaxrsHttpMethodValidatorTestCase.java
    • -90
    • +0
    ./JaxrsMetamodelValidatorTestCase.java
    • -551
    • +0
    ./JaxrsResourceValidatorTestCase.java
  1. … 228 more files in changeset.
JBIDE-10539 - Support for JAX-RS Field injection

Also changed the way URL Path Template are displayed on endpoints in the JAX-RS Explorer

also fixed JBIDE-12029 - No type for PathParam parameters in JAX-RS REST Web Services Explorer

  1. … 53 more files in changeset.
JBIDE-15548 - Use JUnit @Rules instead of inheritance in test cases

    • -64
    • +84
    ./JaxrsApplicationValidatorTestCase.java
    • -62
    • +87
    ./JaxrsHttpMethodValidatorTestCase.java
    • -4
    • +21
    ./JaxrsMetamodelValidatorTestCase.java
    • -58
    • +81
    ./JaxrsProviderValidatorTestCase.java
    • -95
    • +125
    ./JaxrsResourceValidatorTestCase.java
  1. … 53 more files in changeset.
Revert "JBIDE-16264 - @PathParam with hyphen in value shows as JAX-RS error"

This reverts commit 1107ed4b0acfa7f10e2b8832ed471925a10df99c.

    • -164
    • +0
    ./JaxrsResourceValidatorTestCase.java
  1. … 1 more file in changeset.
JBIDE-16328 - Buglets in JaxrsResourceMethodValidatorDelegate.validatePublicModifierOnJavaMethod()

Fixed the incomplete validation message ('{0}' was not substitued).

Added an exception if the parent type is an interface.

    • -1
    • +21
    ./JaxrsResourceValidatorTestCase.java
  1. … 2 more files in changeset.
JBIDE-16328 - Buglets in JaxrsResourceMethodValidatorDelegate.validatePublicModifierOnJavaMethod()

Fixed the incomplete validation message ('{0}' was not substitued).

Added an exception if the parent type is an interface.

    • -1
    • +21
    ./JaxrsResourceValidatorTestCase.java
  1. … 2 more files in changeset.
JBIDE-16264 - @PathParam with hyphen in value shows as JAX-RS error

Fixing the reported error type (was wrong id)

Allowing for hyphen, underscore and dot characters but in first position

for the path parameters.

Added JUnit tests to cover valid/invalid path param values

    • -0
    • +164
    ./JaxrsResourceValidatorTestCase.java
  1. … 1 more file in changeset.
JBIDE-16264 - @PathParam with hyphen in value shows as JAX-RS error

Fixing the reported error type (was wrong id)

Allowing for hyphen, underscore and dot characters but in first position

for the path parameters.

Added JUnit tests to cover valid/invalid path param values

    • -0
    • +164
    ./JaxrsResourceValidatorTestCase.java
  1. … 1 more file in changeset.
JBIDE-16264 - @PathParam with hyphen in value shows as JAX-RS error

Fixing the reported error type (was wrong id)

Allowing for hyphen, underscore and dot characters but in first position

for the path parameters.

Added JUnit tests to cover valid/invalid path param values

    • -0
    • +164
    ./JaxrsResourceValidatorTestCase.java
  1. … 1 more file in changeset.
JBIDE-15908 - Problem decorator is not removed after error was fixed

Bug was that the problemLevel on each JAX-RS Resource Method would not

be reset at the beginning of the validation, and during validation, the

highest problem level is kept. Thus, during the next validation (fixing

the problem), the problem level would remain at its highest (previous)

value.

Added tests to verify the correct behaviour on all validators.

    • -13
    • +35
    ./JaxrsApplicationValidatorTestCase.java
    • -14
    • +29
    ./JaxrsHttpMethodValidatorTestCase.java
    • -2
    • +2
    ./JaxrsMetamodelValidatorTestCase.java
    • -16
    • +41
    ./JaxrsProviderValidatorTestCase.java
    • -69
    • +69
    ./JaxrsResourceValidatorTestCase.java
  1. … 4 more files in changeset.
JBIDE-15908 - Problem decorator is not removed after error was fixed

Bug was that the problemLevel on each JAX-RS Resource Method would not

be reset at the beginning of the validation, and during validation, the

highest problem level is kept. Thus, during the next validation (fixing

the problem), the problem level would remain at its highest (previous)

value.

Added tests to verify the correct behaviour on all validators.

    • -13
    • +35
    ./JaxrsApplicationValidatorTestCase.java
    • -14
    • +29
    ./JaxrsHttpMethodValidatorTestCase.java
    • -2
    • +2
    ./JaxrsMetamodelValidatorTestCase.java
    • -16
    • +41
    ./JaxrsProviderValidatorTestCase.java
    • -69
    • +69
    ./JaxrsResourceValidatorTestCase.java
  1. … 4 more files in changeset.
JBIDE-15839 - Exception while saving Provider in JAX-RS application

Fixed the problem which occurred only when the problem severity as set to

'ignore' level. In that particular case, no IMarker would be created, thus

returning a null reference, which lead to NPE.

Added JUnit tests to cover all ways to create JAX-RS Markers.

    • -0
    • +30
    ./JaxrsApplicationValidatorTestCase.java
    • -0
    • +32
    ./JaxrsHttpMethodValidatorTestCase.java
    • -1
    • +0
    ./JaxrsMetamodelValidatorTestCase.java
    • -0
    • +33
    ./JaxrsProviderValidatorTestCase.java
  1. … 3 more files in changeset.
JBIDE-15839 - Exception while saving Provider in JAX-RS application

Fixed the problem which occurred only when the problem severity as set to

'ignore' level. In that particular case, no IMarker would be created, thus

returning a null reference, which lead to NPE.

Added JUnit tests to cover all ways to create JAX-RS Markers.

    • -0
    • +30
    ./JaxrsApplicationValidatorTestCase.java
    • -0
    • +32
    ./JaxrsHttpMethodValidatorTestCase.java
    • -1
    • +0
    ./JaxrsMetamodelValidatorTestCase.java
    • -0
    • +33
    ./JaxrsProviderValidatorTestCase.java
  1. … 3 more files in changeset.
JIBDE-12860 - JAX-RS validation problems are not linked

Fixed the problem where some markers would not be removed from the resource to be validated between

two validation calls, which meant that duplicate markers for the same problem would exist on each

resource.

Also refactored the search/element retrieval: the JaxrsElementIndexationDelegate now not only

deals with the Lucene indexation and searches, but also uses the metamodel to return List of

JAX-RS elements, Endpoints or workspace Resources.

Renamed some marker deletion/undexing methods to use the "remove" verb (eg: "removeMarker()") and be consistent with the

existing "remove()" methods that remove the elements themselves.

Added JUnit tests to covers the fixes.

This patch also fixes:

- JBIDE-15662: Warning Multiple JAX-RS Activators doesn't disappear

- JBIDE-15664: Application path configured in web.xml causes warning

    • -2
    • +185
    ./JaxrsApplicationValidatorTestCase.java
    • -1
    • +1
    ./JaxrsHttpMethodValidatorTestCase.java
  1. … 35 more files in changeset.
JIBDE-12860 - JAX-RS validation problems are not linked

Fixed the problem where some markers would not be removed from the resource to be validated between

two validation calls, which meant that duplicate markers for the same problem would exist on each

resource.

Also refactored the search/element retrieval: the JaxrsElementIndexationDelegate now not only

deals with the Lucene indexation and searches, but also uses the metamodel to return List of

JAX-RS elements, Endpoints or workspace Resources.

Renamed some marker deletion/undexing methods to use the "remove" verb (eg: "removeMarker()") and be consistent with the

existing "remove()" methods that remove the elements themselves.

Added JUnit tests to covers the fixes.

This patch also fixes:

- JBIDE-15662: Warning Multiple JAX-RS Activators doesn't disappear

- JBIDE-15664: Application path configured in web.xml causes warning

    • -2
    • +185
    ./JaxrsApplicationValidatorTestCase.java
    • -1
    • +1
    ./JaxrsHttpMethodValidatorTestCase.java
  1. … 35 more files in changeset.
JIBDE-12860 - JAX-RS validation problems are not linked

Fixed the problem where some markers would not be removed from the resource to be validated between

two validation calls, which meant that duplicate markers for the same problem would exist on each

resource.

Also refactored the search/element retrieval: the JaxrsElementIndexationDelegate now not only

deals with the Lucene indexation and searches, but also uses the metamodel to return List of

JAX-RS elements, Endpoints or workspace Resources.

Renamed some marker deletion/undexing methods to use the "remove" verb (eg: "removeMarker()") and be consistent with the

existing "remove()" methods that remove the elements themselves.

Added JUnit tests to covers the fixes.

This patch also fixes:

- JBIDE-15662: Warning Multiple JAX-RS Activators doesn't disappear

- JBIDE-15664: Application path configured in web.xml causes warning

    • -2
    • +185
    ./JaxrsApplicationValidatorTestCase.java
    • -1
    • +1
    ./JaxrsHttpMethodValidatorTestCase.java
  1. … 35 more files in changeset.
JBIDE-15508 - Incorrect problem marker when refactoring a custom Qualifier

Initial problem was that *any* annotation would be taken as a JAX-RS HTTP Method,

which was über wrong.

Added tests cases to verify.

    • -0
    • +24
    ./JaxrsHttpMethodValidatorTestCase.java
  1. … 3 more files in changeset.
JBIDE-15508 - Incorrect problem marker when refactoring a custom Qualifier

Initial problem was that *any* annotation would be taken as a JAX-RS HTTP Method,

which was über wrong.

Added tests cases to verify.

    • -0
    • +24
    ./JaxrsHttpMethodValidatorTestCase.java
  1. … 3 more files in changeset.
JBIDE-12860 - JAX-RS validation problems are not linked

Added a custom JAXRS_PROBLEM_TYPE attribute in JAX-RS markers.

Those JAX-RS Problem markers are now indexed with Lucene.

Thus, it becomes possible to look for resource that have the same

error as a given resource, even if this later one has been deleted.

(eg: looking for duplicate application problem after an application

has been removed).

When a JAX-RS Element is removed, its associated JAX-RS Markers are

removed from the index *during the validation phase* (the markers

still exist and are still indexed until the validation is performed).

Added some JUnit tests to verify the good behaviour againts the case

where a project has 2 JAX-RS application then one is removed.

    • -3
    • +69
    ./JaxrsApplicationValidatorTestCase.java
  1. … 21 more files in changeset.
JBIDE-12860 - JAX-RS validation problems are not linked

Added a custom JAXRS_PROBLEM_TYPE attribute in JAX-RS markers.

Those JAX-RS Problem markers are now indexed with Lucene.

Thus, it becomes possible to look for resource that have the same

error as a given resource, even if this later one has been deleted.

(eg: looking for duplicate application problem after an application

has been removed).

When a JAX-RS Element is removed, its associated JAX-RS Markers are

removed from the index *during the validation phase* (the markers

still exist and are still indexed until the validation is performed).

Added some JUnit tests to verify the good behaviour againts the case

where a project has 2 JAX-RS application then one is removed.

    • -3
    • +69
    ./JaxrsApplicationValidatorTestCase.java
  1. … 21 more files in changeset.
JBIDE-15402 - Doubled warnings Multiple JAX-RS Activators

Removed the duplicate validation at both the JaxrsApplications level and kept the one

at the JaxrsMetamodel level.

    • -0
    • +4
    ./JaxrsApplicationValidatorTestCase.java
    • -0
    • +6
    ./JaxrsHttpMethodValidatorTestCase.java
  1. … 4 more files in changeset.
JBIDE-15402 - Doubled warnings Multiple JAX-RS Activators

Removed the duplicate validation at both the JaxrsApplications level and kept the one

at the JaxrsMetamodel level.

    • -0
    • +4
    ./JaxrsApplicationValidatorTestCase.java
    • -0
    • +6
    ./JaxrsHttpMethodValidatorTestCase.java
  1. … 4 more files in changeset.
JBIDE-15067 - BadLocation Exception when validating a project with JAX-RS support

Couldn't reproduce the issue, but meanwhile, added a JUnit test to cover the block of code

where the issue appeared initially.

    • -5
    • +34
    ./JaxrsResourceValidatorTestCase.java
  1. … 1 more file in changeset.
JBIDE-15067 - BadLocation Exception when validating a project with JAX-RS support

Couldn't reproduce the issue, but meanwhile, added a JUnit test to cover the block of code

where the issue appeared initially.

    • -5
    • +34
    ./JaxrsResourceValidatorTestCase.java
  1. … 1 more file in changeset.
JBIDE-15039 - JAX-RS Problem decorator not shown on the Project Explorer node

Main refactoring/changes in this PR consist in:

- compare the problem level of each JAX-RS element before vs after the validation, and

in case of change, notify the metamodel. The metamodel will look for all affected Endpoints and

send 'problem level change' notification to the listeners (here, the UI). In turn, the UI will *update*

the associated node (update -> no refresh for sub nodes) to get a proper image decorator.

- same logix with the metamodel itself, except that the public problem level includes the problem level of the

JAX-RS elements, which means that the 'JAX-RS Web Services' node now reflects the whole Metamodel and thus, displays the

global problem level.

This new UI refresh strategy also reduces the number of times refresh occurred (there's now a single refresh per affected element, even

if this element has multiple problems).

- also fixed a problem where the UI listener would only be registered once the "JAX-RS Web Services" node was expended

    • -9
    • +22
    ./JaxrsApplicationValidatorTestCase.java
    • -1
    • +29
    ./JaxrsHttpMethodValidatorTestCase.java
    • -0
    • +2
    ./JaxrsMetamodelValidatorTestCase.java
    • -2
    • +15
    ./JaxrsProviderValidatorTestCase.java
    • -1
    • +26
    ./JaxrsResourceValidatorTestCase.java
  1. … 23 more files in changeset.
JBIDE-13542 - Disappearance of validation warning

Restored the missing call to the JaxrsMetamodelValidatorDelegate that performs cross-elements validation

Included two JUnit tests

    • -0
    • +45
    ./JaxrsApplicationValidatorTestCase.java
  1. … 2 more files in changeset.
JBIDE-13587 - Rewrite the way Java/resources changes are handled by the JAX-RS core plugin

Using Lucene to index JAX-RS Elements and Endpoints on multiple criteria

Having a more Object-oriented approach for the domain classes

Revising most of the JUnit tests after domain entities refactoring

    • -231
    • +247
    ./JaxrsApplicationValidatorTestCase.java
    • -248
    • +275
    ./JaxrsHttpMethodValidatorTestCase.java
    • -0
    • +72
    ./JaxrsMetamodelValidatorTestCase.java
    • -355
    • +445
    ./JaxrsProviderValidatorTestCase.java
    • -270
    • +277
    ./JaxrsResourceValidatorTestCase.java
  1. … 145 more files in changeset.
JBIDE-10207 Add support for JAX-RS Providers

Adding support for JAX-RS Providers lifecycle, including validation

Fixing NPE

    • -6
    • +5
    ./JaxrsApplicationValidatorTestCase.java
    • -0
    • +355
    ./JaxrsProviderValidatorTestCase.java
  1. … 66 more files in changeset.
JBIDE-13484 Simplify JAX-RS tests code

    • -29
    • +5
    ./JaxrsApplicationValidatorTestCase.java
    • -24
    • +24
    ./JaxrsHttpMethodValidatorTestCase.java
    • -18
    • +16
    ./JaxrsResourceValidatorTestCase.java
  1. … 36 more files in changeset.
Fixed - JBIDE-12934 Problem marker remains on "Error" on Endpoint node in Project explorer after error was fixed and "warning" remains

  1. … 16 more files in changeset.