Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
JBIDE-25669: Unexpected JAX-RS validation error for Feature (#302)

* JBIDE-25669: Unexpected JAX-RS validation error for Feature

Signed-off-by: Jeff MAURY <jmaury@redhat.com>

* Fix failing tests

Signed-off-by: Jeff MAURY <jmaury@redhat.com>

    • -1
    • +47
    ./internal/validation/Jaxrs20ProviderValidatorTestCase.java
  1. … 6 more files in changeset.
JBIDE-21977 - Unexpected JAX-RS validation error for client filters

Added support for classes that implement the 'javax.ws.rs.container.DynamicFeature'

interface.

    • -0
    • +21
    ./internal/validation/Jaxrs20ResourceValidatorTestCase.java
  1. … 4 more files in changeset.
JBIDE-21977 - Unexpected JAX-RS validation error for client filters

Added support for classes that implement the 'javax.ws.rs.container.DynamicFeature'

interface.

    • -0
    • +21
    ./internal/validation/Jaxrs20ResourceValidatorTestCase.java
  1. … 4 more files in changeset.
JBIDE-20608 - Build failure on Jenkins/OtherOS

Added missing case of resource deletion

Wait for resource content change before continuing test

    • -1
    • +2
    ./cnf/UriMappingsContentProviderTestCase.java
    • -4
    • +5
    ./internal/validation/JaxrsApplicationValidatorTestCase.java
    • -1
    • +3
    ./internal/validation/JaxrsHttpMethodValidatorTestCase.java
    • -5
    • +6
    ./wizards/JaxrsApplicationCreationWizardPageTestCase.java
  1. … 3 more files in changeset.
JBIDE-18562 - Confusing media types in JAX-RS resource creation wizard

    • -12
    • +22
    ./wizards/JaxrsResourceCreationWizardPageTestCase.java
  1. … 1 more file in changeset.
JBIDE-18561 - Default name for JAX-RS Application class

    • -19
    • +88
    ./wizards/JaxrsApplicationCreationWizardPageTestCase.java
    • -0
    • +61
    ./wizards/JaxrsElementCreationUtilsTestCase.java
  1. … 2 more files in changeset.
JBIDE-18690 - ResourceException while deleting project

    • -0
    • +69
    ./cnf/UriMappingsContentProviderTestCase.java
  1. … 2 more files in changeset.
JBIDE-18994 - Unexpected JAX-RS validation error for client filters

    • -8
    • +54
    ./internal/validation/Jaxrs20ResourceValidatorTestCase.java
  1. … 6 more files in changeset.
JBIDE-18994/JBIDE-18953 - Unexpected JAX-RS validation error for client filters

    • -8
    • +54
    ./internal/validation/Jaxrs20ResourceValidatorTestCase.java
  1. … 6 more files in changeset.
JBIDE-18714 - Invalid error message when @Target is missing on a custom Name Binding annotation

    • -1
    • +0
    ./internal/validation/JaxrsNameBindingValidatorTestCase.java
  1. … 1 more file in changeset.
JBIDE-18714 - Invalid error message when @Target is missing on a custom Name Binding annotation

    • -1
    • +0
    ./internal/validation/JaxrsNameBindingValidatorTestCase.java
  1. … 1 more file in changeset.
JBIDE-18710 - Invalid generated code in JAX-RS Endpoint

    • -1
    • +48
    ./wizards/JaxrsResourceCreationWizardPageTestCase.java
  1. … 3 more files in changeset.
JBIDE-18710 - Invalid generated code in JAX-RS Endpoint

    • -1
    • +48
    ./wizards/JaxrsResourceCreationWizardPageTestCase.java
  1. … 3 more files in changeset.
JBIDE-18392 - JAX-RS Resource wizard: Resource methods are created even though there is no Target entity specified anymore

Fixed the problem by skipping method generation if no target entity was specified

Added a JUnit test to cover that case

    • -0
    • +30
    ./wizards/JaxrsResourceCreationWizardPageTestCase.java
  1. … 2 more files in changeset.
JBIDE-18808 - JAX-RS Resource wizard: Resource methods are created even though there is no Target entity specified anymore

Fixed the problem by skipping method generation if no target entity was specified

Added a JUnit test to cover that case

    • -0
    • +30
    ./wizards/JaxrsResourceCreationWizardPageTestCase.java
  1. … 2 more files in changeset.
JBIDE-15825 - JAX-RS problems don't show up after target runtime is set

Main changes:

- handle changes at the project level when the classpath changed: rebuild the whoe JAX-RS metamodel to be process all the changes

- remove all JAX-RS markers of previous JAX-RS elements when rebuilding the while JAX-RS metamodel in a separate Job while the resource tree

is locked.

Related changes:

- added some unit tests

- refactored a unit test class

    • -2
    • +26
    ./internal/validation/JaxrsMetamodelValidatorTestCase.java
  1. … 8 more files in changeset.
JBIDE-15825 - JAX-RS problems don't show up after target runtime is set

Main changes:

- handle changes at the project level when the classpath changed: rebuild the whoe JAX-RS metamodel to be process all the changes

- remove all JAX-RS markers of previous JAX-RS elements when rebuilding the while JAX-RS metamodel in a separate Job while the resource tree

is locked.

Related changes:

- added some unit tests

- refactored a unit test class

    • -2
    • +26
    ./internal/validation/JaxrsMetamodelValidatorTestCase.java
  1. … 8 more files in changeset.
JBIDE-16327 - JaxrsFacetedProjectListener doesn't support JAX-RS 2.0

    • -0
    • +97
    ./facet/JaxrsFacetedProjectListenerTestCase.java
  1. … 1 more file in changeset.
JBIDE-16327 - JaxrsFacetedProjectListener doesn't support JAX-RS 2.0

    • -0
    • +97
    ./facet/JaxrsFacetedProjectListenerTestCase.java
  1. … 1 more file in changeset.
JBIDE-16163 - Missing update in JAX-RS explorer when facing to quick change in code

Accepting and processing events of type POST_CHANGE and POST_RECONCILE as one or the other

happens, depending if the change and save occurred at the same time (almost) or not.

    • -2
    • +2
    ./internal/validation/Jaxrs20BeanParamValidatorTestCase.java
    • -2
    • +2
    ./internal/validation/Jaxrs20ParamConverterProviderTestCase.java
    • -2
    • +2
    ./internal/validation/Jaxrs20ProviderValidatorTestCase.java
    • -2
    • +2
    ./quickfix/RetentionAnnotationMarkerResolutionTestCase.java
  1. … 15 more files in changeset.
JBIDE-15825 - JAX-RS problems don't show up after target runtime is set

    • -1
    • +0
    ./internal/validation/JaxrsApplicationValidatorTestCase.java
    • -0
    • +1
    ./internal/validation/JaxrsMetamodelValidatorAsYouTypeTestCase.java
    • -0
    • +99
    ./internal/validation/JaxrsMetamodelValidatorTestCase.java
  1. … 1 more file in changeset.
JBIDE-17296 - Warning decorator on the 'JAX-RS Web Services' node when no application is defined

    • -10
    • +21
    ./internal/validation/Jaxrs11ResourceValidatorTestCase.java
    • -1
    • +4
    ./internal/validation/Jaxrs20ParamConverterProviderTestCase.java
    • -2
    • +28
    ./internal/validation/JaxrsApplicationValidatorTestCase.java
    • -1
    • +2
    ./internal/validation/JaxrsNameBindingValidatorTestCase.java
  1. … 4 more files in changeset.
JBIDE-17296 - Missing warning decorator on the "JAX-RS Web Services" node when no application is defined

Also includes fixes for:

- JBIDE-17078 - JAX-RS Problems doesn't appears after the JAX-RS Support is activated

- JBIDE-17771 - Trigger validation when JAX-RS nature is added on a project

- JBIDE-18068 - JAX-RS Explorer doesn't have "expand" icon

- JBIDE-18114 - Invalid state of JAX-RS Web Services node in Project Explorer after JAX-RS Support removal

    • -78
    • +217
    ./internal/validation/Jaxrs11ResourceValidatorTestCase.java
    • -1
    • +2
    ./internal/validation/Jaxrs20ProviderValidatorTestCase.java
    • -2
    • +27
    ./internal/validation/Jaxrs20ResourceValidatorTestCase.java
    • -24
    • +26
    ./internal/validation/JaxrsApplicationValidatorTestCase.java
    • -8
    • +11
    ./internal/validation/JaxrsHttpMethodValidatorTestCase.java
    • -1
    • +1
    ./internal/validation/JaxrsMetamodelValidatorAsYouTypeTestCase.java
    • -7
    • +7
    ./internal/validation/JaxrsNameBindingValidatorTestCase.java
    • -6
    • +110
    ./internal/validation/ValidationUtils.java
    • -5
    • +5
    ./quickfix/RetentionAnnotationMarkerResolutionTestCase.java
    • -5
    • +5
    ./quickfix/TargetAnnotationMarkerResolutionTestCase.java
  1. … 38 more files in changeset.
JBIDE-17949 - Problem with filters and interceptors defined as inner classes

Fixed problem that still remained when underlying resource was saved:

- the validator for the inner provider would run first and report a problem,

- then the top level resource validator would remove all markers for the underlying file and perform

its validation, meaning that the markers for the inner provider would be gone.

Fixed a related problem where only top-level types would be considered, which excluded the inner provider.

    • -0
    • +39
    ./internal/validation/Jaxrs20ProviderValidatorTestCase.java
    • -1
    • +0
    ./internal/validation/JaxrsApplicationValidatorTestCase.java
    • -2
    • +1
    ./quickfix/JavaCompletionProposalUtils.java
    • -0
    • +4
    ./quickfix/TargetAnnotationMarkerResolutionTestCase.java
  1. … 11 more files in changeset.
JBIDE-17178 - Problem with filters and interceptors defined as inner classes

Removed the use of 'dirtyRegions' argument in the as-you-type validator because the given regions

do not match the actual changes...

    • -9
    • +27
    ./internal/validation/Jaxrs11ResourceValidatorTestCase.java
    • -0
    • +74
    ./internal/validation/Jaxrs20ProviderValidatorTestCase.java
  1. … 2 more files in changeset.
JBIDE-18022 - For JBIDE 4.2.0.CR1: Ensure copyrights and provider names are correct in all plugins and features [Webservices]

    • -1
    • +1
    ./configuration/ProjectNatureUtilsTestCase.java
    • -1
    • +1
    ./internal/utils/CollectionsUtilTestCase.java
    • -1
    • +1
    ./internal/validation/Jaxrs11ProviderValidatorTestCase.java
    • -1
    • +1
    ./internal/validation/Jaxrs11ResourceValidatorTestCase.java
    • -1
    • +1
    ./internal/validation/Jaxrs20BeanParamValidatorTestCase.java
    • -1
    • +1
    ./internal/validation/Jaxrs20ParamConverterProviderTestCase.java
    • -3
    • +9
    ./internal/validation/Jaxrs20ProviderValidatorTestCase.java
    • -1
    • +1
    ./internal/validation/Jaxrs20ResourceValidatorTestCase.java
    • -1
    • +1
    ./internal/validation/JaxrsApplicationValidatorTestCase.java
    • -1
    • +1
    ./internal/validation/JaxrsHttpMethodValidatorTestCase.java
    • -1
    • +1
    ./internal/validation/JaxrsMetamodelValidatorAsYouTypeTestCase.java
    • -1
    • +1
    ./internal/validation/JaxrsNameBindingValidatorTestCase.java
  1. … 363 more files in changeset.
JBIDE-18090 - Wrong JAX-RS Filter/Annotation binding problem report

Also fixed:

JBIDE-18078 - Wrong problem marker on binding annotation

JBIDE-18089 - Edit the JAX-RS binding navigation label, replace 'Jump to' with 'Open'

Added JUnit tests

    • -132
    • +625
    ./internal/validation/Jaxrs20ProviderValidatorTestCase.java
    • -39
    • +55
    ./internal/validation/ValidationUtils.java
  1. … 9 more files in changeset.
JBIDE-17976 - Problem markers are not removed on related Parameter Aggregators

Also introduced JaxrsResourceElement and JaxrsParameterAggregatorElement classes to reduce the code

Fixed JavaElementSearcher that did not return all 'related types' for a given type (was doing half of the job)

    • -8
    • +8
    ./internal/validation/Jaxrs11ResourceValidatorTestCase.java
    • -0
    • +124
    ./internal/validation/Jaxrs20BeanParamValidatorTestCase.java
    • -1
    • +1
    ./internal/validation/Jaxrs20ResourceValidatorTestCase.java
    • -4
    • +7
    ./internal/validation/ValidationUtils.java
  1. … 39 more files in changeset.
JBIDE-17663 - JAX-RS Explorer doesn't reflect binding parameter to field

Using flags to retrieve the type of JAX-RS annotation(s) that were part of the removed element

Using the 'Flags' class instead of 'int' in other places.

    • -1
    • +2
    ./internal/validation/Jaxrs20ParamConverterProviderTestCase.java
    • -9
    • +10
    ./internal/validation/JaxrsApplicationValidatorTestCase.java
    • -1
    • +1
    ./internal/validation/JaxrsNameBindingValidatorTestCase.java
    • -18
    • +0
    ./internal/validation/ValidationUtils.java
    • -4
    • +5
    ./wizards/JaxrsApplicationCreationWizardPageTestCase.java
  1. … 50 more files in changeset.
JBIDE-17796 - BeanParam: unbound @PathParam error is present after the problem had been fixed

Introduced the 'working copies' for JAX-RS elements being validated

Fixed a problem where some Java element changes would not be processed (linked to https://issues.jboss.org/browse/JBIDE-18009)

    • -129
    • +134
    ./internal/validation/Jaxrs11ResourceValidatorTestCase.java
    • -0
    • +38
    ./internal/validation/Jaxrs20BeanParamValidatorTestCase.java
    • -0
    • +73
    ./internal/validation/Jaxrs20ResourceValidatorTestCase.java
    • -3
    • +2
    ./internal/validation/JaxrsHttpMethodValidatorTestCase.java
    • -1
    • +4
    ./internal/validation/JaxrsMetamodelValidatorAsYouTypeTestCase.java
    • -3
    • +3
    ./internal/validation/JaxrsNameBindingValidatorTestCase.java
    • -0
    • +9
    ./internal/validation/ValidationUtils.java
    • -3
    • +5
    ./quickfix/JavaCompletionProposalUtils.java
    • -6
    • +6
    ./quickfix/RetentionAnnotationMarkerResolutionTestCase.java
    • -8
    • +8
    ./quickfix/TargetAnnotationMarkerResolutionTestCase.java
  1. … 54 more files in changeset.