ModeShape

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
MODE-1262 Temporary fix to unpublish the file published in the test. This patch needs to be removed when the problem is resovled

MODE-1262 Temporary fix to unpublish the file published in the test. This patch needs to be removed when the problem is resovled

MODE-1263 Corrected indexing logic for file system content

Added the integration test supplied by Danny (with some minor modifications) and updated the @Before method in the FileSystemRepositoryIntegrationTest, and verified the query does not include any of the files or folders already present on the file system.

After a bit of debugging, I was able to figure out what the problem is and why we're only seeing it for the file system connector.

The actual bug is in SearchEngineIndexer logic: when the subgraph comes back with just a single node (i.e., the subgraph only contains a single level), the loop at line 336 will exit without processing the children of the single node in the subgraph. The fix is to check for this condition and add the children to the locationsToRead list before going into the loop.

The problem only manifests itself with the FileSystemConnector because it is the only connector to override the 'absoluteMaximumDepthForBranches()' method to return 1. All other connectors return the default value, 4 (or some other number > 1), and therefore the subgraph contains multiple levels and the while loop is entered and the children processed.

After the fix to SearchEngineIndexer, all unit and integration tests pass, including the new integration test.

Thanks again to Danny C for identifying this issue and creating an easily reproducible test case!

MODE-1263 Corrected indexing logic for file system content

Added the integration test supplied by Danny (with some minor modifications) and updated the @Before method in the FileSystemRepositoryIntegrationTest, and verified the query does not include any of the files or folders already present on the file system.

After a bit of debugging, I was able to figure out what the problem is and why we're only seeing it for the file system connector.

The actual bug is in SearchEngineIndexer logic: when the subgraph comes back with just a single node (i.e., the subgraph only contains a single level), the loop at line 336 will exit without processing the children of the single node in the subgraph. The fix is to check for this condition and add the children to the locationsToRead list before going into the loop.

The problem only manifests itself with the FileSystemConnector because it is the only connector to override the 'absoluteMaximumDepthForBranches()' method to return 1. All other connectors return the default value, 4 (or some other number > 1), and therefore the subgraph contains multiple levels and the while loop is entered and the children processed.

After the fix to SearchEngineIndexer, all unit and integration tests pass, including the new integration test.

Thanks again to Danny C for identifying this issue and creating an easily reproducible test case!

MODE-1259 change the assembly to attach to mead repo, incorrectly change the wrong attach property

MODE-1259 change the assembly to attach to mead repo, incorrectly change the wrong attach property

MODE-1261 Fixed JackrabbitXmlNodeTypeRegistrationTest on Solaris.

BOM (Binary Order Mark) at the start of owfe_nodetypes.xml file was causing failing of two tests on Solaris 9 machines. BOM was deleted.

MODE-1261 Fixed JackrabbitXmlNodeTypeRegistrationTest on Solaris.

BOM (Binary Order Mark) at the start of owfe_nodetypes.xml file was causing failing of two tests on Solaris 9 machines. BOM was deleted.

MODE-1264 Upgraded webdav-servlet to 2.0.1

Also updated the documentation to reference the new version.

MODE-1259 Change modeshape-distribution pom.xml to attach javadocs to the mead repository

MODE-1259 Change modeshape-distribution pom.xml to attach javadocs to the mead repository

MODE-1256 Corrected federated move logic

The move logic within the join process of the federated connector was incorrectly setting the actual location of the node after it was moved. Because this happens after the source connector performed the move, the node was indeed moved. The error occurred during the federation of the source results, and thus caused a problem with the JCR layer. The fix was a simple correction.

This change adds new integration test that replicates the reporter's configuration (but with an in-memory instead of a file system source). Before the fix, this test did replicate the reported exception, and after the fix the test succeeds.

All unit and integration tests pass with these changes.

    • -0
    • +41
    /modeshape-integration-tests/src/test/resources/config/configRepositoryForFederatedInfinispan.xml
MODE-1256 Corrected federated move logic

The move logic within the join process of the federated connector was incorrectly setting the actual location of the node after it was moved. Because this happens after the source connector performed the move, the node was indeed moved. The error occurred during the federation of the source results, and thus caused a problem with the JCR layer. The fix was a simple correction.

This change adds new integration test that replicates the reporter's configuration (but with an in-memory instead of a file system source). Before the fix, this test did replicate the reported exception, and after the fix the test succeeds.

All unit and integration tests pass with these changes.

    • -0
    • +41
    /modeshape-integration-tests/src/test/resources/config/configRepositoryForFederatedInfinispan.xml
MODE-1244: Fix for NPE while server is being restarted

MODE-1244: Fix for NPE while server is being restarted

MODE-1254 Okay to call toString on ModeShape's Node and Property objects with Binary values

Large Binary values would cause an out-of-memory exception when 'toString()' is called.

This change corrects that behavior to place "**binary-value**" in the toString() result

any place where a Binary value is encountered.

A new unit test was added to verify the behavior, and all unit and integration tests pass.

MODE-1254 Okay to call toString on ModeShape's Node and Property objects with Binary values

Large Binary values would cause an out-of-memory exception when 'toString()' is called.

This change corrects that behavior to place "**binary-value**" in the toString() result

any place where a Binary value is encountered.

A new unit test was added to verify the behavior, and all unit and integration tests pass.

MODE-1257 Corrected class cast exception

The JoinRequestProcessor.process(RemovePropertyRequest) was incorrectly casting the forked request

to SetPropertyRequest. This was a copy-and-paste error, and fixing it appears to fix the issue.

(Additional tests being added under MODE-1256.)

All unit and integration tests pass with these changes.

MODE-1257 Corrected class cast exception

The JoinRequestProcessor.process(RemovePropertyRequest) was incorrectly casting the forked request

to SetPropertyRequest. This was a copy-and-paste error, and fixing it appears to fix the issue.

(Additional tests being added under MODE-1256.)

All unit and integration tests pass with these changes.

MODE-1255 Corrected 'restore' logic

The logic for restoring nodes was not correctly getting the 'jcr:primaryType' value when checking

if the node in version history had a primary type of 'nt:frozenNode': it was comparing the

'nt:frozenNode' Name constant to the Property object (rather than the first value of the Property).

Thus, the if-check never succeeded, and the node is restored with a primary type of 'nt:frozenNode'.

After the simple fix, all unit and integration tests pass.

MODE-1255 Corrected 'restore' logic

The logic for restoring nodes was not correctly getting the 'jcr:primaryType' value when checking

if the node in version history had a primary type of 'nt:frozenNode': it was comparing the

'nt:frozenNode' Name constant to the Property object (rather than the first value of the Property).

Thus, the if-check never succeeded, and the node is restored with a primary type of 'nt:frozenNode'.

After the simple fix, all unit and integration tests pass.

Ignored .log files (the correct way)

Ignored .log files (the correct way)

Ignored .log files

Ignored .log files

MODE-1243 Improved JndiRepositoryFactory logic and logging

The JndiRepositoryFactory now uses the "type" value (as specified in the 'conf/context.xml' for Tomcat) as the major impetus for registering the ModeShape JcrEngine instance or a javax.jcr.Repository instance. If an engine is to be registered, then the existence of a 'repositoryName' is logged as a warning. If a repository is to be registered, then the 'repositoryName' value is expected and must match an existing repository; all other cases are logged as an error.

MODE-1243 Improved JndiRepositoryFactory logic and logging

The JndiRepositoryFactory now uses the "type" value (as specified in the 'conf/context.xml' for Tomcat) as the major impetus for registering the ModeShape JcrEngine instance or a javax.jcr.Repository instance. If an engine is to be registered, then the existence of a 'repositoryName' is logged as a warning. If a repository is to be registered, then the 'repositoryName' value is expected and must match an existing repository; all other cases are logged as an error.

MODE-1251 Downgrade Hibernate to 3.3.2

Downgraded our use of Hibernate (only on the 2.5.x branch) to 3.3.2.GA and made one change to the POM

and to the HibernateAdapter class, which was using an API introduced in Hibernate in 3.5.

All unit and integration tests pass with these changes.

Downgraded Hibernate version to 3.4.0.GA so that it doesn't depend on JPA 2

MODE-1201 Reverted the addition of FileInputStreamBinary

Reverted the change to add a FileInputStreamBinary class. This change caused problems when the

BINARY value is read more than once and when stored in the In-Memory, Infinispan, JBoss Cache

and similar connectors (since they attempt to store the read-only-once value, preventing

reading the value back out). See MODE-1241 for details.

This reverts commit 51403d529df39d5d9d1c83f4e4d68190bbb708c4 and also deletes the

LargeFileTest.java test (perhaps added after 51403d?)