Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
MODE-2643 Changes the GitConnector's logic so that it always returns external binaries The previous code attempted to store binaries for large files into the repository's binary store which is not possible outside of a transaction. In general, connectors should always return external binaries which are resolved by the external system "on demand"

  1. … 1 more file in changeset.
MODE-2612 Updates the version of JGit and the logic of the GitConnectorTest to pre-fetch expected tags and branches

    • -22
    • +56
    ./org/modeshape/connector/git/GitConnectorTest.java
  1. … 4 more files in changeset.
MODE-2426 Fixed Git connector's handling of local branches.

    • -26
    • +39
    ./org/modeshape/connector/git/GitConnectorTest.java
  1. … 3 more files in changeset.
MODE-2352 Fixed the Git connector's paged navigation and the building of details for a "tree" object

  1. … 6 more files in changeset.
MODE-2303 Removed the "queryableBranches" feature of the Git Connector.

  1. … 5 more files in changeset.
Updated artifacts version to 3.8.1.GA and changed the GitConnector tests to reflect the structure of the https://github.com/jboss-integration/modeshape repository.

  1. … 67 more files in changeset.
MODE-2097, MODE-2169, MODE-2197 Integrated the latest version of the jboss-integration BOM. This commit includes changes for multiple different issues that snowballed: - packaging Javadocs in a zip - updating Apache POI In addition, after integrating the BOM a number of unit tests had to be updated to reflect changes in dependencies both from a functionality perspective and from a deprecation perspective. The most significant change there was the rewriting of the ConnectorTestCase (modeshape-jca) because the new versions of Arquillian + IronJacamar hold filelocks on Windows: https://issues.jboss.org/browse/JBJCA-1027

  1. … 93 more files in changeset.
MODE-2018 Implemented new query engine.

Refactored the query functionality to now use several new service provider interfaces (SPI),

and implemented a new query engine that can take advantage of administrator-defined indexes.

When no such indexes are defined, the query engine is able to still answer the queries

by "scanning" all nodes in the repository. This is like a regular relational database:

all query functionality works (albeith slowly) even when no indexes are defined, though

to improve performance simply define an appropriate index based upon the query or queries

that are being used.

All of ModeShape's query parsing, planning, and optimization steps are basically unchanged

from the previous query system. There is one addition to the rule-based optimizer: a new

rule looks at query plans and adds the potential indexes that might be of use in each

access query portion of a query plan. Then, the query execution process (see below)

chooses one of the identified indexes based upon the selectivity and cardinality. If no index

is available for that portion of the query plan, then the query engine simply iterates

over all queryable nodes in the repository.

A new kind of component, called a "query index provider", allows the query engine to delegate

various responsibilities around indexes to these providers. For example, a provider must

provide an index planner that can examine the constraints that apply to an access query

and determine if any of the provider's indexes can be used. When they are, ModeShape

adds those indexes to the query plan. If the query engine uses one of those indexes,

then provider must be able to return all of those nodes that satisfy the criteria

as described earlier by its index planner. Finally, as ModeShape content changes, ModeShape

will notify the index providers' of the changes so that they can ensure their indexes

are kept up-to-date with the content.

This means that a provider can implement the functionality using any kind of technology,

and consequently, that ModeShape can begin to leverage multiple kinds of search and index

technology within its query system. The ModeShape community anticipates having providers

that use Lucene, Solr, and ElasticSearch. ModeShape will also likely come with a provider

that maintains file-system based indexes. Additionally, providers can optionally support

indexes on one or more properties. Thus, it will be possible to mix and match

these providers, selecting the best technology for the specific kind of index.

The new query engine does the execution in a very different way than the previous engine,

which used Lucene to determine the tuples (that is, the values in each row) for each access

query and that were then further processed and combined to form the tuples that were returned

in the result set. The new engine instead uses a new concept of a "stream of node keys"

for each access query: what actually implements that stream depends on many factors.

A node sequence is an abstraction of a stream of "rows" containing one or more node keys.

The interfaces are designed to make it possibly to lazily implement a stream in a very

efficient manner. Specifically, a node stream is actually comprised of multiple "batches"

of rows, and batches can be of any size.

Consider when the engine findes no indexes are available for a certain access query. The

engine simply uses a "node sequence" (or NodeSequence) implementation that returns in batches

a row for each node in the repository.

But if an access query involves a criteria on the path of a node, such as

"... WHERE ISSAMENODE('/foo/bar') ...", then ModeShape knows that this query (or portion of

a query) will have only one result, namely the node at "/foo/bar". ModeShape doesn't need

an index to quickly find this node; it merely has to navigate to that path to find the one

node that satisfies this query. ModeShape has several other optimizations, too: it knows

when a query involves all children or descendants of a node at a given path, and can take

this into account when optimizing and executing the query. All of these are handled with

special NodeSequence implementations optimized for each case.

For many access queries (i.e., part of a larger query), the engine will use one of the

indexes identified by one of the providers. When this happens, ModeShape uses other

NodeSequence implementations that utilize the underlying indexes to find the nodes that satisfy

some of the criteria.

The above describes how the engine uses a single NodeSequence instance for each each access

query in a larger query. But how does the engine combine these to determine the ultimate

query results? Basically, the engine constructs a series of functions that process one or more

NodeSequence instances to filter and combine into other NodeSequences.

For example, a custom index might be used to find all nodes that have a 'jcr:lastModified'

timestamp within some range. Presumably this index is used because it has a higher selectivity,

meaning that it will filter out more nodes and return fewer nodes than other indexes.

Other criteria that are also applied to this access query might then be applied by a filter

that processes the actual nodes' property values.

While the result of this commit is a functioning query engine that is shown to work in most

of the query-related unit and integration tests, there still are a few areas that are not complete.

Specifically:

* The new engine does not support full-text search, and currently throws an exception

* No index providers are implemented. Therefore, all queries involve "scanning" the repository.

This can be time consuming, especially for federated repositories. Consequently, all such

tests that query federated content have been disabled/ignored.

    • -17
    • +23
    ./org/modeshape/connector/git/GitConnectorTest.java
  1. … 231 more files in changeset.
MODE-2081 Changed the remaining files over to the ASL 2.0 license

  1. … 1050 more files in changeset.
MODE-2148 Added checkstyle to our build, and corrected numerous potential problems or issues in the code. Also removed lots of meaningless JavaDoc

  1. … 366 more files in changeset.
MODE-2081 Changed the license for ModeShape code to ASL 2.0.

    • -18
    • +10
    ./org/modeshape/connector/git/GitConnectorTest.java
    • -18
    • +10
    ./org/modeshape/connector/git/GitFunctionalTest.java
  1. … 558 more files in changeset.
MODE-1999 Fixed the Git connector in the cases when certain commits cannot be read from the repository.

  1. … 6 more files in changeset.
MODE-1872 - Fixed lazy workspace creation, so that it's atomic.

  1. … 7 more files in changeset.
MODE-1741 - Updated the Git connector so that indexable branches are configurable

  1. … 7 more files in changeset.
MODE-1741 - Updated Git connector so that only tree/master content is indexable.

  1. … 3 more files in changeset.
MODE-1742 - Added explicit handling for the case when the connector tries to build the diff for a commit that has more than 2 parents.

  1. … 5 more files in changeset.
MODE-1742 - Added explicit error messages for the GitConnectorTests's tag tests. Also, enabled the connectors module in the main build.

  1. … 2 more files in changeset.
MODE-1732 - Updated code after rebase on master.

  1. … 2 more files in changeset.
MODE-1732 - Implemented an mechanism for connectors to provide their own "external binaries" implementation, which aren't stored in the repository's binary store and which the DocumentTranslator "understands"

  1. … 12 more files in changeset.
MODE-1286 Added more tests for the Git connector

Added several more tests for the Git connector, and changed how the

"git:history" and "git:tree" references are being created so that they

now use the commit ID rather than the tag/branch name.

    • -6
    • +131
    ./org/modeshape/connector/git/GitConnectorTest.java
  1. … 12 more files in changeset.
MODE-1286 Added more tests for the Git connector

The Git connector is running much better now after the new tests

helped check the functionality.

This includes a change to the Connector SPI that allows the connector

to offer a direct way to find a parent's ChildReference to a particular

child node. When some connectors have *lots* of children under a single

parent, getting the path to that child can be expensive because the

repository (or session) has to find the ChildReference in the parent's

(potentially-segmented) list of ChildReferences. With lots of children,

this becomes very expensive.

Now, a new method on ChildReferences allows the LazyCachedNode to

directly ask the DocumentStore (and thus the Connector) for the child

reference. Some connectors (like the Git connector) can do this

directly.

    • -0
    • +182
    ./org/modeshape/connector/git/GitConnectorTest.java
    • -0
    • +33
    ./org/modeshape/connector/git/GitI18nTest.java
  1. … 38 more files in changeset.
MODE-1713 Corrected JavaDoc and compiler warnings.

  1. … 4 more files in changeset.
MODE-1286 Initial Git connector implementation

Added a connector implementation that accesses a Git repository. The connector was written to validate the Connector SPI, and was useful in improving the SPI (e.g., paging functionality). However, the connector has not been tested and is nearly complete, and so the connector is not yet incorporated into the build.

    • -0
    • +299
    ./org/modeshape/connector/git/GitFunctionalTest.java
  1. … 31 more files in changeset.