Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I created RFPL-2030 to make sure these changes make it into the docs

I created RFPL-2030 to make sure these changes make it into the docs

RichFaces Components 4.2.0.CR1
RichFaces Components 4.2.0.CR1
I would prefer to do not propagate cellpadding/cellspacing for EDT (revert lines 286 and 287). Additionally to remove these attributes from EDT, we can move @Attribute -s to AbstractDataTable, whi...

I would prefer to do not propagate cellpadding/cellspacing for EDT (revert lines 286 and 287).

Additionally to remove these attributes from EDT, we can move @Attribute -s to AbstractDataTable, which is rich:dataTable specific (in comparison to UIDataTableBase which is super type for rich:extendedDataTable).

https://issues.jboss.org/browse/RF-11752

https://issues.jboss.org/browse/RF-11752

Yes, the problem here was that updateModel has been called in method processUpdates which is called in the phase PROCESS_UPDATES. In the PROCESS_UPDATES phase the value is not set yet, so updateMo...

Yes, the problem here was that updateModel has been called in method processUpdates which is called in the phase PROCESS_UPDATES.

In the PROCESS_UPDATES phase the value is not set yet, so updateModel reflects old input value.

The fix is call updateModel in UPDATE_MODEL_VALUES phase.

The condition event.getPhaseId() == PhaseId.UPDATE_MODEL_VALUES checks whether the broadcast is being invoked in right phase (no model updates will be done when shortened life-cycle is applied (immediate or bypassUpdates is true).

So the idea here was to move the updateModel call from the processUpdates method to the broadcast method? No complaints, I'm just curious what this achieved.

So the idea here was to move the updateModel call from the processUpdates method to the broadcast method?
No complaints, I'm just curious what this achieved.

+1 to the delegation

+1 to the delegation

I agree that the EDT should not explicitly set the cellpadding and the cellspacing. But didn't want to introduce such a change so late in the release cycle. given that we set the value explicitly, ...

I agree that the EDT should not explicitly set the cellpadding and the cellspacing. But didn't want to introduce such a change so late in the release cycle. given that we set the value explicitly, it seems reasonable to allow the app dev to override the value.

We should create an issue to look at removing these deprecated attributes from being used in the renderer, and replaced with CSS equivalents as required.

Great - let's "clean as we go!"

Great - let's "clean as we go!"

Why does EDT need Cellpadding/spacing defined? I though EDT markup is based on Divs rather than Table.

Why does EDT need Cellpadding/spacing defined? I though EDT markup is based on Divs rather than Table.

Actually I have tried in Metamer and it seems these attributes are influencting cell under the EDT instead of cells inside EDT. Definitely bug.

Actually I have tried in Metamer and it seems these attributes are influencting cell under the EDT instead of cells inside EDT.

Definitely bug.

Both properties unused in the POM.

Both properties unused in the POM.

Note that this processEvent(SystemEvent) method has same signature as processEvent(ComponentSystemEvent) method above. Both needs to implemented in order to implement interfaces, but since Compone...

Note that this processEvent(SystemEvent) method has same signature as processEvent(ComponentSystemEvent) method above.

Both needs to implemented in order to implement interfaces, but since ComponentSystemEvent class extends SystemEvent,

it may be safer to delegate from processEvent(ComponentSystemEvent) to processEvent(SystemEvent)

and then check for identity of event (event instanceof ComponentSystemEvent), otherwise, some JDK may fail to call correct method.

RichFaces Components 4.1.0.Final
RichFaces Components 4.1.0.Final