Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
WELD-2583 INtercepted subclasses should not contain private methods with pack-private parameters, add automated test. (#1937)

(cherry picked from commit 9298f185b196bc04814a9e8e20cbc8818cec1810)

    • -0
    • +54
    ./visibility/packagePrivate/InterceptionWithPackagePrivateTest.java
    • -0
    • +32
    ./visibility/packagePrivate/pack2/Foo.java
    • -0
    • +21
    ./visibility/packagePrivate/pack2/PackPrivate.java
  1. … 2 more files in changeset.
WELD-2595 Allow for private final methods on intercepted beans.

    • -0
    • +31
    ./privateFinalMethods/BeanWithPrivateFinalMethod.java
    • -0
    • +60
    ./privateFinalMethods/BeanWithPrivateFinalMethodTest.java
    • -0
    • +38
    ./privateFinalMethods/MyInterceptor.java
    • -0
    • +34
    ./privateFinalMethods/Watches.java
  1. … 2 more files in changeset.
WELD-2583 INtercepted subclasses should not contain private methods with pack-private parameters, add automated test.

    • -0
    • +54
    ./visibility/packagePrivate/InterceptionWithPackagePrivateTest.java
    • -0
    • +32
    ./visibility/packagePrivate/pack2/Foo.java
    • -0
    • +21
    ./visibility/packagePrivate/pack2/PackPrivate.java
  1. … 2 more files in changeset.
WELD-2571 Private final observer methods can incorrectly trigger interception via self-invocation

    • -0
    • +27
    ./selfInvocation/DummyBean.java
    • -0
    • +30
    ./selfInvocation/MyBinding.java
    • -0
    • +40
    ./selfInvocation/MyInterceptor.java
    • -0
    • +30
    ./selfInvocation/MyOtherBinding.java
    • -0
    • +41
    ./selfInvocation/MyOtherInterceptor.java
    • -0
    • +99
    ./selfInvocation/SelfInvocationInterceptionTest.java
    • -0
    • +81
    ./selfInvocation/SomeBean.java
  1. … 1 more file in changeset.
WELD-2550 Revert previous approach but keep tests. Implement new approach that creates proxies based on interfaces instead of provided implementation. Add more tests to verify that proxyable interface can be used even though unproxyable implementation is provided.

    • -20
    • +44
    ./producer/InterceptionFactoryTest.java
    • -9
    • +7
    ./producer/InterfaceWithAnnotation.java
    • -29
    • +0
    ./producer/UninterestingInterface2.java
    • -0
    • +40
    ./producer/InterfaceWithAnnotationImpl.java
    • -11
    • +4
    ./producer/InterfaceWithGenericsA.java
    • -10
    • +4
    ./producer/InterfaceWithGenericsB.java
    • -0
    • +39
    ./producer/NonGenericInterfaceChainImpl.java
    • -10
    • +5
    ./producer/ProxyableInterfaceWithClassAnnotation.java
    • -11
    • +5
    ./producer/ProxyableInterfaceWithMethodAnnotation.java
    • -29
    • +0
    ./producer/UninterestingInterface1.java
  1. … 9 more files in changeset.
WELD-2533 InterceptionFactory with interface, added bunch of tests to cover more complex cases.

    • -0
    • +33
    ./producer/ImplOfInterfaceWithDefaultMethod.java
    • -0
    • +34
    ./producer/ImplWhichAlreadyHasMethodAnnotation.java
    • -0
    • +37
    ./producer/ImplWhichAlreadyHasTypeAnnotation.java
    • -14
    • +61
    ./producer/InterceptionFactoryTest.java
    • -0
    • +33
    ./producer/InterfaceWithDefaultMethod.java
    • -0
    • +40
    ./producer/SomeGenericImpl.java
    • -0
    • +31
    ./producer/SomeGenericInterface.java
    • -0
    • +42
    ./producer/SomeImpl.java
    • -0
    • +33
    ./producer/SomeInterface.java
    • -0
    • +29
    ./producer/UninterestingInterface1.java
    • -0
    • +29
    ./producer/UninterestingInterface2.java
  1. … 4 more files in changeset.
WELD-2507: More fixes

- match the whole method signature

- better handling of class hierarchies

- improved test

    • -0
    • +30
    ./inheritance/packagePrivate/SuperAbstractPackagePrivateClass.java
  1. … 1 more file in changeset.
WELD-2507: More fixes

- match the whole method signature

- better handling of class hierarchies

- improved test

    • -0
    • +30
    ./inheritance/packagePrivate/SuperAbstractPackagePrivateClass.java
  1. … 1 more file in changeset.
WELD-2507 Add generics to test, fix factory to account for valid bridge methods in this case.

  1. … 1 more file in changeset.
WELD-2507 Add generics to test, fix factory to account for valid bridge methods in this case.

  1. … 1 more file in changeset.
WELD-2507 Change test package, use Reflections util class.

  1. … 6 more files in changeset.
WELD-2507 Change test package, use Reflections util class.

  1. … 6 more files in changeset.
WELD-2514 Add automated test, propose a fix.

    • -0
    • +32
    ./generic/overriden/AbstractService.java
    • -0
    • +35
    ./generic/overriden/ActualInterceptedService.java
    • -0
    • +25
    ./generic/overriden/Foo.java
    • -0
    • +58
    ./generic/overriden/GenericClassOverridenMethodTest.java
    • -0
    • +25
    ./generic/overriden/SuperFoo.java
    • -0
    • +35
    ./generic/overriden/TestBinding.java
    • -0
    • +41
    ./generic/overriden/TestInterceptor.java
  1. … 1 more file in changeset.
WELD-2514 Add automated test, propose a fix.

    • -0
    • +32
    ./generic/overriden/AbstractService.java
    • -0
    • +35
    ./generic/overriden/ActualInterceptedService.java
    • -0
    • +25
    ./generic/overriden/Foo.java
    • -0
    • +58
    ./generic/overriden/GenericClassOverridenMethodTest.java
    • -0
    • +25
    ./generic/overriden/SuperFoo.java
    • -0
    • +35
    ./generic/overriden/TestBinding.java
    • -0
    • +41
    ./generic/overriden/TestInterceptor.java
  1. … 1 more file in changeset.
WELD-2470 Match bridge methods based on signature only when compared to abstract method.

    • -0
    • +28
    ./abstractClass/proxy/Vehicle.java
  1. … 1 more file in changeset.
WELD-2470 Match bridge methods based on signature only when compared to abstract method.

    • -0
    • +28
    ./abstractClass/proxy/Vehicle.java
  1. … 1 more file in changeset.
WELD-2470 Fix InterceptedSubclassFactory, add reproducer.

    • -0
    • +30
    ./abstractClass/proxy/Car.java
    • -0
    • +34
    ./abstractClass/proxy/CarServiceman.java
    • -0
    • +53
    ./abstractClass/proxy/InterceptedGenericBeanFromAbstractClassTest.java
    • -0
    • +36
    ./abstractClass/proxy/InterruptWork.java
    • -0
    • +26
    ./abstractClass/proxy/Serviceman.java
    • -0
    • +40
    ./abstractClass/proxy/VeryImportantPhoneCall.java
  1. … 1 more file in changeset.
WELD-2470 Fix InterceptedSubclassFactory, add reproducer.

    • -0
    • +30
    ./abstractClass/proxy/Car.java
    • -0
    • +34
    ./abstractClass/proxy/CarServiceman.java
    • -0
    • +53
    ./abstractClass/proxy/InterceptedGenericBeanFromAbstractClassTest.java
    • -0
    • +36
    ./abstractClass/proxy/InterruptWork.java
    • -0
    • +26
    ./abstractClass/proxy/Serviceman.java
    • -0
    • +40
    ./abstractClass/proxy/VeryImportantPhoneCall.java
  1. … 1 more file in changeset.
WELD-2436 Move interceptors binding key to API.

    • -2
    • +0
    ./context/bindings/InvocationContextInterceptorBindingsTest.java
  1. … 4 more files in changeset.
WELD-2436 Move interceptors binding key to API.

    • -2
    • +0
    ./context/bindings/InvocationContextInterceptorBindingsTest.java
  1. … 4 more files in changeset.
WELD-2433 Backport WeldInvocationContext feature.

    • -3
    • +3
    ./aroundConstruct/basic/AbstractInterceptor.java
    • -0
    • +60
    ./context/bindings/AroundConstructInterceptor.java
    • -0
    • +64
    ./context/bindings/AroundInvokeInterceptor.java
    • -0
    • +37
    ./context/bindings/BarBinding.java
    • -0
    • +37
    ./context/bindings/BazBinding.java
    • -0
    • +40
    ./context/bindings/FooBinding.java
    • -0
    • +133
    ./context/bindings/InvocationContextInterceptorBindingsTest.java
    • -0
    • +60
    ./context/bindings/PostConstructInterceptor.java
    • -0
    • +60
    ./context/bindings/PreDestroyInterceptor.java
    • -0
    • +33
    ./context/bindings/SimpleBean.java
  1. … 13 more files in changeset.
WELD-2414 Fix InterceptedSubclassFactory

- also expand InterceptorBridgeMethodTest

    • -0
    • +29
    ./bridgemethods/hierarchy/Base.java
    • -1
    • +18
    ./bridgemethods/hierarchy/Child.java
    • -11
    • +118
    ./bridgemethods/hierarchy/InterceptorBridgeMethodTest.java
    • -0
    • +44
    ./bridgemethods/hierarchy/Juicy.java
    • -2
    • +34
    ./bridgemethods/hierarchy/Parent.java
    • -0
    • +25
    ./bridgemethods/hierarchy/SpecialBase.java
    • -0
    • +35
    ./bridgemethods/hierarchy/SpecialChild.java
    • -0
    • +32
    ./bridgemethods/hierarchy/SpecialParent.java
  1. … 1 more file in changeset.
WELD-2414 Fix InterceptedSubclassFactory

- also expand InterceptorBridgeMethodTest

    • -0
    • +35
    ./bridgemethods/hierarchy/Base.java
    • -1
    • +18
    ./bridgemethods/hierarchy/Child.java
    • -11
    • +134
    ./bridgemethods/hierarchy/InterceptorBridgeMethodTest.java
    • -0
    • +44
    ./bridgemethods/hierarchy/Juicy.java
    • -2
    • +39
    ./bridgemethods/hierarchy/Parent.java
    • -0
    • +25
    ./bridgemethods/hierarchy/SpecialBase.java
    • -0
    • +35
    ./bridgemethods/hierarchy/SpecialChild.java
    • -0
    • +32
    ./bridgemethods/hierarchy/SpecialParent.java
  1. … 1 more file in changeset.
WELD-2405 Do not optimize self invocation for default methods

- based on https://github.com/weld/core/pull/1703 from @hypnoce

- redundant test removed

- we must obtain the current stack first otherwise

DecoratedInteraceWithDefaultMethodTest fails

    • -3
    • +0
    ./defaultmethod/InterfaceDefaultMethodInterceptedTest.java
  1. … 2 more files in changeset.
WELD-2407 fix selfinvocation of non-intercepted default method and expand SelfInvocationTest.

  1. … 20 more files in changeset.
WELD-2407 fix selfinvocation of non-intercepted default method and expand SelfInvocationTest.

    • -0
    • +0
    ./defaultmethod/InterfaceDefaultMethodInterceptedTest.java
    • -0
    • +0
    ./defaultmethod/MissileInterceptor.java
  1. … 10 more files in changeset.
InterceptionFactory - add a test for abstract class.

    • -0
    • +5
    ./producer/InterceptionFactoryTest.java
WELD-2335 InterceptionFactory used on interface causes NPE add a test on type to have it fails gracefully

    • -0
    • +21
    ./producer/InterceptionFactoryTest.java
  1. … 2 more files in changeset.
WELD-2310 Add test

    • -1
    • +7
    ./producer/InterceptionFactoryTest.java
WELD-2305 Fix JDK 9 package name clash between Weld API and Core.

    • -1
    • +1
    ./cache/CachedInterceptionDecorationContextTest.java
  1. … 144 more files in changeset.