Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
WELD-2298 Replace deprecated junit.framework.Assert with org.junit.Assert.

  1. … 72 more files in changeset.
WELD-2298 Replace deprecated junit.framework.Assert with org.junit.Assert.

  1. … 87 more files in changeset.
Test sanity check: Rename and comment empty test methods, remove unnecessary TODOs. Renamed tests classes to follow the *Test pattern. Enhanced several tests.

    • -2
    • +3
    ./AroundInvokeInterceptorWithInvalidParameterCountTest.java
    • -2
    • +3
    ./AroundInvokeInterceptorWithInvalidParameterTypeTest.java
    • -2
    • +3
    ./AroundInvokeInterceptorWithInvalidReturnTypeTest.java
    • -2
    • +3
    ./PostConstructInterceptorWithInvalidParameterCountTest.java
    • -2
    • +3
    ./PostConstructInterceptorWithInvalidParameterTypeTest.java
    • -2
    • +3
    ./PostConstructInterceptorWithInvalidReturnTypeTest.java
    • -2
    • +4
    ./TargetClassWithAroundConstructTest.java
    • -2
    • +3
    ./TargetClassWithAroundInvokeWithInvalidParameterCountTest.java
    • -2
    • +3
    ./TargetClassWithAroundInvokeWithInvalidParameterTypeTest.java
    • -2
    • +3
    ./TargetClassWithAroundInvokeWithInvalidReturnTypeTest.java
  1. … 125 more files in changeset.
Test sanity check: Rename and comment empty test methods, remove unnecessary TODOs. Renamed tests classes to follow the *Test pattern. Enhanced several tests.

    • -2
    • +3
    ./AroundInvokeInterceptorWithInvalidParameterCountTest.java
    • -2
    • +3
    ./AroundInvokeInterceptorWithInvalidParameterTypeTest.java
    • -2
    • +3
    ./AroundInvokeInterceptorWithInvalidReturnTypeTest.java
    • -2
    • +3
    ./PostConstructInterceptorWithInvalidParameterCountTest.java
    • -2
    • +3
    ./PostConstructInterceptorWithInvalidParameterTypeTest.java
    • -2
    • +3
    ./PostConstructInterceptorWithInvalidReturnTypeTest.java
    • -2
    • +4
    ./TargetClassWithAroundConstructTest.java
    • -2
    • +3
    ./TargetClassWithAroundInvokeWithInvalidParameterCountTest.java
    • -2
    • +3
    ./TargetClassWithAroundInvokeWithInvalidParameterTypeTest.java
    • -2
    • +3
    ./TargetClassWithAroundInvokeWithInvalidReturnTypeTest.java
  1. … 122 more files in changeset.
WELD-1912 change test archives name with hash of test class FQCN.

    • -1
    • +2
    ./AroundConstructInterceptorWithObjectReturnTypeTest.java
    • -1
    • +2
    ./AroundConstructInterceptorWithVoidReturnTypeTest.java
    • -1
    • +2
    ./AroundInvokeInterceptorWithInvalidParameterCountTest.java
    • -1
    • +2
    ./AroundInvokeInterceptorWithInvalidParameterTypeTest.java
    • -1
    • +2
    ./AroundInvokeInterceptorWithInvalidReturnTypeTest.java
    • -1
    • +2
    ./AroundInvokeInterceptorWithValidSignatureTest.java
    • -1
    • +2
    ./PostConstructInterceptorWithInvalidParameterCountTest.java
    • -1
    • +2
    ./PostConstructInterceptorWithInvalidParameterTypeTest.java
    • -1
    • +2
    ./PostConstructInterceptorWithInvalidReturnTypeTest.java
    • -1
    • +2
    ./PostConstructInterceptorWithObjectReturnTypeTest.java
    • -1
    • +2
    ./PostConstructInterceptorWithVoidReturnTypeTest.java
    • -1
    • +2
    ./PostConstructInterceptorWithoutParametersTest.java
    • -1
    • +2
    ./TargetClassWithAroundConstructTest.java
    • -1
    • +2
    ./TargetClassWithAroundInvokeWithInvalidParameterCountTest.java
    • -1
    • +2
    ./TargetClassWithAroundInvokeWithInvalidParameterTypeTest.java
  1. … 554 more files in changeset.
WELD-1912 change test archives name with hash of test class FQCN.

    • -1
    • +2
    ./AroundConstructInterceptorWithObjectReturnTypeTest.java
    • -1
    • +2
    ./AroundConstructInterceptorWithVoidReturnTypeTest.java
    • -1
    • +2
    ./AroundInvokeInterceptorWithInvalidParameterCountTest.java
    • -1
    • +2
    ./AroundInvokeInterceptorWithInvalidParameterTypeTest.java
    • -1
    • +2
    ./AroundInvokeInterceptorWithInvalidReturnTypeTest.java
    • -1
    • +2
    ./AroundInvokeInterceptorWithValidSignatureTest.java
    • -1
    • +2
    ./PostConstructInterceptorWithInvalidParameterCountTest.java
    • -1
    • +2
    ./PostConstructInterceptorWithInvalidParameterTypeTest.java
    • -1
    • +2
    ./PostConstructInterceptorWithInvalidReturnTypeTest.java
    • -1
    • +2
    ./PostConstructInterceptorWithObjectReturnTypeTest.java
    • -1
    • +2
    ./PostConstructInterceptorWithVoidReturnTypeTest.java
    • -1
    • +2
    ./PostConstructInterceptorWithoutParametersTest.java
    • -1
    • +2
    ./TargetClassWithAroundConstructTest.java
    • -1
    • +2
    ./TargetClassWithAroundInvokeWithInvalidParameterCountTest.java
    • -1
    • +2
    ./TargetClassWithAroundInvokeWithInvalidParameterTypeTest.java
  1. … 543 more files in changeset.
Fix intermittend failure in unit tests

    • -2
    • +2
    ./AroundConstructInterceptorWithObjectReturnTypeTest.java
    • -2
    • +2
    ./AroundConstructInterceptorWithVoidReturnTypeTest.java
    • -1
    • +1
    ./AroundInvokeInterceptorWithInvalidParameterCountTest.java
    • -1
    • +1
    ./AroundInvokeInterceptorWithInvalidParameterTypeTest.java
    • -1
    • +1
    ./AroundInvokeInterceptorWithInvalidReturnTypeTest.java
    • -3
    • +3
    ./AroundInvokeInterceptorWithValidSignatureTest.java
    • -1
    • +1
    ./PostConstructInterceptorWithInvalidParameterCountTest.java
    • -1
    • +1
    ./PostConstructInterceptorWithInvalidParameterTypeTest.java
    • -1
    • +1
    ./PostConstructInterceptorWithInvalidReturnTypeTest.java
    • -2
    • +2
    ./PostConstructInterceptorWithObjectReturnTypeTest.java
    • -2
    • +2
    ./PostConstructInterceptorWithVoidReturnTypeTest.java
    • -2
    • +2
    ./PostConstructInterceptorWithoutParametersTest.java
Fix intermittend failure in unit tests

    • -2
    • +2
    ./AroundConstructInterceptorWithObjectReturnTypeTest.java
    • -2
    • +2
    ./AroundConstructInterceptorWithVoidReturnTypeTest.java
    • -1
    • +1
    ./AroundInvokeInterceptorWithInvalidParameterCountTest.java
    • -1
    • +1
    ./AroundInvokeInterceptorWithInvalidParameterTypeTest.java
    • -1
    • +1
    ./AroundInvokeInterceptorWithInvalidReturnTypeTest.java
    • -3
    • +3
    ./AroundInvokeInterceptorWithValidSignatureTest.java
    • -1
    • +1
    ./PostConstructInterceptorWithInvalidParameterCountTest.java
    • -1
    • +1
    ./PostConstructInterceptorWithInvalidParameterTypeTest.java
    • -1
    • +1
    ./PostConstructInterceptorWithInvalidReturnTypeTest.java
    • -2
    • +2
    ./PostConstructInterceptorWithObjectReturnTypeTest.java
    • -2
    • +2
    ./PostConstructInterceptorWithVoidReturnTypeTest.java
    • -2
    • +2
    ./PostConstructInterceptorWithoutParametersTest.java
WELD-1449 Update integration tests to expect a specific exception during deployment instead of Exception.class

    • -1
    • +2
    ./AroundInvokeInterceptorWithInvalidParameterCountTest.java
    • -1
    • +2
    ./AroundInvokeInterceptorWithInvalidParameterTypeTest.java
    • -1
    • +2
    ./AroundInvokeInterceptorWithInvalidReturnTypeTest.java
    • -1
    • +3
    ./PostConstructInterceptorWithInvalidParameterCountTest.java
    • -1
    • +3
    ./PostConstructInterceptorWithInvalidParameterTypeTest.java
    • -1
    • +3
    ./PostConstructInterceptorWithInvalidReturnTypeTest.java
    • -1
    • +3
    ./TargetClassWithAroundConstructTest.java
    • -1
    • +2
    ./TargetClassWithAroundInvokeWithInvalidParameterCountTest.java
    • -1
    • +2
    ./TargetClassWithAroundInvokeWithInvalidParameterTypeTest.java
    • -1
    • +2
    ./TargetClassWithAroundInvokeWithInvalidReturnTypeTest.java
  1. … 56 more files in changeset.
WELD-1414 Relax validation of lifecycle interceptor methods on target classes

    • -0
    • +1
    ./TargetClassWithPostConstructWithInvalidReturnType.java
    • -3
    • +7
    ./TargetClassWithPostConstructWithInvalidReturnTypeTest.java
  1. … 1 more file in changeset.
WELD-1399 Relax validation for AroundConstruct callbacks on the target class

    • -0
    • +2
    ./TargetClassWithAroundConstructTest.java
  1. … 1 more file in changeset.
WELD-1348 Relax requirements for interceptor method signatures - don't throw DefinitionException when we can't distinguish between a target class and an interceptor

    • -0
    • +62
    ./PostConstructInterceptorWithoutParametersTest.java
    • -0
    • +3
    ./TargetClassWithPostConstructWithInvalidParameterCount.java
    • -5
    • +10
    ./TargetClassWithPostConstructWithInvalidParameterCountTest.java
  1. … 2 more files in changeset.
WELD-1348 Relax requirements for interceptor method signatures - log warning if lifecycle callback declares throwing checked exceptions

    • -2
    • +2
    ./AroundConstructInterceptorWithObjectReturnTypeTest.java
    • -2
    • +2
    ./AroundConstructInterceptorWithVoidReturnTypeTest.java
    • -2
    • +2
    ./AroundInvokeInterceptorWithValidSignatureTest.java
    • -2
    • +2
    ./PostConstructInterceptorWithObjectReturnTypeTest.java
    • -2
    • +2
    ./PostConstructInterceptorWithVoidReturnTypeTest.java
    • -0
    • +19
    ./TargetClassWithPostConstructWithThrowsClause.java
    • -0
    • +47
    ./TargetClassWithPostConstructWithThrowsClauseTest.java
    • -2
    • +2
    ./TargetClassWithValidPostConstructTest.java
  1. … 4 more files in changeset.
WELD-1348 Relax requirements for interceptor method signatures - throw DefinitionException instead of logging a warning

    • -0
    • +38
    ./AbstractSignatureTest.java
    • -40
    • +0
    ./AroundConstructInterceptorWithObjectReturnType.java
    • -0
    • +64
    ./AroundConstructInterceptorWithObjectReturnTypeTest.java
    • -0
    • +63
    ./AroundConstructInterceptorWithVoidReturnTypeTest.java
    • -0
    • +59
    ./AroundInvokeInterceptorWithInvalidParameterCountTest.java
    • -0
    • +58
    ./AroundInvokeInterceptorWithInvalidParameterTypeTest.java
    • -40
    • +0
    ./AroundInvokeInterceptorWithInvalidReturnType.java
    • -0
    • +59
    ./AroundInvokeInterceptorWithInvalidReturnTypeTest.java
    • -39
    • +0
    ./AroundInvokeInterceptorWithValidSignature.java
    • -0
    • +64
    ./AroundInvokeInterceptorWithValidSignatureTest.java
    • -40
    • +0
    ./PostConstructInterceptorWithInvalidParameterCount.java
  1. … 25 more files in changeset.
WELD-1348 Relax requirements for interceptor method signatures - additional tests

    • -0
    • +39
    ./TargetClassWithAroundConstruct.java
    • -0
    • +39
    ./TargetClassWithAroundInvokeWithInvalidParameterCount.java
    • -0
    • +38
    ./TargetClassWithAroundInvokeWithInvalidParameterType.java
    • -0
    • +39
    ./TargetClassWithAroundInvokeWithInvalidReturnType.java
WELD-1348 Relax requirements for interceptor method signatures WELD-1357 @AroundConstruct only works for void methods

    • -0
    • +40
    ./AroundConstructInterceptorWithObjectReturnType.java
    • -0
    • +40
    ./AroundConstructInterceptorWithVoidReturnType.java
    • -0
    • +39
    ./AroundInvokeInterceptorWithInvalidParameterCount.java
    • -0
    • +38
    ./AroundInvokeInterceptorWithInvalidParameterType.java
    • -0
    • +40
    ./AroundInvokeInterceptorWithInvalidReturnType.java
    • -0
    • +39
    ./AroundInvokeInterceptorWithValidSignature.java
    • -0
    • +30
    ./InterceptedBean.java
    • -0
    • +198
    ./InterceptorSignatureTest.java
    • -0
    • +40
    ./PostConstructInterceptorWithInvalidParameterCount.java
    • -0
    • +38
    ./PostConstructInterceptorWithInvalidParameterType.java
    • -0
    • +40
    ./PostConstructInterceptorWithInvalidReturnType.java
    • -0
    • +39
    ./PostConstructInterceptorWithObjectReturnType.java
    • -0
    • +46
    ./PostConstructInterceptorWithVoidReturnType.java
  1. … 7 more files in changeset.