Clone Tools
  • last updated a few minutes ago
Constraints: committers
Constraints: files
Constraints: dates
JIBDE-12860 - JAX-RS validation problems are not linked

Fixed the problem where some markers would not be removed from the resource to be validated between

two validation calls, which meant that duplicate markers for the same problem would exist on each


Also refactored the search/element retrieval: the JaxrsElementIndexationDelegate now not only

deals with the Lucene indexation and searches, but also uses the metamodel to return List of

JAX-RS elements, Endpoints or workspace Resources.

Renamed some marker deletion/undexing methods to use the "remove" verb (eg: "removeMarker()") and be consistent with the

existing "remove()" methods that remove the elements themselves.

Added JUnit tests to covers the fixes.

This patch also fixes:

- JBIDE-15662: Warning Multiple JAX-RS Activators doesn't disappear

- JBIDE-15664: Application path configured in web.xml causes warning

  1. … 24 more files in changeset.
JBIDE-15699 - For JBIDE 4.1.1.Beta1: Code Freeze + Branch [Webservices]

Bumping parent pom to 4.1.1.Beta1-SNAPSHOT, which also resolves a

problem of missing dependency on org.jboss.tool.tests

JBIDE-15428 - No JAX-RS problems when importing a project that contains HTTPMethod annotation without @Target and @Retention

Skipping the Java ElementChangeEvents when the Java Project is not open yet. This avoids race conditions during import.

Bonus: import seem to be twice as fast as before ;-)

Other changes:

- Move the call the JaxrsMetamodel#setBuildStatus() to finally{} blocks of JaxrsMetamodel#processXXX() methods

- Adjusted some javadoc, log messages and catch() blocks (avoiding to catch Exception or Throwable)

- Added a ReadWriteLock on all public methods of the JaxrsMetamodel to avoid concurrent access to the metamodel by different threads, for example if an async build

is still running and the validation is started. This avoids the following type of error:


!ENTRY org.jboss.tools.common 4 0 2013-10-09 18:17:54.307




at org.jboss.tools.common.validation.ValidatorManager.validateInJob(ValidatorManager.java:101)

at org.eclipse.wst.validation.internal.operations.ValidatorJob.run(ValidatorJob.java:78)

at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)

Caused by: java.util.ConcurrentModificationException

at java.util.HashMap$HashIterator.nextEntry(HashMap.java:793)

at java.util.HashMap$ValueIterator.next(HashMap.java:822)

at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsMetamodelValidator.validateAll(JaxrsMetamodelValidator.java:268)

at org.jboss.tools.ws.jaxrs.core.internal.metamodel.validation.JaxrsMetamodelValidator.validate(JaxrsMetamodelValidator.java:153)

at org.jboss.tools.common.validation.ValidatorManager.validate(ValidatorManager.java:117)

at org.jboss.tools.common.validation.ValidatorManager.validateInJob(ValidatorManager.java:81)

... 2 more


- added some tests to increase code coverage

  1. … 7 more files in changeset.
JBIDE-15505 - Exception in JAXRS at startup

Added a check for null metamodel before calling the JaxrsMetamodel#removeListener() method

JBIDE-15599 - Changes on a subresource locator fields are not propagated to the JAX-RS Explorer

Registered the URI Mappings Content Provider (in the UI) when the JAX-RS Web Services node is

expanded. This avoids the case where in some circumstances, the JAX-RS metamodel would have no

listener to notify when JAX-RS endpoints changed.

Also edited the log messages for sake of readability

DE-15542 For JBIDE 4.1.1.Alpha2: Code Freeze + Branch [Webservices]

switch to 4.1.1.Alpha2-SNAPSHOT parent/pom.xml

JBIDE-15304 - NullPointerExceptions in JAX-RS doesn't report what project is affected

Printing the current java element name and parent project in the existing call to the logger

if the element is known.

JBIDE-15508 - Incorrect problem marker when refactoring a custom Qualifier

Initial problem was that *any* annotation would be taken as a JAX-RS HTTP Method,

which was über wrong.

Added tests cases to verify.

JBIDE-12860 - JAX-RS validation problems are not linked

Added a custom JAXRS_PROBLEM_TYPE attribute in JAX-RS markers.

Those JAX-RS Problem markers are now indexed with Lucene.

Thus, it becomes possible to look for resource that have the same

error as a given resource, even if this later one has been deleted.

(eg: looking for duplicate application problem after an application

has been removed).

When a JAX-RS Element is removed, its associated JAX-RS Markers are

removed from the index *during the validation phase* (the markers

still exist and are still indexed until the validation is performed).

Added some JUnit tests to verify the good behaviour againts the case

where a project has 2 JAX-RS application then one is removed.

  1. … 9 more files in changeset.
JBIDE-15402 - Doubled warnings Multiple JAX-RS Activators

Removed the duplicate validation at both the JaxrsApplications level and kept the one

at the JaxrsMetamodel level.

JBIDE-15451 use parent pom 4.1.1.Alpha1-SNAPSHOT not 4.1.0.Final-SNAPSHOT

JBIDE-15436 - Bump Webservices to version 1.5.1

    • -1
    • +1
  1. … 18 more files in changeset.
[JBIDE-13795] Incorrect URL for JBoss Jira on readmes

JBIDE-15314 - fixes for SOAPAction NPE

JBIDE-15307 - Fix for SOAP 1.2 detection when testing JAX-WS services

Bump parent pom version in root pom to 4.1.0.Final-SNAPSHOT

JBIDE-15175 - Fix for one more validation issue with Simple Web Service wizard

JBIDE-15118 - Fixing issue with RS & WS wizard validation

JBIDE-15084 - Failed to build JAX-RS Metamodel when re-opening a closed project

Catching IllegalArgumentException when JDT fails to retrieve return type from MethodBinding

Added 2 JUnit tests to verify that build does not fail

In case of build failure, the JAX-RS metamodel has a build status set to ERROR, otherwise it is set to OK. This

state can be asserted from the JUnit tests.

JBIDE-15069 - Issue with JAX-RS testing

JBIDE-15067 - BadLocation Exception when validating a project with JAX-RS support

Couldn't reproduce the issue, but meanwhile, added a JUnit test to cover the block of code

where the issue appeared initially.

JBIDE-15039 - JAX-RS Problem decorator not shown on the Project Explorer node

Main refactoring/changes in this PR consist in:

- compare the problem level of each JAX-RS element before vs after the validation, and

in case of change, notify the metamodel. The metamodel will look for all affected Endpoints and

send 'problem level change' notification to the listeners (here, the UI). In turn, the UI will *update*

the associated node (update -> no refresh for sub nodes) to get a proper image decorator.

- same logix with the metamodel itself, except that the public problem level includes the problem level of the

JAX-RS elements, which means that the 'JAX-RS Web Services' node now reflects the whole Metamodel and thus, displays the

global problem level.

This new UI refresh strategy also reduces the number of times refresh occurred (there's now a single refresh per affected element, even

if this element has multiple problems).

- also fixed a problem where the UI listener would only be registered once the "JAX-RS Web Services" node was expended

  1. … 14 more files in changeset.
JBIDE-15039 - JAX-RS Problem decorator not shown on the Project Explorer node

Adding notification each time a JAX-RS element is validated so that it's UI element gets refreshed

Also 'update' the parent node element to show/hide the problem decorator

Merge pull request #63 from bfitzpat/JBIDE-15051

JBIDE-15051 - Updating parent pom for CR1

JBIDE-15051 - Updating parent pom for CR1

JBIDE-15031 - JAX-RS Metamodel builder called too many times during project build

Do not launch a build job when the metamodel already exist and is being initialized.

remove .project folder in root that prevents easy import in eclipse

JBIDE-12690 No JAX-RS problems when importing a project that contains errors

Preventing some NPE

Taking care of having the metamodel build command inserted *before* the validation command

Keeping the validation context in the JAX-RS Metamodel (via the ValidationContextTree) to hold

the context between validation calls.

Merge pull request #59 from bfitzpat/JBIDE-14988

JBIDE-14988 - Force usage of JaxB 2.2 on master

JBIDE-14988 - Force usage of JaxB 2.2 on master