Clone
 

lance leverich <lance.leverich@gmail.com> in Drools

RHDM-961 Random test failures (#2352)

The error message indicated that sometimes the format function being

called by an accumulate, in the rule "processDerivedField_MapValues",

was being called with a "type" parameter that was not a String. I

updated the function's signature to take a generic Object for the "type"

parameter, and then modified the function to check to see if the

parameter was indeed a String. If it is a String then the function works

as it was originally coded; otherwise it returns the passed in "val"

parameter, just as though the "type" parameter was null.

RHPAM-2107 ApplyPmmlModelCommand now accepts external objects as input (#2343)

    • -1
    • +12
    /drools-core/src/build/revapi-config.json
RHPAM 1815 7.18.x (#2295)

* RHPAM-1815 Unit tests fail for drools-scorecards

Declared types in the rules that are used to generate the rules from

PMML cause issues in Windows.

* Removed commented out declare statements

RHPAM-1815 Renamed the file ScoringStrategiesTest.java... (#2290)

* RHPAM-1815 Unit tests fail for drools-scorecards

Declared types in the rules that are used to generate the rules from

PMML cause issues in Windows.

* Removed commented out declare statements

RHPAM-1900 Fixes for XStream marshall/unmarshall using PMML structures (#2273) (#2283)

    • -0
    • +10
    /drools-core/src/build/revapi-config.json
RHPAM-1900 Fixes for XStream marshall/unmarshall using PMML structures (#2273)

    • -0
    • +10
    /drools-core/src/build/revapi-config.json
RHPAM-1875 Fixes for JSON marshalling/unmarshalling of PMML (#2258)

Moved all the DRLs to the proper directory for the package name (#2252)

Moved the DRL files from the model-based subdirectory to the package

name directory org/kie/pmml/pmml_4_2/compiler

  1. … 3 more files in changeset.
RHDM-766 / DROOLS-3404 (#2202)

* DROOLS-3404 Finish removing 'declare' statements from generated rules

@Ignored tests in guided scorecards that don't work due to empty field names

RHDM-766 Implementing REST API/kie-server support for PMML

Requested updates

Made requested change to the PMML4Compiler

* Added back in tests that had been @Ignored

Added back tests that had been @Ignored. This required updating the

Helper so that it produced scorecard models that had valid output field

definitions.

    • -1
    • +16
    /drools-core/src/build/revapi-config.json
  1. … 32 more files in changeset.
RHPAM-1509 Mining model modelChain mode does not compile (#2069)

* Fixed an error, in the PMML4Compiler, that was caused when instead of creating a copy of a DataField object the object was being updated

* Fixed problems in the test data...

- Models need to have a modelName attribute

- A target element, in a MiningSchema, must have a corresponding DataField defined

RHPAM-1509 Mining model modelChain mode does not compile (#2068)

* Fixed an error, in the PMML4Compiler, that was caused when instead of creating a copy of a DataField object the object was being updated

* Fixed problems in the test data...

- Models need to have a modelName attribute

- A target element, in a MiningSchema, must have a corresponding DataField defined

RHPAM-1492_ 7_11 (#2063)

* RHPAM-1492 Surrogate operator does not work correctly in decision trees

* Fixed problems in the PredicateRuleProducer classes, where the generated constraints

were not correctly taking into account compound predicates

* Changed treeCompiler.drl to use constraints created by PredicateRuleProducer classes

instead of using the compileConstraints query in common.drl

* Added a method to PMML4Helper (utils within treeCompiler.drl) to retrieve the

constraints/predicate for a node

* Added fix that uses new ArrayList<>() in place of Collections.emptyList()

  1. … 3 more files in changeset.
RHPAM-1492 Surrogate operator does not work correctly in decision trees (#2062)

* Fixed problems in the PredicateRuleProducer classes, where the generated constraints

were not correctly taking into account compound predicates

* Changed treeCompiler.drl to use constraints created by PredicateRuleProducer classes

instead of using the compileConstraints query in common.drl

* Added a method to PMML4Helper (utils within treeCompiler.drl) to retrieve the

constraints/predicate for a node

Added fix that uses new ArrayList<>() in place of Collections.emptyList()

  1. … 3 more files in changeset.
RHPAM-1500 PMML compilation problem with weightedAverage mining operator (#2052)

* Removed @Ignore from MiningModelWeightedAverageTest

* Added a method to get the Double value from the MiningSegmentWeight

* Fixed errors in the weightedAvg.mvel including

- making sure that the correct PMML4Result is used for setting a MiningSegmentWeight

- making sure that the correct PMML4Result gets the weighted average for its target field

- making sure that the all possible SegmentExecutions are inserted prior to starting any SegmentExecution

- updating the "Check Segment Can Fire" rules to update the proper SegmentExecution, instead of inserting a new one

* Fixed tests in MiningmodelTest that were broken by the above fixes

RHPAM-1500 PMML compilation problem with weightedAverage mining operator (#2052)

* Removed @Ignore from MiningModelWeightedAverageTest

* Added a method to get the Double value from the MiningSegmentWeight

* Fixed errors in the weightedAvg.mvel including

- making sure that the correct PMML4Result is used for setting a MiningSegmentWeight

- making sure that the correct PMML4Result gets the weighted average for its target field

- making sure that the all possible SegmentExecutions are inserted prior to starting any SegmentExecution

- updating the "Check Segment Can Fire" rules to update the proper SegmentExecution, instead of inserting a new one

* Fixed tests in MiningmodelTest that were broken by the above fixes

(cherry picked from commit 8eb1aae0dcbdf2b0f36e3ccbbc39e5291bf06c69)

DROOLS-2908 Guided Score Card (#2035)

* Fixed/updated unit tests and verified that scorecards are compiling and executing

* Added ability to use external types when using the PMML4ExecutionHelper

DROOLS-2884 Guided Score Card build fails (#2034)

* Fixed issue that prevented build/compile when the guided scorecard referenced a type without a fully qualified name

* Updated tests to include testing for external types referenced without fully qualified names

DROOLS-2875 Problem compiling PMML when multiple output fields are present (#2016)

* scorecardOutputGeneration.drlt - Updated rule names to add the target field for situations where there are

multiple output fields defined.

* regParams.drlt - Changed the insertion of RegTable objects to be insert instead of insertLogical

* Updated test files to include multiple fields tagged as output

* Fixed Miningmodel.java so that the getMiningFields method would also return any fields that were used by

sub-models. This removes a limitation that previously existed where the all fields that were in a sub-model's

mining schema had to be included in the mining models mining schema.

Removed all references to PMML from drools-compiler module (#1977)

Created PMMLAssemblerService to compile packages that contain PMML resources

    • -0
    • +132
    /kie-pmml/src/main/java/org/kie/pmml/pmml_4_2/PMMLResource.java
[DROOLS-2752] - Fix for issue that caused a StringIndexOutOfBounds exception (#1988)

when using external types, without a package name.

RHDM-594 Remove drools-pmml dependency (#1922)

* Helper classes to streamline the creation of the elements necessary for submitting

a request to a PMML rule unit.

Updated tests to make use of the new helper classes

* * Removing dependencies on drools-pmml

* Changed the package for classes generated from the PMML schema and updated references to the package

* Added new methods for retrieving a KieBase, or a string that contains the PMML generated from a spreadsheet,

from the ScoreCardProvider and ScoreCardFactory classes

* * Making drools-scorecards work with kie-pmml

* Removing reliance by guided scorecards and adding in support for external beans

  1. … 64 more files in changeset.
Moved PMML generation of Java classes to KnowledgeBuilderImpl and (#1883)

removed it from KieBuilderImpl.

Moved PMML generation of Java classes to KnowledgeBuilderImpl and (#1884)

removed it from KieBuilderImpl.

RHDM-341_7.7.x *Removed @Ignore from DecisionTreeTest methods that were no longer in error (#1892)

RHDM-341 *Removed @Ignore from DecisionTreeTest methods that were no longer in error (#1891)

RHDM-522_7.7.x Add sum mode for MiningModel (#1859)

* Added new template for generating the segmentation rules, when the multipleModelMethod is "sum"

* Added new test that uses a model with the segmentation's multipleModelMethod set to "sum"

RHDM-522 Add sum mode for MiningModel (#1858)

* Added new template for generating the segmentation rules, when the multipleModelMethod is "sum"

* Added new test that uses a model with the segmentation's multipleModelMethod set to "sum"

RHDM-515 Add weighted average mode to MiningModel (#1855)

* Added functionality to retrieve the name of a segment's target field

* Added a new class MiningSegmentWeight that is used during the application of a model (as opposed to being used during rule generation)

* Updated the MiningSegmentation to generate rules for weighted average mode

* Added template for weighted average mode rules

* Added test to MiningmodelTest for weighted average mode

* Added a test PMML model

RHDM-515 Add weighted average mode to MiningModel (#1854)

* Added functionality to retrieve the name of a segment's target field

* Added a new class MiningSegmentWeight that is used during the application of a model (as opposed to being used during rule generation)

* Updated the MiningSegmentation to generate rules for weighted average mode

* Added template for weighted average mode rules

* Added test to MiningmodelTest for weighted average mode

* Added a test PMML model

RHBA-626 Tree model does not work on models expecting numeric output (#1847) (#1852)

* Updated the process that generates the Java classes to now include a TreeNode so that the node's outcome is of the type needed

* Updated the AbstractModel so that retrieving the mining fields does not exclude any fields

* Added a method to the Treemodel to return the source for a TreeNode java class

* Added context to the name of the generated TreeNode objects, in the templates that use TreeNode

* Created an mvel template to be used in generating the TreeNode java class

  1. … 6 more files in changeset.