Clone
 

sergey polovko <jamel@yandex-team.ru> in Netty

Cookie name must be case sensitive

Motivation:

RFC 6265 does not state that cookie names must be case insensitive.

Modifications:

Fix io.netty.handler.codec.http.cookie.DefaultCookie#equals() method to

use case sensitive String#equals() and String#compareTo().

Result:

It is possible to parse several cookies with same names but with

different cases.

Cookie name must be case sensitive

Motivation:

RFC 6265 does not state that cookie names must be case insensitive.

Modifications:

Fix io.netty.handler.codec.http.cookie.DefaultCookie#equals() method to

use case sensitive String#equals() and String#compareTo().

Result:

It is possible to parse several cookies with same names but with

different cases.

Use ByteProcessor.FIND_LF to find end of line

Motivation:

Each call of ByteBuf.getByte(int) method does boundary checking. This can be eliminated by using ByteBuf.forEachByte(ByteProcessor) method and ByteProcessor.FIND_LF processor.

Modifications:

Find end of line with ByteProcessor.FIND_LF

Result:

A little better performance of LineBasedFrameDecoder.

Use ByteProcessor.FIND_LF to find end of line

Motivation:

Each call of ByteBuf.getByte(int) method does boundary checking. This can be eliminated by using ByteBuf.forEachByte(ByteProcessor) method and ByteProcessor.FIND_LF processor.

Modifications:

Find end of line with ByteProcessor.FIND_LF

Result:

A little better performance of LineBasedFrameDecoder.

Handle only those http requests that equal to adjusted websocket path

Motivation:

It will be easier to support websockets in server application by using WebSocketServerProtocolHandshakeHandler class and not reinvent its functionality. But currently it handles all http requests as if they were websocket handshake requests.

Modifications:

Check if http request path is equals to adjusted websocket path.

Fixed example of websocket server implementation.

Result:

WebSocketServerProtocolHandshakeHandler handles only websocket handshake requests.

Handle only those http requests that equal to adjusted websocket path

Motivation:

It will be easier to support websockets in server application by using WebSocketServerProtocolHandshakeHandler class and not reinvent its functionality. But currently it handles all http requests as if they were websocket handshake requests.

Modifications:

Check if http request path is equals to adjusted websocket path.

Fixed example of websocket server implementation.

Result:

WebSocketServerProtocolHandshakeHandler handles only websocket handshake requests.

Improve SctpMessage.hashCode method

Motivation:

Not all fields of SctpMessage which used to check message equality are used

to generate hashcode.

Modifications:

Use value of 'unordered' field in hashCode method.

Result:

Better hash function of SctpMessage.

Improve SctpMessage.hashCode method

Motivation:

Not all fields of SctpMessage which used to check message equality are used

to generate hashcode.

Modifications:

Use value of 'unordered' field in hashCode method.

Result:

Better hash function of SctpMessage.

Fix SctpMessage.duplicate() behavior

Motivation:

SctpMessage.duplicate() copied message content that leads to additional buffer

allocation and memory copying.

Modifications:

Duplicate message content instead of copying it.

Result:

Better performace and less memory consumption.

Fix SctpMessage.duplicate() behavior

Motivation:

SctpMessage.duplicate() copied message content that leads to additional buffer

allocation and memory copying.

Modifications:

Duplicate message content instead of copying it.

Result:

Better performace and less memory consumption.

fix links to github issues in javadoc

fix links to github issues in javadoc

replace ends -> starts

replace ends -> starts