RichFaces Core 4.2.0.CR1

Activity

REV-RF-12 2

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author      
    Reviewer - 99% reviewed 19m 2 (1 defect) https://issues.jboss.org/browse/RF-11925
    Reviewer - Complete 13m    
    Total   32m 2 (1 defect)  
    #permalink

    Objectives

    Check the code for bugs and confirm that it meets functional, performance, security requirements and coding standards.


    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /api/src/.../application/push/TopicKey.java Changed
    Open in IDE #permalink
    /api/src/.../push/TopicsContext.java Changed
    Open in IDE #permalink
    /api/src/.../resource/ResourceFactory.java Changed
    Open in IDE #permalink
    /api/src/.../resource/ResourceSkinUtils.java Added
    Open in IDE #permalink
    /api/pom.xml Changed
    /impl/src/.../jms/JMSTopicsContextImpl.java Changed
    Open in IDE #permalink
    /impl/src/.../push/impl/PushContextImpl.java Changed
    Open in IDE #permalink
    /impl/src/main/.../push/impl/RequestImpl.java Changed
    /impl/src/main/.../push/impl/SessionImpl.java Changed
    /impl/.../application/CoreConfiguration.java Changed
    /impl/.../application/InitializationListener.java Changed
    /impl/.../resource/ExternalStaticResource.java Changed
    /impl/.../resource/ResourceFactoryImpl.java Changed
    /impl/.../resource/ResourceLoadingOptimization.java Added
    /impl/.../resource/ResourceMappingConfiguration.java Changed
    /impl/.../resource/ResourceMappingFeature.java Changed
    /impl/src/.../resource/Xcss2EcssConverter.java Changed
    /impl/src/.../webapp/PushHandlerFilter.java Changed 2
    /impl/src/.../webapp/PushServlet.java Changed
    /impl/src/.../org/richfaces/VersionBean.java Changed
    /impl/src/.../org/richfaces/VersionBean.java Changed
    Open in IDE #permalink
    /impl/src/.../META-INF/resources/jquery.js Changed
    /impl/src/.../META-INF/resources/skinning.ecss Changed
    Open in IDE #permalink
    /impl/src/.../skins/DEFAULT.skin.properties Changed
    /impl/src/.../skins/NULL.skin.properties Changed
    /impl/.../resource/AbstractResourceMappingTest.java Added
    Open in IDE #permalink
    /impl/.../resource/ResourceFactoryImplStaticResourcesTest.java Added
    /impl/.../resource/ResourceMappingConfigurationTest.java Added
    /impl/.../resource/ResourceMappingFeatureLocationTest.java Added
    /impl/.../resource/ResourceMappingFeatureMappingTest.java Added
    /impl/.../resource/ResourceMappingFeatureTest.java Added
    Open in IDE #permalink
    /impl/.../staticResourceMapping/Static.properties Added
    Open in IDE #permalink
    /impl/.../richfaces/static-resource-mappings.properties Added
    Open in IDE #permalink
    /impl/src/.../resource/mapping-test.properties Deleted
    Open in IDE #permalink
    /impl/.../resource/mapping-test1.properties Added
    Open in IDE #permalink
    /impl/.../resource/mapping-test2.properties Added
    Open in IDE #permalink
    /impl/pom.xml Changed
    /impl/pom.xml Changed
    /legacy-tests/pom.xml Changed
    /legacy-tests/pom.xml Changed
    Open in IDE #permalink
    /parent/pom.xml Changed
    Open in IDE #permalink
    /pom.xml Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against