[ELY-1620] Support of enumerated into ASN1Decoder

Activity

REV-WFLY-5 4

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author 4m 1 Bla bla bla
    Reviewer - 28% reviewed 2m 1 Lazy!
    Reviewer - 99% reviewed 5m 2 Test non-required resolution comment.
    Total   10m 4  
    #permalink

    Objectives

    Check the code for bugs and confirm that it meets functional, performance, security requirements and coding standards.

    • ELY-1620 Support of enumerated into ASN1Decoder
    • ELY-1617 OCSP client into trustmanager
    • ELY-1617 OCSP tests, SSLAuthenticationTest refac
    • ELY-1617 OCSP: Added unit test for certId.equals() method

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /src/main/.../_private/ElytronMessages.java Changed
    Open in IDE #permalink
    /src/main/java/.../asn1/util/ASN1.java Changed
    Open in IDE #permalink
    /src/main/.../security/asn1/ASN1Decoder.java Changed 1
    Open in IDE #permalink
    /src/main/.../security/asn1/DERDecoder.java Changed
    Open in IDE #permalink
    /src/.../ssl/OcspExtendedTrustManager.java Added
    Open in IDE #permalink
    /src/main/java/.../x500/cert/ocsp/CertId.java Added
    Open in IDE #permalink
    /src/main/.../ocsp/OcspCachingChecker.java Added
    Open in IDE #permalink
    /src/main/.../cert/ocsp/OcspChainVerifier.java Added
    Open in IDE #permalink
    /src/main/java/.../cert/ocsp/OcspChecker.java Added
    Open in IDE #permalink
    /src/main/.../cert/ocsp/OcspOnlineChecker.java Added
    Open in IDE #permalink
    /src/main/java/.../cert/ocsp/OcspRequest.java Added
    Open in IDE #permalink
    /src/main/java/.../cert/ocsp/OcspResponse.java Added
    Open in IDE #permalink
    /src/main/.../ocsp/OcspSignatureVerifier.java Added
    Open in IDE #permalink
    /src/main/java/.../cert/ocsp/OcspStatus.java Added
    Open in IDE #permalink
    /src/main/java/.../security/x500/X500.java Changed
    Open in IDE #permalink
    /src/test/.../ssl/SSLAuthenticationTest.java Changed 1
    Open in IDE #permalink
    /src/test/.../cert/ocsp/OcspCertIdTest.java Added
    Open in IDE #permalink
    /src/test/.../cert/ocsp/OcspParsingTest.java Added
    Open in IDE #permalink
    /src/test/.../cert/ocsp/TestingOcspServer.java Added
    Open in IDE #permalink
    /src/.../ssl/wildfly-ssl-test-config-v1_1.xml Changed
    Open in IDE #permalink
    /src/test/.../cert/ocsp/ocsp-db.properties Added 2
    Open in IDE #permalink
    /src/test/.../cert/ocsp/ocsp-responder.xml Added
    Open in IDE #permalink
    /pom.xml Changed
    Open in IDE #permalink

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time against