JBoss Tools

Good

Good

test

test

org.jboss.tools.common.el.core
org.jboss.tools.common.el.core
https://issues.jboss.org/browse/JBIDE-11883 Add newly generated entities to persistence.xml
https://issues.jboss.org/browse/JBIDE-11883 Add newly generated entities to persistence.xml
Why delay in 1 sec is required here?

Why delay in 1 sec is required here?

JBIDE-12479 https://issues.jboss.org/browse/JBIDE-12479 XModel file objects should not keep references...
JBIDE-12479 https://issues.jboss.org/browse/JBIDE-12479 XModel file objects should not keep references...
https://issues.jboss.org/browse/JBIDE-12829 : BrowserSim disappearing (see video)
https://issues.jboss.org/browse/JBIDE-12829 : BrowserSim disappearing (see video)
Returning null here will probably lead to null pointer exception somewhere. It might happen because implementation of the method transform(E1 value) usually called in next() and previous() methods ...

Returning null here will probably lead to null pointer exception somewhere. It might happen because implementation of the method transform(E1 value) usually called in next() and previous() methods in various iterator implementations. Looking through various implementation for TreansformationIterable<C1,C2> I've never seen it returning null.

Post this exception in eclipse log instead of hiding it

Post this exception in eclipse log instead of hiding it

It should be in finally to avoid listener leak in case of exception in ws.launch() call

It should be in finally to avoid listener leak in case of exception in ws.launch() call

Add proper logging (see previous note)

Add proper logging (see previous note)

Add exception to the log HibernateJptUIPlugin.logException(e) instead of polluting standard output

Add exception to the log HibernateJptUIPlugin.logException(e) instead of polluting standard output

If this happens, we never know why deployments list is empty.

If this happens, we never know why deployments list is empty.

Right to the point https://source.jboss.org/static/ovygef/2static/images/wiki/icons/emoticons/smile.gif Will stick to the error handling issues only, because about there are about 50 empty catch bl...

Right to the point Will stick to the error handling issues only, because about there are about 50 empty catch blocks only in as.core.

This is beyond micro-managing and now into nit-picking and coding style. These are the types of code reviews I hope to never read again. Both codes are 100% functionally equivalent and this comment...

This is beyond micro-managing and now into nit-picking and coding style. These are the types of code reviews I hope to never read again. Both codes are 100% functionally equivalent and this comment serves zero purpose at all. What "looks better" to you does not "look better" to other people.