Jozef Marko

DROOLS-5249: do not store DateTimeFormatter as free form line (#2859)

We have two kinds of date boiler plate code snippets. For:

- java.util.Date: 'java.text.SimpleDateFormat sdf'

- java.time.LocalDate: 'java.time.format.DateTimeFormatter dtf'

If user set value either of 'Date' or 'LocalDate' field using 'Literal Value' guided editor action, the given date boiler plate is generated automatically behind the scene. This allows users to put in just value of date, e.g. "01-Jan-2000". User do not have to use parametric constructors, builders, parsers or factory methods. It is done behind the scene using 'sdf' or 'dtf' BoilerPlate.

If users set value either of 'Date' ot 'LocalDate' field using 'Formula' guided editor action, is their responsibility to construct 'Date' or 'LocalDate' instance.

For more details see https://issues.redhat.com/browse/DROOLS-5249

DROOLS-5249: do not store DateTimeFormatter as free form line (#2867)

We have two kinds of date boiler plate code snippets. For:

- java.util.Date: 'java.text.SimpleDateFormat sdf'

- java.time.LocalDate: 'java.time.format.DateTimeFormatter dtf'

If user set value either of 'Date' or 'LocalDate' field using 'Literal Value' guided editor action, the given date boiler plate is generated automatically behind the scene. This allows users to put in just value of date, e.g. "01-Jan-2000". User do not have to use parametric constructors, builders, parsers or factory methods. It is done behind the scene using 'sdf' or 'dtf' BoilerPlate.

If users set value either of 'Date' ot 'LocalDate' field using 'Formula' guided editor action, is their responsibility to construct 'Date' or 'LocalDate' instance.

For more details see https://issues.redhat.com/browse/DROOLS-5249

DROOLS-4720-4721: Replace equals with Objects.equals (#2847)

Small refactoring to minimize risk of NPE during equals method call

For more details see

- https://issues.redhat.com/browse/DROOLS-4720

- https://issues.redhat.com/browse/DROOLS-4721

DROOLS-5109: use kie-soup DataType (#2823)

We had two same instances of 'DataType' class. This removes one of them.

For more details see https://issues.redhat.com/browse/DROOLS-5109

DROOLS-4650: Fix missing equals implementations (#2624)

* DROOLS-4650 : GDST: Re-editing BRL columns causes NPE (#2587)

* DROOLS-4650 : GDST: Re-editing BRL columns causes NPE

* DROOLS-4650: Reimplement equals of drools-workbench-models-guided-dtable

* DROOLS-4650: Incorporate review feedback, bring test to the original state

* DROOLS-4650: Fix missing equals implementations

In original DROOLS-4650 PR we missed some equals implementations what caused to fail tests in drools-wb repository. This PR fixes it.

* DROOLS-4650: Increase coverage

* DROOLS-4650: Implement missing hashCode

Sonar reported missing hashCode methods in classes where equals was already overriden

Unfortunately these 4 classes have no fields. So no more than calling super.hashCode() can be done.

  1. … 27 more files in changeset.
RHPAM-2307: Remove unused dependencies (#2619)

During RHPAM-2307 review some unused dependencies were found.

DROOLS-4539: Prevent NPE in getting scenario result (#2593) (#2610)

During getting test scenario result we need to prevent NPE as we do not use `boolean` but `Boolean`

DROOLS-4539: Clean up drools-workbench-models-test-scenarios dependencies (#2609)

During https://issues.jboss.org/browse/DROOLS-4539 an unused dependency was found. This PR removes it.

DROOLS-4539: Prevent NPE in getting scenario result (#2593)

During getting test scenario result we need to prevent NPE as we do not use `boolean` but `Boolean`

DROOLS-4448: Increase coverage (#2591)

DROOLS-4649: Add a reproducer test (#2584)

* DROOLS-4649: Add a reproducer test

* DROOLS-4649: Rebase with master, Use mvelExpression helper method

DROOLS-4448: Increase coverage (#2590)

RHPAM-2457: Add a reproducer test (#2588)

DROOLS-4448: Simplify if then else statement (#2589)

During DROOLS-4448 review, complex if then else statements were spotted. This PR reduces the complexity of those if then else statements.

Remove the copied method (#2586)

This PR removes a copy of an existing mehtod. The rmeoved method was used two times while the original one more than 90 times.

DROOLS-4601: SImple refactoring of value list population (#2585)

During https://issues.jboss.org/browse/DROOLS-4601 review short piece of code was found that can be shorten form two lines to single one.

DROOLS-4588: Coverage increase (#2566)

* DROOLS-4588: Increase the coverage

* Proper type of expressions

* Use MVEL_ESCAPE_SYMBOL constant

* Simplify the test due to DROOLS-4649

DROOLS-4425: Refactor drools-workbench-models Attribute constants (#2508)

* DROOLS-4425: Refactor drools-workbench-models Attribute constants

* Add a javadoc

* Remove unsused import

* Remove unsused import

* Incorporate review feedback

* Remove unused imports

  1. … 5 more files in changeset.
Remove drools-workbench-models-datamodel-api unused dependencies (#2423)

DROOLS-4131: Can't use "is contained in the list" for Integer field (#2379)

* DROOLS-4131: Can't use "is contained in the list" for Integer field

This PR check what is the data type of collection used with the "is containded in the list".

If the type is a numeric one, quotes are not added into the generated drl.

* DROOLS-4131: Remove unused dependencies

[DROOLS-3805] All line separators in RHS in spreadsheet are escaped (#2402)

- Unit test

DROOLS-3432: Increase coverage of one template key for two different fields (#2364) (#2403)

DROOLS-3432: Increase coverage of one template key for two different fields (#2364)

Remove unused dependency org.eclipse.aether:aether-spi (#2365)

* Remove unused dependency org.eclipse.aether:aether-spi

* remove aether-util

* remove aether-transport-http

* remove aether-transport-file

* remove guice

* remove maven-artifact

* remove maven-plugin-api

* remove httpcore

* remove ant

DROOLS-3673: Disable inserting rows according to string id (#2265)

* DROOLS-3673: Disable inserting rows according to string id

* DROOLS-3673: Extend coverage

Test list contains for structures (#2256)

RHPAM-1550: Extend coverage of feel variable names (#2253)

DROOLS-3019: Add tests for range of strings (#2245)

BAQE-587: Prevent NPEs in workbench drools verification (#2180)

RHPAM-1184,RHDM-601: Add a reproducer test (#2155)