Max Rydahl Andersen

why not pass on the exception instead of just the text?

why not pass on the exception instead of just the text?

Yes, all good about the catch of Exception - but why not log the cause of error ? And why not have a the poller throw a more specifc exception than exception ?

Yes, all good about the catch of Exception - but why not log the cause of error ?

And why not have a the poller throw a more specifc exception than exception ?

1) for a local filesystem this should be a cheap operation and most people use local filesystems for this - if remote is so much more expensive this should be handled differently in the remote case...

1) for a local filesystem this should be a cheap operation and most people use local filesystems for this - if remote is so much more expensive this should be handled differently in the remote case (i.e. instead of a static method it should be an operation on the filesystem or abstraction of the copying).

2) if it already exists dont we get a more specific error that we can react to ? In any case why not at least log this since there could be so much more wrong here ?

3) And finally - why isn't this logic documented that any errors are ignored because of 1+2 ?

"removeDeployedMarker" is for AS7 - that is what I call new code https://source.jboss.org/static/ovygef/2static/images/wiki/icons/emoticons/wink.gif

"removeDeployedMarker" is for AS7 - that is what I call new code

...and im also wondering how a static method can decide if a file ending in jar needs a restart. That just sounds wrong?

...and im also wondering how a static method can decide if a file ending in jar needs a restart. That just sounds wrong?

agreed.

agreed.

It's not catching checked exceptions- its catching unchecked ones. That is fine as far as I im concerned for this kinda of code.Should pass in the exception to the status message though.

It's not catching checked exceptions- its catching unchecked ones. That is fine as far as I im concerned for this kinda of code.Should pass in the exception to the status message though.

agreed. otherwise it would have to be logged.

agreed. otherwise it would have to be logged.

Guys - this code is agressively catching exceptions to ensure things failing because IO and random other events doesn't cause UI interruption. If we don't catch Exception here then what happens if ...

Guys - this code is agressively catching exceptions to ensure things failing because IO and random other events doesn't cause UI interruption.
If we don't catch Exception here then what happens if lower level errors occur ? it will no longer return Error info and things goes haywire.

The error is in its current state here logged and reported to the user - why changing this ?

This is all new code and returning ok to a remove of deployed marker file should for sure at least be logged. Why it returns OK_STATUS for any exception and there is zero comment about it is scary...

This is all new code and returning ok to a remove of deployed marker file should for sure at least be logged.

Why it returns OK_STATUS for any exception and there is zero comment about it is scary (especially for new code).

Should just get logged IMO.

Should just get logged IMO.

Totally disagree - sure, we don't need to show a ui dialog for this, but if the dispose can throw an Exception then it should at least get logged in eclipse logs at this point. And yes - I'm wonde...

Totally disagree - sure, we don't need to show a ui dialog for this, but if the dispose can throw an Exception then it should at least get logged in eclipse logs at this point.

And yes - I'm wondering then why J7MU.dispose forces a thrown Exception - shouldn't it be a at least a specific type?

Okey - understood but again that specific test was removed from this class in this commit so I guess it is not an issue? Thus my original question stands - what is the difference between the first...

Okey - understood but again that specific test was removed from this class in this commit so I guess it is not an issue?

Thus my original question stands - what is the difference between the first temp folder create and the next one ?

how do you even test for marker check ? I would assume that check is based on the servertype? Note you can add in extra code pointers in the left panel https://source.jboss.org/static/ovygef/2stat...

how do you even test for marker check ? I would assume that check is based on the servertype?

Note you can add in extra code pointers in the left panel

what does as7 folder layout have to do with marker support? the server version is what drives if its as7 is it not ?

what does as7 folder layout have to do with marker support?

the server version is what drives if its as7 is it not ?

that line is removed...so not relevant is it?

that line is removed...so not relevant is it?

Just trying out cruciible with this basic bug fix to learn https://source.jboss.org/static/ovygef/2static/images/wiki/icons/emoticons/wink.gif

Just trying out cruciible with this basic bug fix to learn

What is the difference between this creation and what comes just below under //create temp deploy folder ?

What is the difference between this creation and what comes just below under //create temp deploy folder ?

JBIDE-9133: Utility projects are not zipped inside WEB-INF/lib when deploying to AS7
JBIDE-9133: Utility projects are not zipped inside WEB-INF/lib when deploying to AS7